Switch from rcpputils::fs to std::filesystem#254
Merged
clalancette merged 1 commit intoros:rollingfrom Feb 26, 2024
Merged
Conversation
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
clalancette
approved these changes
Feb 22, 2024
Contributor
clalancette
left a comment
There was a problem hiding this comment.
It looks reasonable to me with green CI. Thanks!
Member
Author
|
Member
Author
|
Well that'll teach me to do a full local build first. Found some downstream breakage. Updated the PR description. |
Member
Author
|
Alright, it all builds locally for me now. Let's try again.
Includes: |
Member
Author
|
@clalancette should I run CI again here, or is the above set enough? It should be equivalent. |
Contributor
Yeah, agreed. I'm going to go ahead and merge this one in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ros2/rcpputils#164
Requires ros-visualization/qt_gui_core#288 (to avoid downstream breakage)
Requires ros-visualization/python_qt_binding#135 (to avoid downstream breakage)
Since this is a header file, some downstream dependencies need to be updated too.