Implement service recording and display info about recorded services (#1480) * Implement service record and recorded service info display Signed-off-by: Barry Xu * Address MichaelOrlov's review comments Signed-off-by: Barry Xu * Add tests for rosbag2_cpp::Info::read_service_info() Signed-off-by: Barry Xu * Updated code on exclude parameters Refer to https://github.com/ros2/rosbag2/pull/1483 Signed-off-by: Barry Xu * Fix flake8 errors Signed-off-by: Barry Xu * Update code to remove hard-coded values to make the code more readable Signed-off-by: Barry Xu * Fix a bug on exclude parameter Signed-off-by: Barry Xu * Update codes on rosbag2 QoS for service event topic Signed-off-by: Barry Xu * Address the second round of review comments Signed-off-by: Barry Xu * Updated info test on getting service info Signed-off-by: Barry Xu * Rename exclude_services to exclude_service_event Signed-off-by: Barry Xu * Address flakiness in newly added rosbag2_transport tests - Got rid form ambient sleep for waiting for messages to be recorded - Exclude "/rosout" topic from recording Signed-off-by: Michael Orlov * Use wait_for_srvice_to_be_ready() instead check_service_ready() - Also add default timeout parameter for ClientManager::send_request(..) Signed-off-by: Michael Orlov * Add rosbag2_test_common::wait_until_condition(..) Signed-off-by: Michael Orlov * Rewrite get_service_info tests to be more deterministic - Also parameterize tests to use default supported storage plugins Signed-off-by: Michael Orlov * Renames in the get_service_info tests Signed-off-by: Michael Orlov * Use `std::filesystem` instead of `rcpputils::fs` functions - Rationale: Deprecation of the rcpputils::fs in future See https://github.com/ros2/rcpputils/issues/164 for details Signed-off-by: Michael Orlov * Avoid extra metadata readout in `ros2 bag info` verb with `--verbose` Signed-off-by: Michael Orlov * Add info_end_to_end test with `--verbose` parameter Signed-off-by: Michael Orlov * Fix bugs in info_with_verbose_option_end_to_end_test Signed-off-by: Barry Xu * Fix segment fault issue in test_rosbag2_cpp_get_service_info.cpp Signed-off-by: Barry Xu * Update a fix for info_with_verbose_option_end_to_end_test Signed-off-by: Barry Xu * Output a warning while setting both '-t' and 'v' for info command Signed-off-by: Barry Xu * Address comments from Fujita-san Signed-off-by: Barry Xu * Use topic_in_list instead of service_in_list Signed-off-by: Michael Orlov * Handle cases when dependent service msg definitions could be in IDL file Signed-off-by: Michael Orlov * Fix rebase errors - Delete "rosbag2_transport/qos.cpp" which was moved to the rosbag2_storage package during prior PR before rebase Signed-off-by: Michael Orlov * Fix the path of a library Signed-off-by: Barry Xu * Resolve the conflicts caused by the rebase Signed-off-by: Barry Xu * Replace sizeof() with strlen() Signed-off-by: Barry Xu * Use consistent variable name Signed-off-by: Barry Xu * Fix a link error on Windows Signed-off-by: Barry Xu * Use visibility control for format library Signed-off-by: Barry Xu * Replace rosbag2_format_output by direct source files linkage - Also put `format_service_info(..)` and `format_bag_meta_data(..)` under the rosbag2_py namespace Signed-off-by: Michael Orlov * Remove header files from pybind modules and delete visibility_control.hpp Signed-off-by: Michael Orlov --------- Signed-off-by: Barry Xu Signed-off-by: Michael Orlov Co-authored-by: Michael Orlov

Deprecate rcpputils::fs in favor of C++17 std::filesystem #164

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Deprecate `rcpputils::fs` in favor of C++17 `std::filesystem` #164