Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

[Windows][melodic] AMCL Windows build bring up.#849

Merged
mikeferguson merged 2 commits intoros-planning:melodic-develfrom
seanyen:amcl_windows_fix
Apr 28, 2019
Merged

[Windows][melodic] AMCL Windows build bring up.#849
mikeferguson merged 2 commits intoros-planning:melodic-develfrom
seanyen:amcl_windows_fix

Conversation

@seanyen
Copy link
Contributor

@seanyen seanyen commented Jan 31, 2019

  • Add HAVE_UNISTD and HAVE_DRAND48 and portable_utils.hpp for better cross compiling.
  • Variable length array is not supported in MSVC, conditionally disable it.
  • Fix install location for shared lib and executables on Windows.
  • Use isfinite for better cross compiling.

This change is verified against the https://aka.ms/ros project.

Sean Yen added 2 commits January 31, 2019 12:08
* Add HAVE_UNISTD and HAVE_DRAND48 and portable_utils.hpp for better cross compiling.
* Variable length array is not supported in MSVC, conditionally disable it.
* Fix install location for shared lib and executables on Windows.
* Use isfinite for better cross compiling.
@seanyen seanyen changed the title [Windows] AMCL Windows build bring up. [Windows][melodic] AMCL Windows build bring up. Feb 8, 2019
@seanyen
Copy link
Contributor Author

seanyen commented Apr 1, 2019

@DLu Hi! Hope I am pinging the correct maintainer. Can you take a look #849 #850 #851? Hope I get some feedbacks if it requires iterations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants