This repository was archived by the owner on Jun 5, 2025. It is now read-only.
[Windows][melodic] Navigation (except for map_server and amcl) Windows build bring up#851
Merged
mikeferguson merged 2 commits intoros-planning:melodic-develfrom Feb 13, 2020
Conversation
Contributor
seanyen
commented
Jan 31, 2019
- Add HAVE_SYS_TIME_H for conditionally disable the code for the system which doesn't have this header and related APIs. (The part to be conditionally disabled are all debug code, so I think it's fine to disable them for Windows build.)
- Fix executable and shared lib install path for Windows.
- attribute ((unused)) is GCC specific attribute, MSVC doesn't have it so let's conditionally define it.
- Add #include to the header which uses std::min and std::max. Otherwise, MSVC will complain undefined functions.
Contributor
Author
Contributor
Author
|
@DLu @mikeferguson Hope I am pinging the correct owner. Let me know if anything I should iterate on. Thanks! |
91d99d3 to
5f2e4b3
Compare
Contributor
Author
|
@DLu @mikeferguson Please excuse me to ping you again. Any chance I can move this PR forward? Thanks! Btw, this PR is also re-based to the latest. Hope that helps the review. |
Contributor
|
Retriggering CI (didn't run for some reason) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.