Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

[Windows][melodic] map_server Windows build bring up#850

Merged
mikeferguson merged 1 commit intoros-planning:melodic-develfrom
seanyen:map_server_windows_fix
Apr 28, 2019
Merged

[Windows][melodic] map_server Windows build bring up#850
mikeferguson merged 1 commit intoros-planning:melodic-develfrom
seanyen:map_server_windows_fix

Conversation

@seanyen
Copy link
Contributor

@seanyen seanyen commented Jan 31, 2019

  • Fix install location for Windows build. (On Windows build, shared library uses RUNTIME location, but not LIBRARY)
  • Use boost::filesystem::path to handle path logic and remove the libgen.h dependency for better cross platform.
  • Fix gtest hard-coded and add YAML library dir in CMakeList.txt.

This change is verified by https://aka.ms/ros project.

* Fix install location for Windows build. (On Windows build, shared library uses RUNTIME location, but not LIBRARY)
* Use boost::filesystem::path to handle path logic and remove the libgen.h dependency for better cross platform.
* Fix gtest hard-coded and add YAML library dir in CMakeList.txt.
@seanyen seanyen changed the title [Windows] map_server Windows build bring up [Windows][melodic] map_server Windows build bring up Feb 8, 2019
@mikeferguson mikeferguson merged commit 66fba70 into ros-planning:melodic-devel Apr 28, 2019
@seanyen
Copy link
Contributor Author

seanyen commented Apr 30, 2019

Thank for the merge!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants