Skip to content

Use fixed thresholds for Trinary yaml#5278

Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom
enwaytech:av/save_map_thresh
Jun 17, 2025
Merged

Use fixed thresholds for Trinary yaml#5278
SteveMacenski merged 1 commit intoros-navigation:mainfrom
enwaytech:av/save_map_thresh

Conversation

@adivardi
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses -
Primary OS tested on Ubuntu
Robotic platform tested on gazebo simulation , Jazzy
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Supersedes #5138

This PR uses fixed values for the threshold saved to the yaml file, in Trinary mode. Similarly to ROS 1.
With this change, Trinary maps loaded created and loaded with the map_server, will now load correctly. This is because the pixel values saved in this mode are constants, so when loading the map the thresholds must lie between the pixel values for correct loading. The thresholds supplied by the user are still used for thresholding the input map before saving (to reduce noise)

Description of documentation updates required from your changes

None

Description of how this change was tested

  • Use ros2 run nav2_map_server map_saver_cli with various arguments. The threshold saved should be fixed to 0.65 and 0.196 in Trinary mode. Other modes should not be affected.

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
@adivardi adivardi force-pushed the av/save_map_thresh branch from db43f8c to 30b22ed Compare June 17, 2025 06:51
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
nav2_map_server/src/map_io.cpp 92.51% <100.00%> (+0.10%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SteveMacenski SteveMacenski merged commit 829e683 into ros-navigation:main Jun 17, 2025
6 checks passed
mergify bot pushed a commit that referenced this pull request Jun 17, 2025
Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
(cherry picked from commit 829e683)
mergify bot pushed a commit that referenced this pull request Jun 17, 2025
Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
(cherry picked from commit 829e683)
SteveMacenski pushed a commit that referenced this pull request Jun 17, 2025
(cherry picked from commit 829e683)

Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Co-authored-by: Adi Vardi <57910756+adivardi@users.noreply.github.com>
SteveMacenski pushed a commit that referenced this pull request Jun 17, 2025
(cherry picked from commit 829e683)

Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Co-authored-by: Adi Vardi <57910756+adivardi@users.noreply.github.com>
@adivardi
Copy link
Contributor Author

adivardi commented Jun 18, 2025

@SteveMacenski Could you please also backport to Jazzy?

mergify bot pushed a commit that referenced this pull request Jun 18, 2025
Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
(cherry picked from commit 829e683)
SteveMacenski pushed a commit that referenced this pull request Jun 18, 2025
(cherry picked from commit 829e683)

Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Co-authored-by: Adi Vardi <57910756+adivardi@users.noreply.github.com>
@SteveMacenski
Copy link
Member

Done

@adivardi adivardi deleted the av/save_map_thresh branch June 26, 2025 05:21
SakshayMahna pushed a commit to SakshayMahna/navigation2 that referenced this pull request Jul 6, 2025
Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Sushant-Chavan added a commit to Sushant-Chavan/navigation2 that referenced this pull request Aug 5, 2025
* Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237)

* Revert "Fix Ci from key signing (ros-navigation#5220)"

This reverts the changes to the Dockerfile done in 1345c22.

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

* Update Cache Version

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

---------

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

* enable_groot_monitoring_ false (ros-navigation#5246)

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>

* Updating readme table for kilted release (ros-navigation#5249)

* updating readme table for kilted release

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Updating table lint

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Add min_distance_to_obstacle parameter to RPP (ros-navigation#4543)

* min_distance_to_obstacle

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* suggestion to time base and combine

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* typo

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* use min_approach_linear_velocity

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

---------

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>

* Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (ros-navigation#5251)

* Update amcl_node.hpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Working for Kilted, Jazzy

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Change max_cost default to 254 (ros-navigation#5256)

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Route server corner smoothing (ros-navigation#5226)

* added edge length method

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* Added corner arc class

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* replaced double vectors with Coordinates, added methods to return start and end coordinates

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* using Coordinates, fixed direction of tangents

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* added corner arc in header, added logger in protected variable

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* first pass of corner smoothing algorithm

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* reassigning next edge to have a different start, if a corner occurs before it

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* using unique pointer instead of raw pointers for new edges and nodes

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* added smoothing parameter

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* made angle of interpolation a parameter

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* const for return methods, added flag for smoothing corners

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* moved getEdgeLength() into the Directional Edge struct

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* using float instead of double

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* smoothing radius is float, couple methods moved to protected

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* removed signed_angle_ as a member variable

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* removed unnecessary member variables

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* removed angle of interpolation and inferring it from path density and radius instead

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* consolidated corner arc into one header function

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* readded newline

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* changed corner arc to corner smoothing

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* replaced the use of edges with coordinates to generate smoothing arc, removed storage of nodes and edges

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* linting

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* fixing cpplint

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* linting for headers

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* cpplinting

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* Update nav2_route/src/path_converter.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_route/src/path_converter.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_route/src/path_converter.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_route/src/path_converter.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_route/include/nav2_route/corner_smoothing.hpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* fixed divide by zeros and accessing empty route.edges

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* uncrustify linting

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* cpp linting

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* path converter linting

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* changed all doubles to floats

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* added check for edges that are colinear to avoid divide by 0, fixed final edge interpolation

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* linting

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* Update nav2_route/include/nav2_route/corner_smoothing.hpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* added doxygen for corner arc class

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* added warning message if corner can't be smoothed

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* added smooth_corners to the nav2 params file

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* added smoothing flag and radius parameter to README.md'

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* typo in README

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* added testing for corner smoothing

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* Update nav2_route/include/nav2_route/corner_smoothing.hpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Conserve curvature with LIMIT action (ros-navigation#5255)

* Conserve curvature with LIMIT action

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fix format

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fix test

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Parametrizing obstacle layer tf filter tolerance (ros-navigation#5261)

Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>

* Add namespace support for rviz costmap cost tool (ros-navigation#5268)

Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com>

* Fix/smac planner orientation goals (ros-navigation#5235)

* cherry pick

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* cherry pick 6a74ba6

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* cherrpy pick

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* include x11 forwarding

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* kind of working version

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* cleanup

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* formatting

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* minor format change

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* change naming

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* minor changes

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* working with new changes

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237)

* Revert "Fix Ci from key signing (ros-navigation#5220)"

This reverts the changes to the Dockerfile done in 1345c22.

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

* Update Cache Version

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

---------

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>
Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* Revert back

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* enable_groot_monitoring_ false (ros-navigation#5246)

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* Updating readme table for kilted release (ros-navigation#5249)

* updating readme table for kilted release

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Updating table lint

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* Add min_distance_to_obstacle parameter to RPP (ros-navigation#4543)

* min_distance_to_obstacle

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* suggestion to time base and combine

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* typo

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* use min_approach_linear_velocity

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

---------

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (ros-navigation#5251)

* Update amcl_node.hpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Working for Kilted, Jazzy

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* Change max_cost default to 254 (ros-navigation#5256)

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* linter

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* remove const

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* pass const pointer by value

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* pass const pointer by value

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

* remove unused param

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>

---------

Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>
Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>
Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com>
Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Fix backport compiler warning (ros-navigation#5277)

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Fix ament mypy (ros-navigation#5280)

* Configured nav2_loopback_sim to be compliant with mypy.

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

* Configured nav2_simple_commander to be compliant with mypy.

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

* Configured nav2_system_tests to be compliant with mypy.

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

---------

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

* Publish zero velocitiy in case of goal failure (ros-navigation#5279)

Signed-off-by: haider8645 <haider_lodhi@hotmail.com>

* Update PULL_REQUEST_TEMPLATE.md

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Use fixed thresholds for Trinary yaml (ros-navigation#5278)

Signed-off-by: Adi Vardi <adi.vardi@enway.ai>

* Add missing include of algorithm in differential_motion_model.cpp (ros-navigation#5293)

Signed-off-by: Silvio Traversaro <silvio@traversaro.it>

* Remove unused unistd.h header from route_tool.cpp (ros-navigation#5292)

Signed-off-by: Silvio Traversaro <silvio@traversaro.it>

* Fix compilation of nav2_smac_planner on Windows (ros-navigation#5291)

Signed-off-by: Silvio <silvio.traversaro@iit.it>

* Large Nav2 Node, Utils, and Interface Refactor (ros-navigation#5288)

* initial unorganized prototype

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* break out files and add doxygen

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding refactor for nav2_ros_common and new ROS interface factories

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* fixing CI - not sure how that got through merge conflicts

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Lifecycle publisher a missing test

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* system tests

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* default

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* activating publishers

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* temp disable allow param qos overrides

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* API update for new constructor option

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Supporting Jazzy and abstracting util

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Review round 1

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding Nav2 Publisher and Subscriber objects to later build upon

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding additional ::SharedPtr for readability

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* fix bug

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* fixing Jazzy support

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* missed one last spot

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding migration instructions

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* more context

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding migration context

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* precommit

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* adding missing dep

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Updating system tess

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* more

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding logging for matched events and dropped messages into pub/sub of new nav2_ros_common package. Also adding QoS overrides default ON (ros-navigation#5302)

* Adding logging for matched events and dropped messages

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* toggle on

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* apply for smac 2D

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update interface_factories.hpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Add LaunchConfigAsBool (Fixes ros-navigation#5233) (ros-navigation#5301)

* Add LaunchConfigAsBool (Fixes ros-navigation#5233)

Signed-off-by: nishalangovender <nishalan.govender@gmail.com>

* Fix Linting

Signed-off-by: nishalangovender <nishalan.govender@gmail.com>

* Fix ament_mypy and pre-commit

Signed-off-by: nishalangovender <nishalan.govender@gmail.com>

* Added Type Annotations

Signed-off-by: Nishalan Govender <nishalan.govender@gmail.com>

* mypy ignore

Signed-off-by: Nishalan Govender <nishalan.govender@gmail.com>

* launch.Substitution

Signed-off-by: Nishalan Govender <nishalan.govender@gmail.com>

* Update All Bools in nav2_bringup

Signed-off-by: Nishalan Govender <nishalan.govender@gmail.com>

---------

Signed-off-by: nishalangovender <nishalan.govender@gmail.com>
Signed-off-by: Nishalan Govender <nishalan.govender@gmail.com>

* Create claude.yml

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update claude.yml

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update claude.yml

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update claude.yml for authorized users

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update claude.yml

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update claude.yml

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding clear costmap around pose service option (ros-navigation#5309)

* Adding clear costmap around pose impl

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_msgs/srv/ClearCostmapAroundPose.srv

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding APIs for simple commander

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* linting

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* adding import

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Fix compiler errors in nav2_map_server

* Fix compiler errors in nav2_costmap_2d

* Add support for enable_lifecycle_services parameter in LifecycleNode (ros-navigation#5307)

Expose the enable_communication_interface parameter from rclcpp_lifecycle::LifecycleNode
through nav2's LifecycleNode wrapper. This allows users to disable lifecycle communication
interfaces when manually managing node lifecycle transitions.

The parameter can be set via NodeOptions parameter overrides:
```cpp
rclcpp::NodeOptions options;
options.parameter_overrides({{"enable_lifecycle_services", false}});
```

Fixes ros-navigation#5305

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

---------

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>
Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>
Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
Signed-off-by: Silvio <silvio.traversaro@iit.it>
Signed-off-by: nishalangovender <nishalan.govender@gmail.com>
Signed-off-by: Nishalan Govender <nishalan.govender@gmail.com>
Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com>
Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: alexanderjyuen <103065090+alexanderjyuen@users.noreply.github.com>
Co-authored-by: Marco Bassa <101661130+MarcoMatteoBassa@users.noreply.github.com>
Co-authored-by: mini-1235 <mauricepurnawan@gmail.com>
Co-authored-by: Stevedan Ogochukwu Omodolor <61468301+stevedanomodolor@users.noreply.github.com>
Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Co-authored-by: Haider <haider_lodhi@hotmail.com>
Co-authored-by: Adi Vardi <57910756+adivardi@users.noreply.github.com>
Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Co-authored-by: Nishalan Govender <137301877+nishalangovender@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
RBT22 pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Sep 11, 2025
…gation#5286)

(cherry picked from commit 829e683)

Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Co-authored-by: Adi Vardi <57910756+adivardi@users.noreply.github.com>
RBT22 pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Dec 1, 2025
…gation#5286)

(cherry picked from commit 829e683)

Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Co-authored-by: Adi Vardi <57910756+adivardi@users.noreply.github.com>
redvinaa pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Dec 3, 2025
* Jazzy Sync 7: May 29 2025 (ros-navigation#5211)

* Dynamic param patterns (ros-navigation#4971)

* redesign dynamic param patterns

Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com>

* change cache version

Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com>

* check that parameter of type double are  >=0.0

Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com>

---------

Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com>

* [nav2_behavior_tree] Add force_use_current_pose to ComputePathToPoseAction (ros-navigation#4925)

* Add force_use_current_pose

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* xml update

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* rename to use_start

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* lint

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* descriptions

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* simplify logic

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

---------

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>

* [CostmapTopicCollisionChecker] Alternative constructor with footprint string (ros-navigation#4926)

* [CostmapTopicCollisionChecker] Alternative constructor with footprint

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* raw pointer

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* suggestions from review

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

---------

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>

* Merged Fix navfn_planner from humble PR ros-navigation#5087 (ros-navigation#5092)

* merged changes from humble for goal.header fix

* reverted back, error in merge

* ported goal.header fix in navfn_planner.cpp from humble

* reverted to navfn_planner.cpp to origin/main

* merged navfn_planner.cpp from humble

* fixed the merge

* Update map_io library to use Eigen method for faster map loading (ros-navigation#5071)

* Update map_io library to use opencv method for faster map loading

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

* Update pre-commit config changes

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

* Use Eigen approach instead of OpenCV

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

* Update pre-commit changes

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

* Update include header include order

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

* Remove intermediary alpha matrix

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

* Add comments for the code understanding

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

* Fix else braces rule issue

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

* Create and use alpha_matrix when applying mask

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

* Update pre-commit changes

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

* Take flip part out of if-else

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

* Update pre-commit changes

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

---------

Signed-off-by: Vignesh T <vignesh.t@kabam.ai>

* Precompute yaw trigonometric values in smac planner (ros-navigation#5109)

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* removing the start navigation message in the paused state from rviz buttons (ros-navigation#5137)

Signed-off-by: Pradheep <padhupradheep@gmail.com>

* Show error if inflation radius is smaller than circumscribed radius (ros-navigation#5148)

* Warn if inflation radius is smaller than circumscribed radius

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Update nav2_mppi_controller/src/critics/cost_critic.cpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Tony Najjar <t03578624@gmail.com>

* Update nav2_smac_planner/include/nav2_smac_planner/utils.hpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Tony Najjar <t03578624@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: Tony Najjar <t03578624@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Prevent MPPI controller from resetting speed limits upon goal execution. (ros-navigation#5165)

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

* Fixing docking server when already docked at the requeste ddock (ros-navigation#5171)

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding parameter util to node utils (ros-navigation#5154)

* Adding declare_or_get_param util to node utils

Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>

* Adding test for declare_or_get_param util

Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>

* Adding declare_or_get_parameter function by type, using explicit variable names, disabling param warnings by default

Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>

* Update nav2_util/test/test_node_utils.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Fixing codecove test

Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>

* Catching possible exception in declare_or_get_by_type

Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>

* Templating return type of declare parameter by value

Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>

---------

Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* added config for laserscan in lb-sim (ros-navigation#5174)

* added config for laserscan in lb-sim

Signed-off-by: RamanaBotta <ramanab@bosonmotors.com>

* fixing ament_flake8 errors

Signed-off-by: RamanaBotta <ramanab@bosonmotors.com>

* review: use_inf is default:true and added parameters on readme ros-navigation#4992

Signed-off-by: RamanaBotta <ramanab@bosonmotors.com>

* refactor: meaningfull value for scan_angle_increment

Signed-off-by: RamanaBotta <ramanab@bosonmotors.com>

---------

Signed-off-by: RamanaBotta <ramanab@bosonmotors.com>
Co-authored-by: RamanaBotta <ramanab@bosonmotors.com>

* Publish planned footprints after smoothing (ros-navigation#5155)

* Publish planned footprints after smoothing

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Revert "Publish planned footprints after smoothing"

This reverts commit c9b349a.

* Add smoothed footprints publishing

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fix formatting

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Fix indentation for publisher creation in SmacPlannerHybrid and SmacPlannerLattice

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* address PR comments

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fixes

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fix build error

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fixing deprecation warning (ros-navigation#5182)

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding missing dep to loopback sim (ros-navigation#5204)

* Adding missing dep

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* typo

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* updating fix

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding parameter warn_when_defaulting_parameters to control default parameter warnings (ros-navigation#5189)

* Adding a parameter warn_when_defaulting_parameters to control default parameter warnings instead of using a flag

Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>

* Adding parameter strict_param_loading for optionally throwing an exception if parameter overrides are missing

Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>

* Using default false declaration instead of declare_or_get in param util

Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>

---------

Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>

* bumping to 1.3.7 for release

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com>
Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Signed-off-by: Vignesh T <vignesh.t@kabam.ai>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Pradheep <padhupradheep@gmail.com>
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: Tony Najjar <t03578624@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>
Signed-off-by: RamanaBotta <ramanab@bosonmotors.com>
Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com>
Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Sandeep Dutta <quark01@gmail.com>
Co-authored-by: Vignesh T <vignesh.t@kabam.ai>
Co-authored-by: mini-1235 <mauricepurnawan@gmail.com>
Co-authored-by: Pradheep Krishna <padhupradheep@gmail.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Co-authored-by: Marco Bassa <101661130+MarcoMatteoBassa@users.noreply.github.com>
Co-authored-by: Raman <52356167+RamanRobotics@users.noreply.github.com>
Co-authored-by: RamanaBotta <ramanab@bosonmotors.com>

* Fixing Jazzy CI via new ROS 2 keys

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Revert "Fix Ci from key signing (ros-navigation#5220)" (backport ros-navigation#5237) (ros-navigation#5239)

* Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237)

* Revert "Fix Ci from key signing (ros-navigation#5220)"

This reverts the changes to the Dockerfile done in 1345c22.

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

* Update Cache Version

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>

---------

Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com>
(cherry picked from commit 7f561b0)

# Conflicts:
#	.circleci/config.yml

* Update config.yml

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Backport bidirectional settings ros-navigation#4954 (ros-navigation#5260)

Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>

* Add namespace support for rviz costmap cost tool (ros-navigation#5271)

Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com>

* Use fixed thresholds for Trinary yaml (ros-navigation#5278) (ros-navigation#5286)

(cherry picked from commit 829e683)

Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Co-authored-by: Adi Vardi <57910756+adivardi@users.noreply.github.com>

* Clear costmap around pose jazzy (backport ros-navigation#5309) (ros-navigation#5318)

* Adding clear costmap around pose service option (ros-navigation#5309)

(cherry picked from commit c0bf67e
Signed-off-by: dw25628 <dwoodwell@vermeer.com>

* Linting

Signed-off-by: dw25628 <dwoodwell@vermeer.com>

* Removed __init__.py that came in with cherry pick

Signed-off-by: dw25628 <dwoodwell@vermeer.com>

---------

Signed-off-by: dw25628 <dwoodwell@vermeer.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Backport "Option to Reduce Lethal to High-Cost Navigable To Get Out of Keepout Zones if Wandered In" (ros-navigation#5378)

* Option to Reduce Lethal to High-Cost Navigable To Get Out of Keepout Zones if Wandered In (ros-navigation#5187)

* Adding toggle option of keepout zone

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Default off

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Join conditions

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* spell check

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* copilot suggestions

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp

Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp

Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update keepout_filter.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

* Revert bringup params changes

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>

* Adding minimum range to PC2 in collision monitor (backport ros-navigation#5392) (ros-navigation#5393)

* Adding minimum range to PC2 in collision monitor (ros-navigation#5392)

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
(cherry picked from commit 40a0451)

# Conflicts:
#	nav2_collision_monitor/src/pointcloud.cpp

* Update pointcloud.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update pointcloud.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update sources_test.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Construct TF listeners passing nodes, spinning on separate thread (backport ros-navigation#5406) (ros-navigation#5431)

* Construct TF listeners passing nodes, spinning on separate thread (ros-navigation#5406)

* Construct TF listeners passing nodes, spinning on separate thread

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

* (tentative) pin down of the impacting change

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

---------

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
(cherry picked from commit 1468484)

# Conflicts:
#	nav2_route/src/route_server.cpp

* Delete nav2_route/src/route_server.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Fix lifecycle manager deadlock during shutdown (ros-navigation#5448)

Signed-off-by: Jacob Visser <jacob.visser@cboost.nl>

* fix 5456 (ros-navigation#5458)

Signed-off-by: David G <david.randommail1@gmail.com>

* backport the fix for setting binary_state as the default (ros-navigation#5459)

Signed-off-by: olaghattas <olaghattas@hotmail.com>

* Sync Jazzy Aug 19, 2025 1.4.1 (ros-navigation#5469)

* Conserve curvature with LIMIT action (ros-navigation#5255)

* Conserve curvature with LIMIT action

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fix format

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fix test

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Adding epsilon for voxel_layer precision loss (ros-navigation#5314)

* Adding epsilon for voxel_layer precision loss

Signed-off-by: bhx <1273698633@qq.com>

* Update nav2_costmap_2d/plugins/voxel_layer.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_costmap_2d/plugins/voxel_layer.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_costmap_2d/plugins/voxel_layer.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: bhx <1273698633@qq.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* fix: correct ThroughActionResult type alias in would_a_planner_recovery_help_condition (ros-navigation#5326)

The ThroughActionResult type alias was incorrectly referencing Action::Result 
instead of ThroughAction::Result, causing the condition to not work properly 
for ComputePathThroughPoses actions.

Fixes ros-navigation#5324

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* Adding slow down at target heading to RPP Controller (ros-navigation#5361)

* Adding slow down at target heading to RPP

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Update test_regulated_pp.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Eexception rethrow in dockRobot method (ros-navigation#5364)

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Add global min obstacle height in voxel layer (ros-navigation#5389)

* Add min obstacle height in voxel layer

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix linting

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>

* [DEX] Enforce 3 digits precision (ros-navigation#5398)

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>

* [static_layer] limit comparison precision (ros-navigation#5405)

* [DEX] limit comparison precision

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* EPSILON 1e-5

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

---------

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>

* Smooth path even if goal pose is so much near to the robot (ros-navigation#5423)

* Smooth path even if goal pose is so much near to the robot

Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com>

* Apply suggestions

Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com>

* Remove unnecessary diff

Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com>

---------

Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com>

* Fix KeepoutFilter on the ARM architecture (ros-navigation#5436)

Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>

* Fix missing dependency (ros-navigation#5460)

* bump to 1.3.8 for Jazzy release Aug 19, 2025

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* load balance CI

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: bhx <1273698633@qq.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com>
Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: hutao <108395177+coderbaibai@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Alberto Tudela <ajtudela@gmail.com>
Co-authored-by: mini-1235 <mauricepurnawan@gmail.com>
Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Cihat Kurtuluş Altıparmak <cihataltiparmak1@gmail.com>
Co-authored-by: Sushant Chavan <gitecsvc@gmail.com>
Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl>

* fix: Move SmootherParams declaration outside smooth_path conditional (ros-navigation#5473) (ros-navigation#5474)

Fixes crash when dynamically changing smooth_path parameter from false to true.
The issue occurred because SmootherParams were only declared when smooth_path
was initially true, causing ParameterModifiedInCallbackException when trying
to declare parameters within the dynamic parameter callback.

Now SmootherParams are always declared, making them available for dynamic
reconfiguration regardless of the initial smooth_path value.

Fixes ros-navigation#5472


(cherry picked from commit 69a60df)

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* Replace last pose if only orientation differs in Navfn (ros-navigation#5490) (ros-navigation#5492)

(cherry picked from commit ff80727)

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Co-authored-by: mini-1235 <mauricepurnawan@gmail.com>

* Manual Backport Route Server to Jazzy (ros-navigation#5517)

* Manual backport of Route Server to Jazzy

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* linting

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Fix backport error

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* lint

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Adding in Nav2 BT + Launch

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Jazzy Sync Sept 19, 2025 1.3.9 (ros-navigation#5540)

* Fix dynamic param SmacPlannerLattice  (ros-navigation#5478)

* Fix SmacPlannerLattice dynamic parameter early exit

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* remove comment

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Fix duplicate poses with computePlanThroughPoses (ros-navigation#5488)

* fix-duplicate-poses

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Update nav2_planner/src/planner_server.cpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* Fix seg fault (ros-navigation#5501)

* Fix segmentation fault

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* fix linting

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>

* Add a service for enabling/disabling the collision monitor (ros-navigation#5493)

* Added std_srvs package to dependencies

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Declared service and callback for enabling/disabling collision monitor

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Declared a variable to store collision monitor enable/disable state

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Added initialization for collision monitor enable/disable service

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Implemented service callback for collision monitor enable/disable service

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Removed std_srvs package dependency

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Added Toggle interface

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Replaced Trigger interface with the new Toggle interface

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Added default initialization for enabled flag

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Fixed toggle service name

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Updated toggle logic for collision monitor

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Added a new line at the end of file

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Update nav2_collision_monitor/src/collision_monitor_node.cpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Update nav2_collision_monitor/src/collision_monitor_node.cpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Added enabled check for logging

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Added a unit test for toggle service

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Made the getter const and added a comment

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Replaced rclcpp::spin_some

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

---------

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>

* bump Jazzy to 1.3.9 for release

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Change service type for collision monitor

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Fix backport error

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* update

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: Abhishekh Reddy <helloarm@pm.me>

* Update package version from 1.1.0 to 1.3.9

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Add support for dynamically changing keepout zone (ros-navigation#5429) (ros-navigation#5542)

* Add support for dynamically changing keepout zone



* Linting



* Revert binary and speed changes



---------


(cherry picked from commit e690ef0)

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Co-authored-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix bad_weak_ptr in createBond() by using shared_ptr (backport ros-navigation#5341) (ros-navigation#5563)

Signed-off-by: ymd-stella <world.applepie@gmail.com>

* Fixed crash due to incorrect string construction (ros-navigation#5606) (ros-navigation#5613)

(cherry picked from commit 48e7e06)

Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com>
Co-authored-by: Jay Herpin <159202566+JayHerpin@users.noreply.github.com>

* Add dependency on nav2_route in package.xml (ros-navigation#5639)

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Revert ros-navigation#4971 in Jazzy (ros-navigation#5640)

* Revert ros-navigation#4971 in Jazzy

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Add

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Bumping to 1.3.10 for urgent jazzy regression fixes (ros-navigation#5650)

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Backporting custom height point field into Jazzy. (ros-navigation#5646)

* Summary commit of all changes for adding custom pointcloud field height. (ros-navigation#5586)

Doing this to clear out unsigned commits from history.

Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

* Corrected parameter declaration methods that aren't part of Jazzy.
Fixed parameter typo from some manual merging in pointcloud.cpp

Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

---------

Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>

---------

Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com>
Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Signed-off-by: Vignesh T <vignesh.t@kabam.ai>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Pradheep <padhupradheep@gmail.com>
Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: Tony Najjar <t03578624@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>
Signed-off-by: RamanaBotta <ramanab@bosonmotors.com>
Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Signed-off-by: dw25628 <dwoodwell@vermeer.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Jacob Visser <jacob.visser@cboost.nl>
Signed-off-by: David G <david.randommail1@gmail.com>
Signed-off-by: olaghattas <olaghattas@hotmail.com>
Signed-off-by: bhx <1273698633@qq.com>
Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com>
Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Signed-off-by: ymd-stella <world.applepie@gmail.com>
Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com>
Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com>
Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Sandeep Dutta <quark01@gmail.com>
Co-authored-by: Vignesh T <vignesh.t@kabam.ai>
Co-authored-by: mini-1235 <mauricepurnawan@gmail.com>
Co-authored-by: Pradheep Krishna <padhupradheep@gmail.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Co-authored-by: Marco Bassa <101661130+MarcoMatteoBassa@users.noreply.github.com>
Co-authored-by: Raman <52356167+RamanRobotics@users.noreply.github.com>
Co-authored-by: RamanaBotta <ramanab@bosonmotors.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
Co-authored-by: Adi Vardi <57910756+adivardi@users.noreply.github.com>
Co-authored-by: dw25628 <108828484+dw25628@users.noreply.github.com>
Co-authored-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Co-authored-by: cboostjvisser <89262699+cboostjvisser@users.noreply.github.com>
Co-authored-by: DavidG-Develop <147402604+DavidG-Develop@users.noreply.github.com>
Co-authored-by: olaghattas <98136555+olaghattas@users.noreply.github.com>
Co-authored-by: hutao <108395177+coderbaibai@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Alberto Tudela <ajtudela@gmail.com>
Co-authored-by: Cihat Kurtuluş Altıparmak <cihataltiparmak1@gmail.com>
Co-authored-by: Sushant Chavan <gitecsvc@gmail.com>
Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl>
Co-authored-by: Abhishekh Reddy <helloarm@pm.me>
Co-authored-by: ymd-stella <7959916+ymd-stella@users.noreply.github.com>
Co-authored-by: Jay Herpin <159202566+JayHerpin@users.noreply.github.com>
Co-authored-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants