Route server corner smoothing#5226
Merged
SteveMacenski merged 48 commits intoros-navigation:mainfrom Jun 12, 2025
Merged
Conversation
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
…rt and end coordinates Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
…efore it Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
Make sure to add doxygen + update configuration guide / readme for the new parameters. I think the visualization still needs this, but generally I think this strategy can be copy+pasted
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
… radius instead Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
… removed storage of nodes and edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
SteveMacenski
requested changes
Jun 11, 2025
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Contributor
|
@alexanderjyuen, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
…yuen/navigation2 into route_server_corner_smoothing
Contributor
|
@alexanderjyuen, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Contributor
|
@alexanderjyuen, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Contributor
|
@alexanderjyuen, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Contributor
|
@alexanderjyuen, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Contributor
|
@alexanderjyuen, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Contributor
|
@alexanderjyuen, your PR has failed to build. Please check CI outputs and resolve issues. |
SteveMacenski
approved these changes
Jun 12, 2025
Member
|
@alexanderjyuen just missing the migration guide for docs and we're good to go! |
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
* added edge length method Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Added corner arc class Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * replaced double vectors with Coordinates, added methods to return start and end coordinates Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using Coordinates, fixed direction of tangents Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added corner arc in header, added logger in protected variable Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * first pass of corner smoothing algorithm Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * reassigning next edge to have a different start, if a corner occurs before it Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using unique pointer instead of raw pointers for new edges and nodes Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smoothing parameter Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * made angle of interpolation a parameter Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * const for return methods, added flag for smoothing corners Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * moved getEdgeLength() into the Directional Edge struct Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using float instead of double Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * smoothing radius is float, couple methods moved to protected Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed signed_angle_ as a member variable Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed unnecessary member variables Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed angle of interpolation and inferring it from path density and radius instead Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * consolidated corner arc into one header function Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * readded newline Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * changed corner arc to corner smoothing Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * replaced the use of edges with coordinates to generate smoothing arc, removed storage of nodes and edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * fixing cpplint Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting for headers Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * cpplinting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fixed divide by zeros and accessing empty route.edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * uncrustify linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * cpp linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * path converter linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * changed all doubles to floats Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added check for edges that are colinear to avoid divide by 0, fixed final edge interpolation Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * added doxygen for corner arc class Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added warning message if corner can't be smoothed Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smooth_corners to the nav2 params file Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smoothing flag and radius parameter to README.md' Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * typo in README Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added testing for corner smoothing Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> (cherry picked from commit 792bcac)
7 tasks
SteveMacenski
added a commit
that referenced
this pull request
Jun 12, 2025
* added edge length method * Added corner arc class * replaced double vectors with Coordinates, added methods to return start and end coordinates * using Coordinates, fixed direction of tangents * added corner arc in header, added logger in protected variable * first pass of corner smoothing algorithm * reassigning next edge to have a different start, if a corner occurs before it * using unique pointer instead of raw pointers for new edges and nodes * added smoothing parameter * made angle of interpolation a parameter * const for return methods, added flag for smoothing corners * moved getEdgeLength() into the Directional Edge struct * using float instead of double * smoothing radius is float, couple methods moved to protected * removed signed_angle_ as a member variable * removed unnecessary member variables * removed angle of interpolation and inferring it from path density and radius instead * consolidated corner arc into one header function * readded newline * changed corner arc to corner smoothing * replaced the use of edges with coordinates to generate smoothing arc, removed storage of nodes and edges * linting * fixing cpplint * linting for headers * cpplinting * Update nav2_route/src/path_converter.cpp * Update nav2_route/src/path_converter.cpp * Update nav2_route/src/path_converter.cpp * Update nav2_route/src/path_converter.cpp * Update nav2_route/include/nav2_route/corner_smoothing.hpp * fixed divide by zeros and accessing empty route.edges * uncrustify linting * cpp linting * path converter linting * changed all doubles to floats * added check for edges that are colinear to avoid divide by 0, fixed final edge interpolation * linting * Update nav2_route/include/nav2_route/corner_smoothing.hpp * added doxygen for corner arc class * added warning message if corner can't be smoothed * added smooth_corners to the nav2 params file * added smoothing flag and radius parameter to README.md' * typo in README * added testing for corner smoothing * Update nav2_route/include/nav2_route/corner_smoothing.hpp --------- (cherry picked from commit 792bcac) Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: alexanderjyuen <103065090+alexanderjyuen@users.noreply.github.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
SteveMacenski
added a commit
that referenced
this pull request
Jun 17, 2025
* added edge length method Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Added corner arc class Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * replaced double vectors with Coordinates, added methods to return start and end coordinates Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using Coordinates, fixed direction of tangents Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added corner arc in header, added logger in protected variable Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * first pass of corner smoothing algorithm Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * reassigning next edge to have a different start, if a corner occurs before it Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using unique pointer instead of raw pointers for new edges and nodes Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smoothing parameter Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * made angle of interpolation a parameter Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * const for return methods, added flag for smoothing corners Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * moved getEdgeLength() into the Directional Edge struct Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using float instead of double Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * smoothing radius is float, couple methods moved to protected Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed signed_angle_ as a member variable Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed unnecessary member variables Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed angle of interpolation and inferring it from path density and radius instead Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * consolidated corner arc into one header function Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * readded newline Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * changed corner arc to corner smoothing Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * replaced the use of edges with coordinates to generate smoothing arc, removed storage of nodes and edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * fixing cpplint Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting for headers Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * cpplinting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fixed divide by zeros and accessing empty route.edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * uncrustify linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * cpp linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * path converter linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * changed all doubles to floats Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added check for edges that are colinear to avoid divide by 0, fixed final edge interpolation Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * added doxygen for corner arc class Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added warning message if corner can't be smoothed Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smooth_corners to the nav2 params file Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smoothing flag and radius parameter to README.md' Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * typo in README Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added testing for corner smoothing Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
SteveMacenski
added a commit
that referenced
this pull request
Jun 17, 2025
* Add speed filter zones to depot and warehouse maps. (#5146) * Added keepout prefix to keepout zone related params. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Add namespace support for speed filter zones. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added speed filter zones to depot and warehouse maps. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added dedicated launch file for speed zone support. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Updated rviz2 config to include speed zone filter. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Preserve initial nature of costmap filters tests. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Enable namespace for the speed limit topic. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Update speed filter zones in depot and warehouse maps Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Readjust speed filter zones in depot and warehouse maps. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Enable namespace support for speed limit topic. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Reduced central speed zone in warehouse map. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * suppress rviz logging to warnings and above (#5163) * suppress rviz to warnings and above Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_bringup/launch/rviz_launch.py Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding Jazzy build job on Main PRs to automatically test Jazzy compatiblity long term (Kilted to come shortly) (#5164) * Adding jazzy testing job Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * on PR not push Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * move dir Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * more Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * moar Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * moar Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * more Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fin Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Prevent MPPI controller from resetting speed limits upon goal execution. (#5165) Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Backward docking without sensors (#5153) * Merge remote-tracking branch 'jakub/backward-docking-without-sensors' into docking_backward Signed-off-by: Jakubach <jakubach@gmail.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Minor fixes and update controller test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Add more tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Move backward_plugin param to plugin Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fixed rotateToDock and tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update readme Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added rotate_to_dock_timeout Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Use angular acceleration te acelerate / decelerate Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added mutex Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix exception Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Revert "Added mutex" This reverts commit 29ff010. Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Rename rotate_to_dock Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Rotate after undock and fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Minor fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Log after rotation Signed-off-by: Alberto Tudela <ajtudela@gmail.com> --------- Signed-off-by: Jakubach <jakubach@gmail.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Speed up CI builds for released distros (#5168) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Save 2 minutes in Main-Jazzy build times to align with other CI job lengths (#5169) * Save 2 minutes in Main-Jazzy build times to align with other CI job lengths Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update build_main_against_distros.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update build_main_against_distros.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Fixing docking server when already docked at the requeste ddock (#5171) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update mergify.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fix MPPI goal critic inversion (#5088) (#5105) * fix MPPI goal critic inversion (#5088) Signed-off-by: brayanpa <brayanspallares@gmail.com> * Support path inversion in all critics (#5088) Signed-off-by: brayanpa <brayanspallares@gmail.com> * Fix code style issues and formatting Signed-off-by: brayanpa <brayanspallares@gmail.com> * Remove trailing whitespaces Signed-off-by: brayanpa <brayanspallares@gmail.com> * Fix goalAngleCritic tests Signed-off-by: brayanpa <brayanspallares@gmail.com> * Normalize code formatting Signed-off-by: brayanpa <brayanspallares@gmail.com> * Add getLastPathPose test Signed-off-by: brayanpa <brayanspallares@gmail.com> * Abstract getCriticGoal in nav2_mppi critics Signed-off-by: brayanpa <brayanspallares@gmail.com> * Fix whitespace issues Signed-off-by: brayanpa <brayanspallares@gmail.com> * Fix getCriticGoal test Signed-off-by: brayanpa <brayanspallares@gmail.com> --------- Signed-off-by: brayanpa <brayanspallares@gmail.com> Signed-off-by: Brayan Pallares <brayanspallares@gmail.com> * Add stateful to regulated pure pursuit controller (#5167) * add_stateful_to_regulated_pure_pursuit_controller Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> * fix naming Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> * fix naming left over Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> * resolve comments Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> * typo Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> * add unit test for both cases stateful and not stateful Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> --------- Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> * tf2 uses hpp headers in rolling (and is backported) (#5180) Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> * added config for laserscan in lb-sim (#5174) * added config for laserscan in lb-sim Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * fixing ament_flake8 errors Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * review: use_inf is default:true and added parameters on readme #4992 Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * refactor: meaningfull value for scan_angle_increment Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> --------- Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> Co-authored-by: RamanaBotta <ramanab@bosonmotors.com> * Publish planned footprints after smoothing (#5155) * Publish planned footprints after smoothing Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Revert "Publish planned footprints after smoothing" This reverts commit c9b349a. * Add smoothed footprints publishing Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix formatting Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Fix indentation for publisher creation in SmacPlannerHybrid and SmacPlannerLattice Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * address PR comments Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fixes Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix build error Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fixing deprecation warning (#5182) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Removing action server timeout duration after fixes to ROS 2, Reverts 3787 (#5183) * Removing action server timeout duration after fixes to ROS 2 Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fix build warning Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * action timeout in BT client edits error code and string (#5184) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Dynamic Parameters Only validating params that are part of the plugin (#5106) * Only validating params that are part of the plugin Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * review Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Refactoring type with param_type and name with param_name to get more consistency. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Check if plugin_name is part of param_name Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Check if param_name contains name_ Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Uncrustify Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Add check param name in dynamic parameter upate. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fix Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Remove controller_frequency as dynamic parameter Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "Merge remote-tracking branch 'origin/main' into FixNamespaceCheck" This reverts commit 7632e41, reversing changes made to 19afc9e. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Fix merge errors. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Add missing check to simple_goal_checker Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Handel param_name resolution for smac_planner_hybrid Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fix typo Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * uncrustify Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fix Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "uncrustify" This reverts commit 43749c2. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * uncrustify Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "uncrustify" This reverts commit e18f704. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Revert "fix" This reverts commit a0a7892. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'upstream/main' into FixNamespaceCheck Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * MPPI Check Namespace. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * fixing parameter_handler tests. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Fix optimizer Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Fix indentation Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * mppi param handler only execute post_callbacks if a param of mppi was updated. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update nav2_rotation_shim_controller.hpp Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> * Review Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_mppi_controller/src/parameters_handler.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Increase Readability of testing. (#5190) Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Add value rewrites to RewrittenYaml (#5191) * Added context manager for safe file closing and prevent warnings. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Implement value_rewrites to ReWrittenYaml. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Use placeholders for costmap filters using the new value rewrite feature. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Enable system tests to use value rewrites. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Define remappings for costmap filters instead of inline substitution. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Updates for Kilted Branch off (#5199) * Adding kilted build to main branch workflow Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Updating kilted for ci image build Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Bumping to 1.4.0 for kilted release Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Removing underlay workspace from Main (#5200) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding missing dep to loopback sim (#5204) * Adding missing dep Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * typo Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * updating fix Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding parameter warn_when_defaulting_parameters to control default parameter warnings (#5189) * Adding a parameter warn_when_defaulting_parameters to control default parameter warnings instead of using a flag Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Adding parameter strict_param_loading for optionally throwing an exception if parameter overrides are missing Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Using default false declaration instead of declare_or_get in param util Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> --------- Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Update mergify.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * include bug fix for nav2_smac_planner (#5198) Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Revert "Removing underlay workspace from Main" (#5206) * Revert "Removing underlay workspace from Main (#5200)" This reverts commit 1278df7. * Update underlay.repos Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Option to Reduce Lethal to High-Cost Navigable To Get Out of Keepout Zones if Wandered In (#5187) * Adding toggle option of keepout zone Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Default off Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Join conditions Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * spell check Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * copilot suggestions Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update keepout_filter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Prototype solving #5192 Issue 2: Reeds-Shepp reduce small reverse expansions (#5207) * prototype solving 5192 issue 2 Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Removing unnecessary variable Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Revert recent smac changes causing regressions (#5221) * Revert "Prototype solving #5192 Issue 2: Reeds-Shepp reduce small reverse expansions (#5207)" This reverts commit c32873d. * Revert "include bug fix for nav2_smac_planner (#5198)" This reverts commit 6a74ba6. * Revert "Feat/smac planner include orientation flexibility (#4127)" This reverts commit f5543c3. * Disable costmap filter zones from tb3 bringup (only Tb4 enabled) (#5223) * Update tb3_loopback_simulation_launch.py Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update tb3_simulation_launch.py Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Revert "Fix Ci from key signing (#5220)" (#5237) * Revert "Fix Ci from key signing (#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update Cache Version Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> --------- Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Updating readme table for kilted release (#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Updating table lint Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Add min_distance_to_obstacle parameter to RPP (#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * typo Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Route server corner smoothing (#5226) * added edge length method Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Added corner arc class Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * replaced double vectors with Coordinates, added methods to return start and end coordinates Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using Coordinates, fixed direction of tangents Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added corner arc in header, added logger in protected variable Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * first pass of corner smoothing algorithm Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * reassigning next edge to have a different start, if a corner occurs before it Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using unique pointer instead of raw pointers for new edges and nodes Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smoothing parameter Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * made angle of interpolation a parameter Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * const for return methods, added flag for smoothing corners Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * moved getEdgeLength() into the Directional Edge struct Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using float instead of double Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * smoothing radius is float, couple methods moved to protected Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed signed_angle_ as a member variable Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed unnecessary member variables Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed angle of interpolation and inferring it from path density and radius instead Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * consolidated corner arc into one header function Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * readded newline Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * changed corner arc to corner smoothing Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * replaced the use of edges with coordinates to generate smoothing arc, removed storage of nodes and edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * fixing cpplint Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting for headers Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * cpplinting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fixed divide by zeros and accessing empty route.edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * uncrustify linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * cpp linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * path converter linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * changed all doubles to floats Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added check for edges that are colinear to avoid divide by 0, fixed final edge interpolation Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * added doxygen for corner arc class Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added warning message if corner can't be smoothed Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smooth_corners to the nav2 params file Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smoothing flag and radius parameter to README.md' Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * typo in README Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added testing for corner smoothing Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Conserve curvature with LIMIT action (#5255) * Conserve curvature with LIMIT action Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix format Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix test Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Parametrizing obstacle layer tf filter tolerance (#5261) Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Add namespace support for rviz costmap cost tool (#5268) Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com> * Fix/smac planner orientation goals (#5235) * cherry pick Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * cherry pick 6a74ba6 Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * cherrpy pick Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * include x11 forwarding Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * kind of working version Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * cleanup Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * formatting Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * minor format change Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * change naming Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * minor changes Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * working with new changes Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Revert "Fix Ci from key signing (#5220)" (#5237) * Revert "Fix Ci from key signing (#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update Cache Version Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> --------- Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Revert back Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * enable_groot_monitoring_ false (#5246) Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Updating readme table for kilted release (#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Updating table lint Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Add min_distance_to_obstacle parameter to RPP (#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * typo Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Change max_cost default to 254 (#5256) Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * linter Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * remove const Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * pass const pointer by value Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * pass const pointer by value Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * remove unused param Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> --------- Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> * Increase cache Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fixes for humble main compatibility Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Revert "Removing action server timeout duration after fixes to ROS 2, Reverts 3787 (#5183)" This reverts commit c9438b4. * fixing CI build Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * revert Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * done Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Jakubach <jakubach@gmail.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> Signed-off-by: brayanpa <brayanspallares@gmail.com> Signed-off-by: Brayan Pallares <brayanspallares@gmail.com> Signed-off-by: Jad haj mustafa <jhajmustafa@lely.com> Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl> Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com> Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Co-authored-by: Alberto Tudela <ajtudela@gmail.com> Co-authored-by: Brayan Pallares <brayanspallares@gmail.com> Co-authored-by: Jad Haj Mustafa <jado-91@hotmail.com> Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl> Co-authored-by: Raman <52356167+RamanRobotics@users.noreply.github.com> Co-authored-by: RamanaBotta <ramanab@bosonmotors.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Co-authored-by: Marco Bassa <101661130+MarcoMatteoBassa@users.noreply.github.com> Co-authored-by: Stevedan Ogochukwu Omodolor <61468301+stevedanomodolor@users.noreply.github.com> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: alexanderjyuen <103065090+alexanderjyuen@users.noreply.github.com> Co-authored-by: mini-1235 <mauricepurnawan@gmail.com>
SakshayMahna
pushed a commit
to SakshayMahna/navigation2
that referenced
this pull request
Jul 6, 2025
* added edge length method Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Added corner arc class Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * replaced double vectors with Coordinates, added methods to return start and end coordinates Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using Coordinates, fixed direction of tangents Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added corner arc in header, added logger in protected variable Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * first pass of corner smoothing algorithm Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * reassigning next edge to have a different start, if a corner occurs before it Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using unique pointer instead of raw pointers for new edges and nodes Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smoothing parameter Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * made angle of interpolation a parameter Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * const for return methods, added flag for smoothing corners Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * moved getEdgeLength() into the Directional Edge struct Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using float instead of double Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * smoothing radius is float, couple methods moved to protected Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed signed_angle_ as a member variable Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed unnecessary member variables Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed angle of interpolation and inferring it from path density and radius instead Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * consolidated corner arc into one header function Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * readded newline Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * changed corner arc to corner smoothing Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * replaced the use of edges with coordinates to generate smoothing arc, removed storage of nodes and edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * fixing cpplint Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting for headers Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * cpplinting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fixed divide by zeros and accessing empty route.edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * uncrustify linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * cpp linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * path converter linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * changed all doubles to floats Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added check for edges that are colinear to avoid divide by 0, fixed final edge interpolation Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * added doxygen for corner arc class Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added warning message if corner can't be smoothed Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smooth_corners to the nav2 params file Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smoothing flag and radius parameter to README.md' Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * typo in README Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added testing for corner smoothing Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Sushant-Chavan
added a commit
to Sushant-Chavan/navigation2
that referenced
this pull request
Aug 5, 2025
* Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237) * Revert "Fix Ci from key signing (ros-navigation#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update Cache Version Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> --------- Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * enable_groot_monitoring_ false (ros-navigation#5246) Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * Updating readme table for kilted release (ros-navigation#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Updating table lint Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Add min_distance_to_obstacle parameter to RPP (ros-navigation#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * typo Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (ros-navigation#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Change max_cost default to 254 (ros-navigation#5256) Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Route server corner smoothing (ros-navigation#5226) * added edge length method Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Added corner arc class Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * replaced double vectors with Coordinates, added methods to return start and end coordinates Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using Coordinates, fixed direction of tangents Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added corner arc in header, added logger in protected variable Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * first pass of corner smoothing algorithm Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * reassigning next edge to have a different start, if a corner occurs before it Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using unique pointer instead of raw pointers for new edges and nodes Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smoothing parameter Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * made angle of interpolation a parameter Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * const for return methods, added flag for smoothing corners Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * moved getEdgeLength() into the Directional Edge struct Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * using float instead of double Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * smoothing radius is float, couple methods moved to protected Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed signed_angle_ as a member variable Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed unnecessary member variables Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * removed angle of interpolation and inferring it from path density and radius instead Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * consolidated corner arc into one header function Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * readded newline Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * changed corner arc to corner smoothing Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * replaced the use of edges with coordinates to generate smoothing arc, removed storage of nodes and edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * fixing cpplint Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting for headers Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * cpplinting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/src/path_converter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fixed divide by zeros and accessing empty route.edges Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * uncrustify linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * cpp linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * path converter linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * changed all doubles to floats Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added check for edges that are colinear to avoid divide by 0, fixed final edge interpolation Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * added doxygen for corner arc class Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added warning message if corner can't be smoothed Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smooth_corners to the nav2 params file Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added smoothing flag and radius parameter to README.md' Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * typo in README Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * added testing for corner smoothing Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_route/include/nav2_route/corner_smoothing.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Conserve curvature with LIMIT action (ros-navigation#5255) * Conserve curvature with LIMIT action Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix format Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix test Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Parametrizing obstacle layer tf filter tolerance (ros-navigation#5261) Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Add namespace support for rviz costmap cost tool (ros-navigation#5268) Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com> * Fix/smac planner orientation goals (ros-navigation#5235) * cherry pick Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * cherry pick 6a74ba6 Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * cherrpy pick Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * include x11 forwarding Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * kind of working version Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * cleanup Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * formatting Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * minor format change Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * change naming Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * minor changes Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * working with new changes Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237) * Revert "Fix Ci from key signing (ros-navigation#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update Cache Version Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> --------- Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Revert back Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * enable_groot_monitoring_ false (ros-navigation#5246) Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Updating readme table for kilted release (ros-navigation#5249) * updating readme table for kilted release Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Updating table lint Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Add min_distance_to_obstacle parameter to RPP (ros-navigation#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * typo Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (ros-navigation#5251) * Update amcl_node.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Working for Kilted, Jazzy Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update amcl_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * Change max_cost default to 254 (ros-navigation#5256) Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * linter Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * remove const Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * pass const pointer by value Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * pass const pointer by value Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> * remove unused param Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> --------- Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> * Fix backport compiler warning (ros-navigation#5277) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Fix ament mypy (ros-navigation#5280) * Configured nav2_loopback_sim to be compliant with mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Configured nav2_simple_commander to be compliant with mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Configured nav2_system_tests to be compliant with mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Publish zero velocitiy in case of goal failure (ros-navigation#5279) Signed-off-by: haider8645 <haider_lodhi@hotmail.com> * Update PULL_REQUEST_TEMPLATE.md Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Use fixed thresholds for Trinary yaml (ros-navigation#5278) Signed-off-by: Adi Vardi <adi.vardi@enway.ai> * Add missing include of algorithm in differential_motion_model.cpp (ros-navigation#5293) Signed-off-by: Silvio Traversaro <silvio@traversaro.it> * Remove unused unistd.h header from route_tool.cpp (ros-navigation#5292) Signed-off-by: Silvio Traversaro <silvio@traversaro.it> * Fix compilation of nav2_smac_planner on Windows (ros-navigation#5291) Signed-off-by: Silvio <silvio.traversaro@iit.it> * Large Nav2 Node, Utils, and Interface Refactor (ros-navigation#5288) * initial unorganized prototype Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * break out files and add doxygen Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding refactor for nav2_ros_common and new ROS interface factories Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fixing CI - not sure how that got through merge conflicts Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Lifecycle publisher a missing test Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * system tests Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * default Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * activating publishers Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * temp disable allow param qos overrides Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * API update for new constructor option Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Supporting Jazzy and abstracting util Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Review round 1 Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding Nav2 Publisher and Subscriber objects to later build upon Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding additional ::SharedPtr for readability Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fix bug Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * fixing Jazzy support Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * missed one last spot Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding migration instructions Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * more context Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding migration context Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * precommit Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * adding missing dep Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Updating system tess Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * more Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding logging for matched events and dropped messages into pub/sub of new nav2_ros_common package. Also adding QoS overrides default ON (ros-navigation#5302) * Adding logging for matched events and dropped messages Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * toggle on Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * apply for smac 2D Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update interface_factories.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Add LaunchConfigAsBool (Fixes ros-navigation#5233) (ros-navigation#5301) * Add LaunchConfigAsBool (Fixes ros-navigation#5233) Signed-off-by: nishalangovender <nishalan.govender@gmail.com> * Fix Linting Signed-off-by: nishalangovender <nishalan.govender@gmail.com> * Fix ament_mypy and pre-commit Signed-off-by: nishalangovender <nishalan.govender@gmail.com> * Added Type Annotations Signed-off-by: Nishalan Govender <nishalan.govender@gmail.com> * mypy ignore Signed-off-by: Nishalan Govender <nishalan.govender@gmail.com> * launch.Substitution Signed-off-by: Nishalan Govender <nishalan.govender@gmail.com> * Update All Bools in nav2_bringup Signed-off-by: Nishalan Govender <nishalan.govender@gmail.com> --------- Signed-off-by: nishalangovender <nishalan.govender@gmail.com> Signed-off-by: Nishalan Govender <nishalan.govender@gmail.com> * Create claude.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update claude.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update claude.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update claude.yml for authorized users Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update claude.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update claude.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding clear costmap around pose service option (ros-navigation#5309) * Adding clear costmap around pose impl Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_msgs/srv/ClearCostmapAroundPose.srv Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding APIs for simple commander Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * linting Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * adding import Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Fix compiler errors in nav2_map_server * Fix compiler errors in nav2_costmap_2d * Add support for enable_lifecycle_services parameter in LifecycleNode (ros-navigation#5307) Expose the enable_communication_interface parameter from rclcpp_lifecycle::LifecycleNode through nav2's LifecycleNode wrapper. This allows users to disable lifecycle communication interfaces when manually managing node lifecycle transitions. The parameter can be set via NodeOptions parameter overrides: ```cpp rclcpp::NodeOptions options; options.parameter_overrides({{"enable_lifecycle_services", false}}); ``` Fixes ros-navigation#5305 Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> --------- Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com> Signed-off-by: Stevedan Omodolor <stevedan.o.omodolor@gmail.com> Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: haider8645 <haider_lodhi@hotmail.com> Signed-off-by: Adi Vardi <adi.vardi@enway.ai> Signed-off-by: Silvio Traversaro <silvio@traversaro.it> Signed-off-by: Silvio <silvio.traversaro@iit.it> Signed-off-by: nishalangovender <nishalan.govender@gmail.com> Signed-off-by: Nishalan Govender <nishalan.govender@gmail.com> Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: alexanderjyuen <103065090+alexanderjyuen@users.noreply.github.com> Co-authored-by: Marco Bassa <101661130+MarcoMatteoBassa@users.noreply.github.com> Co-authored-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Stevedan Ogochukwu Omodolor <61468301+stevedanomodolor@users.noreply.github.com> Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Co-authored-by: Haider <haider_lodhi@hotmail.com> Co-authored-by: Adi Vardi <57910756+adivardi@users.noreply.github.com> Co-authored-by: Silvio Traversaro <silvio@traversaro.it> Co-authored-by: Nishalan Govender <137301877+nishalangovender@users.noreply.github.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
densifyinpath_converter.cppto enable corner smoothingDescription of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
corner_arcclassFor Maintainers: