Fixed crash in bt_service_node when the service is not available in time#5606
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Oct 14, 2025
Conversation
b295702 to
0e63784
Compare
SteveMacenski
approved these changes
Oct 13, 2025
Member
|
@JayHerpin please sign off DCO. I'll also backport this - thanks! |
1aae17f to
f498718
Compare
Contributor
Author
|
Correct me if I am wrong, but I don't believe that system_build check failure is anything to do with my changes? |
Member
|
@JayHerpin pull in main / rebase and it should pass now! |
Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com>
26688ce to
429247f
Compare
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2025
Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com> (cherry picked from commit 48e7e06)
Merged
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2025
Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com> (cherry picked from commit 48e7e06)
Merged
8 tasks
SteveMacenski
pushed a commit
that referenced
this pull request
Oct 14, 2025
SteveMacenski
pushed a commit
that referenced
this pull request
Oct 14, 2025
Jad-ELHAJJ
pushed a commit
to Jad-ELHAJJ/navigation2
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com>
greganderson-vermeer
pushed a commit
to greganderson-vermeer/navigation2-vermeer-features
that referenced
this pull request
Oct 21, 2025
Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com> Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
greganderson-vermeer
added a commit
to greganderson-vermeer/navigation2-vermeer-features
that referenced
this pull request
Oct 21, 2025
Squashed commit of the following: commit bf2e64c Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Tue Oct 21 14:41:42 2025 -0500 Add declaration for use_global_height parameter into add sources function. Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> commit 8453632 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Tue Oct 21 08:28:19 2025 -0500 Adjusted asserts in third test case for consistent results. Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> commit 725f054 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Mon Oct 20 21:04:51 2025 -0500 Add additional case for testing pointcloud with no height field. Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> commit 2bb49aa Merge: b02713a cdccfe1 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Mon Oct 20 18:01:24 2025 -0500 Merge branch 'main' into feat/CustomCollisionPointFields Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> commit b02713a Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Mon Oct 20 17:53:36 2025 -0500 Cleaned up some un-needed parameter changes. commit 21eef62 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Mon Oct 20 17:49:16 2025 -0500 Added test case for using global height parameter. commit cdccfe1 Author: Sushant Chavan <gitecsvc@gmail.com> Date: Mon Oct 20 23:49:25 2025 +0200 Publish `is_active` status from LifecycleManager (ros-navigation#5627) * Publish `is_active` status from LifecycleManager Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> * Update nav2_lifecycle_manager/src/lifecycle_manager.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> commit b35a4b5 Author: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Date: Mon Oct 20 22:04:17 2025 +0100 Use the new declare_or_get_parameter API for nav2_controller. (ros-navigation#5624) * Migrate majority of parameter declarations to use the new parameter API. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Migrate controller_server.cpp to use declare_or_get_parameter API. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> commit 62ebc54 Author: Steve Macenski <stevenmacenski@gmail.com> Date: Thu Oct 16 07:59:10 2025 -0700 Revert "[RPP] Prevent collision check premature termination (ros-navigation#5598)" (ros-navigation#5620) This reverts commit 6bc74e5. commit 01580bd Author: mini-1235 <mauricepurnawan@gmail.com> Date: Thu Oct 16 02:02:29 2025 +0700 Redesign graceful controller dynamic parameters patterns (ros-navigation#5600) Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> commit b91eda5 Author: Abhishekh Reddy <helloarm@pm.me> Date: Tue Oct 14 14:47:14 2025 -0400 Check if the tolerance circle is feasible when validating goals for path planning. (ros-navigation#5593) * Implemented goal tolerance validity check Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Fixed description for getCoords function Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Added a test with lower tolerance for zone validity checking Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated tolerance check function implementation Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated isZoneValid function Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated isZoneValid function Signed-off-by: Abhishekh Reddy <helloarm@pm.me> --------- Signed-off-by: Abhishekh Reddy <helloarm@pm.me> commit 48e7e06 Author: Jay Herpin <159202566+JayHerpin@users.noreply.github.com> Date: Tue Oct 14 12:45:59 2025 -0500 Fixed crash due to incorrect string construction (ros-navigation#5606) Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com> commit 7d37466 Author: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Date: Tue Oct 14 15:50:30 2025 +0100 Use the new parameter API in nav2_constrained_smoother. (ros-navigation#5608) Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> commit 3935038 Author: Steve Macenski <stevenmacenski@gmail.com> Date: Tue Oct 14 07:48:32 2025 -0700 Fixing CI Cache Misalignment causing builds to fail (ros-navigation#5607) * Aligning caches Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * Trigger linting (hopefully) Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * Fix action-ros-lint version format in lint.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> commit 568174c Author: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Date: Tue Oct 14 01:41:25 2025 +0100 Update new_declare_or_get_parameter API for collision_monitor and map_server (ros-navigation#5588) * Use the new_declare_or_get_parameter API for nav2_collision_monitor. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Removed redundant set_parameter calls when preceeded by declare_parameter. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Use declare_or_get_parameter without a default value. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Simplified definitions that required to determine parameter type from template. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Removed self-definition of node_utils.hpp. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Address PR feedback: Remove unnecessary linebreaks and improve param docstring. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> commit 6bc74e5 Author: Érico Meger <86668447+EricoMeger@users.noreply.github.com> Date: Mon Oct 13 19:17:23 2025 -0300 [RPP] Prevent collision check premature termination (ros-navigation#5598) * prevent collision check premature termination Signed-off-by: EricoMeger <ericomeger9@gmail.com> * improve comment wording Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Érico Meger <86668447+EricoMeger@users.noreply.github.com> * fix linting error Signed-off-by: EricoMeger <ericomeger9@gmail.com> --------- Signed-off-by: EricoMeger <ericomeger9@gmail.com> Signed-off-by: Érico Meger <86668447+EricoMeger@users.noreply.github.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> commit 4d28c13 Author: silanus <berkantali23@outlook.com> Date: Fri Oct 10 20:42:45 2025 +0300 Path distance feature (ros-navigation#5387) * geometry utils Signed-off-by: silanus23 <berkantali23@outlook.com> * fixed geometry utils adding 2d Signed-off-by: silanus23 <berkantali23@outlook.com> * created path_utils Signed-off-by: silanus23 <berkantali23@outlook.com> * added tests Signed-off-by: silanus23 <berkantali23@outlook.com> * minor changes in tests Signed-off-by: silanus23 <berkantali23@outlook.com> * lint issue Signed-off-by: silanus23 <berkantali23@outlook.com> * fixed reviews Signed-off-by: silanus23 <berkantali23@outlook.com> * doxygen fix Signed-off-by: silanus23 <berkantali23@outlook.com> * Last fixes. Signed-off-by: silanus23 <berkantali23@outlook.com> * Last fixes cpp. Signed-off-by: silanus23 <berkantali23@outlook.com> * Update nav2_util/include/nav2_util/path_utils.hpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: silanus <berkantali23@outlook.com> Signed-off-by: silanus23 <berkantali23@outlook.com> * Update nav2_util/include/nav2_util/path_utils.hpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: silanus <berkantali23@outlook.com> Signed-off-by: silanus23 <berkantali23@outlook.com> * Update nav2_util/test/test_path_utils.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: silanus <berkantali23@outlook.com> Signed-off-by: silanus23 <berkantali23@outlook.com> * Frame check fix Signed-off-by: silanus23 <berkantali23@outlook.com> * msg Signed-off-by: silanus23 <berkantali23@outlook.com> * controller server publisher Signed-off-by: silanus23 <berkantali23@outlook.com> * controller server publisher fix Signed-off-by: silanus23 <berkantali23@outlook.com> * cross_product Signed-off-by: silanus23 <berkantali23@outlook.com> * handled last_fixes Signed-off-by: silanus23 <berkantali23@outlook.com> * tracking error added to follow path side from side added to tracking error Signed-off-by: silanus23 <berkantali23@outlook.com> * arranged msgs Signed-off-by: silanus23 <berkantali23@outlook.com> * linting of msgs Signed-off-by: silanus23 <berkantali23@outlook.com> * last cpplint Signed-off-by: silanus23 <berkantali23@outlook.com> * frame check for distance_to_goal Signed-off-by: silanus23 <berkantali23@outlook.com> * fixes for follow_path Signed-off-by: silanus23 <berkantali23@outlook.com> * controller linting Signed-off-by: silanus23 <berkantali23@outlook.com> * changing tracking_error to tracking_error_feedback Signed-off-by: silanus23 <berkantali23@outlook.com> * adding remaining_path_length in tracking_error_feedback Signed-off-by: silanus23 <berkantali23@outlook.com> * Last fix Signed-off-by: silanus23 <berkantali23@outlook.com> * start_index_ Signed-off-by: silanus23 <berkantali23@outlook.com> * Name changes and optimizations in controller_server and nav2_util Signed-off-by: silanus23 <berkantali23@outlook.com> * Changing name to tracking_feedback Signed-off-by: silanus23 <berkantali23@outlook.com> * Documentation changes Signed-off-by: silanus23 <berkantali23@outlook.com> * Last lint Signed-off-by: silanus23 <berkantali23@outlook.com> * Update nav2_util/include/nav2_util/path_utils.hpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: silanus <berkantali23@outlook.com> * Update nav2_controller/src/controller_server.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_controller/src/controller_server.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_controller/src/controller_server.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_controller/src/controller_server.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_controller/src/controller_server.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Last updates Signed-off-by: silanus23 <berkantali23@outlook.com> * update example_follow_path.py Signed-off-by: silanus23 <berkantali23@outlook.com> * update example_follow_path.py lint Signed-off-by: silanus23 <berkantali23@outlook.com> * Update nav2_controller/src/controller_server.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_controller/src/controller_server.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_util/src/path_utils.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * ordering problem Signed-off-by: silanus23 <berkantali23@outlook.com> * added deactivate to tracking_feedback_pub_ Signed-off-by: silanus23 <berkantali23@outlook.com> * typo Signed-off-by: silanus23 <berkantali23@outlook.com> * end_pose transform Signed-off-by: silanus23 <berkantali23@outlook.com> * creating the member variable end_pose_global_ and deleting nav_2d_msgs Signed-off-by: silanus23 <berkantali23@outlook.com> * deleting unnecessary transform Signed-off-by: silanus23 <berkantali23@outlook.com> * typo in controller Signed-off-by: silanus23 <berkantali23@outlook.com> * readding remaining path Signed-off-by: silanus23 <berkantali23@outlook.com> * placement of transformation Signed-off-by: silanus23 <berkantali23@outlook.com> * unnecessary comments Signed-off-by: silanus23 <berkantali23@outlook.com> * tests added Signed-off-by: silanus23 <berkantali23@outlook.com> * Increased test coverage Signed-off-by: silanus23 <berkantali23@outlook.com> * Every part of the result is covered Signed-off-by: silanus23 <berkantali23@outlook.com> * Increasing out of bounds index Signed-off-by: silanus23 <berkantali23@outlook.com> * lint Signed-off-by: silanus23 <berkantali23@outlook.com> * add missing line to cmake Signed-off-by: silanus23 <berkantali23@outlook.com> * unnecessary test Signed-off-by: silanus23 <berkantali23@outlook.com> * unexptected styling and last functional change Signed-off-by: silanus23 <berkantali23@outlook.com> * simplifying the tranformation of end_pose Signed-off-by: silanus23 <berkantali23@outlook.com> * doxygen fix Signed-off-by: silanus23 <berkantali23@outlook.com> * doxygen fix Signed-off-by: silanus23 <berkantali23@outlook.com> * doxygen fix Signed-off-by: silanus23 <berkantali23@outlook.com> * doxygen fix Signed-off-by: silanus23 <berkantali23@outlook.com> * Update nav2_controller/src/controller_server.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: silanus23 <berkantali23@outlook.com> Signed-off-by: silanus <berkantali23@outlook.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> commit 04a3e22 Author: Steve Macenski <stevenmacenski@gmail.com> Date: Fri Oct 10 10:09:08 2025 -0700 Improve error message for missing robot footprint (ros-navigation#5597) Updated error message for footprint collision checking. Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> commit ce6b439 Author: Alberto Tudela <ajtudela@gmail.com> Date: Fri Oct 10 00:12:57 2025 +0200 Following (ros-navigation#5565) * Following server Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * feat: migrate to nav2_msgs for FollowObject action and remove opennav_following_msgs Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix mypy test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Move FollowObject and FollowObjectCancel action nodes from bt package Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update package and circle Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * feat: add FollowObject action support in robot navigator and fix mypy Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix mypy issues Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * feat: add follow_object action to bt_navigator parameters Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update key and package Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix precommit Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix mypy? Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix mypy, round two Signed-off-by: Alberto Tudela <ajtudela@gmail.com> --------- Signed-off-by: Alberto Tudela <ajtudela@gmail.com> commit ed0d59f Author: Sakshay Mahna <sakshum19@gmail.com> Date: Thu Oct 9 03:39:30 2025 +0530 [Graceful Controller] Fix Incorrect Motion Target Heading output by controller (ros-navigation#5530) * Fix graceful controller lookahead bug Signed-off-by: Sakshay Mahna <sakshum19@gmail.com> * Shorten logic with goal_pose Signed-off-by: Sakshay Mahna <sakshum19@gmail.com> * Add Linear Interpolation Fix Signed-off-by: Sakshay Mahna <sakshum19@gmail.com> * Update const double and comments Signed-off-by: Sakshay Mahna <sakshum19@gmail.com> --------- Signed-off-by: Sakshay Mahna <sakshum19@gmail.com> commit 14660b4 Author: Vince Reda <60265874+redvinaa@users.noreply.github.com> Date: Wed Oct 8 17:14:57 2025 +0000 Fail PersistentSequence if input port is not set (ros-navigation#5589) * Fail if getInput fails Signed-off-by: redvinaa <redvinaa@gmail.com> * Add test with no input Signed-off-by: redvinaa <redvinaa@gmail.com> * Update error string Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Vince Reda <60265874+redvinaa@users.noreply.github.com> * Fix quotation marks Signed-off-by: redvinaa <redvinaa@gmail.com> --------- Signed-off-by: redvinaa <redvinaa@gmail.com> Signed-off-by: Vince Reda <60265874+redvinaa@users.noreply.github.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> commit aa2cdc5 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Wed Oct 8 10:43:14 2025 -0500 Apply suggestions from code review Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> commit 5636fc1 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Tue Oct 7 15:37:13 2025 -0500 Implementing Steve's suggestion for performance and code simplicity. Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> commit b2fbb06 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Tue Oct 7 12:59:46 2025 -0500 Implemented additional changes for iterator feedback in PR. Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> commit 1cdbc05 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Tue Oct 7 12:12:31 2025 -0500 Add return false for error state. Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> commit 869b5a9 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Tue Oct 7 12:10:03 2025 -0500 Address PR formatting feedback. Remove run time error and replaced with log error. Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> commit 11f04c7 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Tue Oct 7 10:55:18 2025 -0500 Added some pointcloud field checking based on run time error found when running tests. Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> commit ca49b05 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Tue Oct 7 08:22:05 2025 -0500 Ran ament lint/style tools, cleaned up. Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> commit 7e6ccc9 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Tue Oct 7 08:08:01 2025 -0500 Add use_global_height_ parameter to allow configuration of height checking by end users. Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> commit 0c20df2 Author: DylanDeCoeyer-Quimesis <102609575+DylanDeCoeyer-Quimesis@users.noreply.github.com> Date: Mon Oct 6 22:29:17 2025 +0200 nav2_smac_planner: make A* return closest path found in case of timeout (ros-navigation#5578) Until now, a path computation timeout would systematically lead to a nav2_core::PlannerTimedOut error, even though a path was found within the tolerance. This commit makes the A* return the best path found if it's within the tolerance. Signed-off-by: Dylan De Coeyer <dylan.decoeyer@quimesis.be> commit f78bac5 Author: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Date: Mon Oct 6 20:16:30 2025 +0100 Use the new declare_or_get_parameter API for nav2_behaviors. (ros-navigation#5583) Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> commit 269d480 Author: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Date: Mon Oct 6 20:13:52 2025 +0100 Improve type annotations for ament_mypy (ros-navigation#5575) * Enable tools directory to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Enable nav2_system_tests to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Enable nav2_docking to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Enable nav2_simple_commander to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Enable nav2_loopback_sim to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Removed unused ignores for packages for mypy compliance. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added nav2_msgs path fixes to mypy compliance. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> commit 5860a27 Author: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Date: Mon Oct 6 12:41:04 2025 -0500 Create iterator for custom height field in pointcloud. Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
greganderson-vermeer
pushed a commit
to greganderson-vermeer/navigation2-vermeer-features
that referenced
this pull request
Oct 22, 2025
Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com> Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
RBT22
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
Oct 28, 2025
ros-navigation#5613) (cherry picked from commit 48e7e06) Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com> Co-authored-by: Jay Herpin <159202566+JayHerpin@users.noreply.github.com>
RBT22
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
Dec 1, 2025
ros-navigation#5613) (cherry picked from commit 48e7e06) Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com> Co-authored-by: Jay Herpin <159202566+JayHerpin@users.noreply.github.com>
redvinaa
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
Dec 3, 2025
* Jazzy Sync 7: May 29 2025 (ros-navigation#5211) * Dynamic param patterns (ros-navigation#4971) * redesign dynamic param patterns Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * change cache version Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * check that parameter of type double are >=0.0 Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> --------- Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * [nav2_behavior_tree] Add force_use_current_pose to ComputePathToPoseAction (ros-navigation#4925) * Add force_use_current_pose Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * xml update Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * rename to use_start Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * lint Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * descriptions Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * simplify logic Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * [CostmapTopicCollisionChecker] Alternative constructor with footprint string (ros-navigation#4926) * [CostmapTopicCollisionChecker] Alternative constructor with footprint Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * raw pointer Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * suggestions from review Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * Merged Fix navfn_planner from humble PR ros-navigation#5087 (ros-navigation#5092) * merged changes from humble for goal.header fix * reverted back, error in merge * ported goal.header fix in navfn_planner.cpp from humble * reverted to navfn_planner.cpp to origin/main * merged navfn_planner.cpp from humble * fixed the merge * Update map_io library to use Eigen method for faster map loading (ros-navigation#5071) * Update map_io library to use opencv method for faster map loading Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit config changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Use Eigen approach instead of OpenCV Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update include header include order Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Remove intermediary alpha matrix Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Add comments for the code understanding Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Fix else braces rule issue Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Create and use alpha_matrix when applying mask Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Take flip part out of if-else Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> --------- Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Precompute yaw trigonometric values in smac planner (ros-navigation#5109) Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * removing the start navigation message in the paused state from rviz buttons (ros-navigation#5137) Signed-off-by: Pradheep <padhupradheep@gmail.com> * Show error if inflation radius is smaller than circumscribed radius (ros-navigation#5148) * Warn if inflation radius is smaller than circumscribed radius Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Update nav2_mppi_controller/src/critics/cost_critic.cpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Tony Najjar <t03578624@gmail.com> * Update nav2_smac_planner/include/nav2_smac_planner/utils.hpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Tony Najjar <t03578624@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Tony Najjar <t03578624@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Prevent MPPI controller from resetting speed limits upon goal execution. (ros-navigation#5165) Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Fixing docking server when already docked at the requeste ddock (ros-navigation#5171) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding parameter util to node utils (ros-navigation#5154) * Adding declare_or_get_param util to node utils Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Adding test for declare_or_get_param util Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Adding declare_or_get_parameter function by type, using explicit variable names, disabling param warnings by default Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Update nav2_util/test/test_node_utils.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Fixing codecove test Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Catching possible exception in declare_or_get_by_type Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Templating return type of declare parameter by value Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> --------- Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * added config for laserscan in lb-sim (ros-navigation#5174) * added config for laserscan in lb-sim Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * fixing ament_flake8 errors Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * review: use_inf is default:true and added parameters on readme ros-navigation#4992 Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * refactor: meaningfull value for scan_angle_increment Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> --------- Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> Co-authored-by: RamanaBotta <ramanab@bosonmotors.com> * Publish planned footprints after smoothing (ros-navigation#5155) * Publish planned footprints after smoothing Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Revert "Publish planned footprints after smoothing" This reverts commit c9b349a. * Add smoothed footprints publishing Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix formatting Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Fix indentation for publisher creation in SmacPlannerHybrid and SmacPlannerLattice Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * address PR comments Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fixes Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix build error Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fixing deprecation warning (ros-navigation#5182) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding missing dep to loopback sim (ros-navigation#5204) * Adding missing dep Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * typo Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * updating fix Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding parameter warn_when_defaulting_parameters to control default parameter warnings (ros-navigation#5189) * Adding a parameter warn_when_defaulting_parameters to control default parameter warnings instead of using a flag Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Adding parameter strict_param_loading for optionally throwing an exception if parameter overrides are missing Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Using default false declaration instead of declare_or_get in param util Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> --------- Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * bumping to 1.3.7 for release Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Vignesh T <vignesh.t@kabam.ai> Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Pradheep <padhupradheep@gmail.com> Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Tony Najjar <t03578624@gmail.com> Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> Co-authored-by: Vignesh T <vignesh.t@kabam.ai> Co-authored-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Pradheep Krishna <padhupradheep@gmail.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Co-authored-by: Marco Bassa <101661130+MarcoMatteoBassa@users.noreply.github.com> Co-authored-by: Raman <52356167+RamanRobotics@users.noreply.github.com> Co-authored-by: RamanaBotta <ramanab@bosonmotors.com> * Fixing Jazzy CI via new ROS 2 keys Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Revert "Fix Ci from key signing (ros-navigation#5220)" (backport ros-navigation#5237) (ros-navigation#5239) * Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237) * Revert "Fix Ci from key signing (ros-navigation#5220)" This reverts the changes to the Dockerfile done in 1345c22. Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> * Update Cache Version Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> --------- Signed-off-by: Nils-Christian Iseke <nilsmailiseke@gmail.com> (cherry picked from commit 7f561b0) # Conflicts: # .circleci/config.yml * Update config.yml Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Backport bidirectional settings ros-navigation#4954 (ros-navigation#5260) Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp> * Add namespace support for rviz costmap cost tool (ros-navigation#5271) Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com> * Use fixed thresholds for Trinary yaml (ros-navigation#5278) (ros-navigation#5286) (cherry picked from commit 829e683) Signed-off-by: Adi Vardi <adi.vardi@enway.ai> Co-authored-by: Adi Vardi <57910756+adivardi@users.noreply.github.com> * Clear costmap around pose jazzy (backport ros-navigation#5309) (ros-navigation#5318) * Adding clear costmap around pose service option (ros-navigation#5309) (cherry picked from commit c0bf67e Signed-off-by: dw25628 <dwoodwell@vermeer.com> * Linting Signed-off-by: dw25628 <dwoodwell@vermeer.com> * Removed __init__.py that came in with cherry pick Signed-off-by: dw25628 <dwoodwell@vermeer.com> --------- Signed-off-by: dw25628 <dwoodwell@vermeer.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Backport "Option to Reduce Lethal to High-Cost Navigable To Get Out of Keepout Zones if Wandered In" (ros-navigation#5378) * Option to Reduce Lethal to High-Cost Navigable To Get Out of Keepout Zones if Wandered In (ros-navigation#5187) * Adding toggle option of keepout zone Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Default off Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Join conditions Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * spell check Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * copilot suggestions Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update keepout_filter.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Revert bringup params changes Signed-off-by: Maurice <mauricepurnawan@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Adding minimum range to PC2 in collision monitor (backport ros-navigation#5392) (ros-navigation#5393) * Adding minimum range to PC2 in collision monitor (ros-navigation#5392) Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> (cherry picked from commit 40a0451) # Conflicts: # nav2_collision_monitor/src/pointcloud.cpp * Update pointcloud.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update pointcloud.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update sources_test.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Construct TF listeners passing nodes, spinning on separate thread (backport ros-navigation#5406) (ros-navigation#5431) * Construct TF listeners passing nodes, spinning on separate thread (ros-navigation#5406) * Construct TF listeners passing nodes, spinning on separate thread Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com> * (tentative) pin down of the impacting change Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com> --------- Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com> (cherry picked from commit 1468484) # Conflicts: # nav2_route/src/route_server.cpp * Delete nav2_route/src/route_server.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Patrick Roncagliolo <ronca.pat@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Fix lifecycle manager deadlock during shutdown (ros-navigation#5448) Signed-off-by: Jacob Visser <jacob.visser@cboost.nl> * fix 5456 (ros-navigation#5458) Signed-off-by: David G <david.randommail1@gmail.com> * backport the fix for setting binary_state as the default (ros-navigation#5459) Signed-off-by: olaghattas <olaghattas@hotmail.com> * Sync Jazzy Aug 19, 2025 1.4.1 (ros-navigation#5469) * Conserve curvature with LIMIT action (ros-navigation#5255) * Conserve curvature with LIMIT action Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix format Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix test Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Adding epsilon for voxel_layer precision loss (ros-navigation#5314) * Adding epsilon for voxel_layer precision loss Signed-off-by: bhx <1273698633@qq.com> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: bhx <1273698633@qq.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * fix: correct ThroughActionResult type alias in would_a_planner_recovery_help_condition (ros-navigation#5326) The ThroughActionResult type alias was incorrectly referencing Action::Result instead of ThroughAction::Result, causing the condition to not work properly for ComputePathThroughPoses actions. Fixes ros-navigation#5324 Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * Adding slow down at target heading to RPP Controller (ros-navigation#5361) * Adding slow down at target heading to RPP Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * Update test_regulated_pp.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Eexception rethrow in dockRobot method (ros-navigation#5364) Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Add global min obstacle height in voxel layer (ros-navigation#5389) * Add min obstacle height in voxel layer Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix linting Signed-off-by: Maurice <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> * [DEX] Enforce 3 digits precision (ros-navigation#5398) Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * [static_layer] limit comparison precision (ros-navigation#5405) * [DEX] limit comparison precision Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * EPSILON 1e-5 Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * Smooth path even if goal pose is so much near to the robot (ros-navigation#5423) * Smooth path even if goal pose is so much near to the robot Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> * Apply suggestions Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> * Remove unnecessary diff Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> --------- Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> * Fix KeepoutFilter on the ARM architecture (ros-navigation#5436) Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> * Fix missing dependency (ros-navigation#5460) * bump to 1.3.8 for Jazzy release Aug 19, 2025 Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * load balance CI Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: bhx <1273698633@qq.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: hutao <108395177+coderbaibai@users.noreply.github.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Alberto Tudela <ajtudela@gmail.com> Co-authored-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Cihat Kurtuluş Altıparmak <cihataltiparmak1@gmail.com> Co-authored-by: Sushant Chavan <gitecsvc@gmail.com> Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl> * fix: Move SmootherParams declaration outside smooth_path conditional (ros-navigation#5473) (ros-navigation#5474) Fixes crash when dynamically changing smooth_path parameter from false to true. The issue occurred because SmootherParams were only declared when smooth_path was initially true, causing ParameterModifiedInCallbackException when trying to declare parameters within the dynamic parameter callback. Now SmootherParams are always declared, making them available for dynamic reconfiguration regardless of the initial smooth_path value. Fixes ros-navigation#5472 (cherry picked from commit 69a60df) Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * Replace last pose if only orientation differs in Navfn (ros-navigation#5490) (ros-navigation#5492) (cherry picked from commit ff80727) Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: mini-1235 <mauricepurnawan@gmail.com> * Manual Backport Route Server to Jazzy (ros-navigation#5517) * Manual backport of Route Server to Jazzy Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * linting Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Fix backport error Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * lint Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding in Nav2 BT + Launch Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Jazzy Sync Sept 19, 2025 1.3.9 (ros-navigation#5540) * Fix dynamic param SmacPlannerLattice (ros-navigation#5478) * Fix SmacPlannerLattice dynamic parameter early exit Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * remove comment Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Fix duplicate poses with computePlanThroughPoses (ros-navigation#5488) * fix-duplicate-poses Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Update nav2_planner/src/planner_server.cpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Fix seg fault (ros-navigation#5501) * Fix segmentation fault Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix linting Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Add a service for enabling/disabling the collision monitor (ros-navigation#5493) * Added std_srvs package to dependencies Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Declared service and callback for enabling/disabling collision monitor Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Declared a variable to store collision monitor enable/disable state Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Added initialization for collision monitor enable/disable service Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Implemented service callback for collision monitor enable/disable service Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Removed std_srvs package dependency Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Added Toggle interface Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Replaced Trigger interface with the new Toggle interface Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Added default initialization for enabled flag Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Fixed toggle service name Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated toggle logic for collision monitor Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Added a new line at the end of file Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Update nav2_collision_monitor/src/collision_monitor_node.cpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Update nav2_collision_monitor/src/collision_monitor_node.cpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Added enabled check for logging Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Added a unit test for toggle service Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Made the getter const and added a comment Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Replaced rclcpp::spin_some Signed-off-by: Abhishekh Reddy <helloarm@pm.me> --------- Signed-off-by: Abhishekh Reddy <helloarm@pm.me> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * bump Jazzy to 1.3.9 for release Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * Change service type for collision monitor Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Fix backport error Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * update Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me> Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: Abhishekh Reddy <helloarm@pm.me> * Update package version from 1.1.0 to 1.3.9 Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Add support for dynamically changing keepout zone (ros-navigation#5429) (ros-navigation#5542) * Add support for dynamically changing keepout zone * Linting * Revert binary and speed changes --------- (cherry picked from commit e690ef0) Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: mini-1235 <mauricepurnawan@gmail.com> * Fix bad_weak_ptr in createBond() by using shared_ptr (backport ros-navigation#5341) (ros-navigation#5563) Signed-off-by: ymd-stella <world.applepie@gmail.com> * Fixed crash due to incorrect string construction (ros-navigation#5606) (ros-navigation#5613) (cherry picked from commit 48e7e06) Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com> Co-authored-by: Jay Herpin <159202566+JayHerpin@users.noreply.github.com> * Add dependency on nav2_route in package.xml (ros-navigation#5639) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Revert ros-navigation#4971 in Jazzy (ros-navigation#5640) * Revert ros-navigation#4971 in Jazzy Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Bumping to 1.3.10 for urgent jazzy regression fixes (ros-navigation#5650) Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * Backporting custom height point field into Jazzy. (ros-navigation#5646) * Summary commit of all changes for adding custom pointcloud field height. (ros-navigation#5586) Doing this to clear out unsigned commits from history. Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> * Corrected parameter declaration methods that aren't part of Jazzy. Fixed parameter typo from some manual merging in pointcloud.cpp Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> --------- Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> --------- Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Vignesh T <vignesh.t@kabam.ai> Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Pradheep <padhupradheep@gmail.com> Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Tony Najjar <t03578624@gmail.com> Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp> Signed-off-by: Maurice-1235 <mauricepurnawan@gmail.com> Signed-off-by: Adi Vardi <adi.vardi@enway.ai> Signed-off-by: dw25628 <dwoodwell@vermeer.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> Signed-off-by: Jacob Visser <jacob.visser@cboost.nl> Signed-off-by: David G <david.randommail1@gmail.com> Signed-off-by: olaghattas <olaghattas@hotmail.com> Signed-off-by: bhx <1273698633@qq.com> Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me> Signed-off-by: ymd-stella <world.applepie@gmail.com> Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com> Signed-off-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> Co-authored-by: Vignesh T <vignesh.t@kabam.ai> Co-authored-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Pradheep Krishna <padhupradheep@gmail.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Co-authored-by: Marco Bassa <101661130+MarcoMatteoBassa@users.noreply.github.com> Co-authored-by: Raman <52356167+RamanRobotics@users.noreply.github.com> Co-authored-by: RamanaBotta <ramanab@bosonmotors.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp> Co-authored-by: Adi Vardi <57910756+adivardi@users.noreply.github.com> Co-authored-by: dw25628 <108828484+dw25628@users.noreply.github.com> Co-authored-by: Patrick Roncagliolo <ronca.pat@gmail.com> Co-authored-by: cboostjvisser <89262699+cboostjvisser@users.noreply.github.com> Co-authored-by: DavidG-Develop <147402604+DavidG-Develop@users.noreply.github.com> Co-authored-by: olaghattas <98136555+olaghattas@users.noreply.github.com> Co-authored-by: hutao <108395177+coderbaibai@users.noreply.github.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Alberto Tudela <ajtudela@gmail.com> Co-authored-by: Cihat Kurtuluş Altıparmak <cihataltiparmak1@gmail.com> Co-authored-by: Sushant Chavan <gitecsvc@gmail.com> Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl> Co-authored-by: Abhishekh Reddy <helloarm@pm.me> Co-authored-by: ymd-stella <7959916+ymd-stella@users.noreply.github.com> Co-authored-by: Jay Herpin <159202566+JayHerpin@users.noreply.github.com> Co-authored-by: Greg Anderson <107634795+greganderson-vermeer@users.noreply.github.com>
decwest
pushed a commit
to decwest/navigation2
that referenced
this pull request
Dec 10, 2025
Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com>
decwest
pushed a commit
to decwest/navigation2
that referenced
this pull request
Dec 11, 2025
Signed-off-by: Jay Herpin <jherpin@metalsharkboats.com> Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of how this change was tested
For Maintainers:
backport-*.