docs: Update collision monitor tutorial for holonomic robot#871
Merged
SteveMacenski merged 2 commits intoros-navigation:masterfrom Feb 17, 2026
Merged
docs: Update collision monitor tutorial for holonomic robot#871SteveMacenski merged 2 commits intoros-navigation:masterfrom
SteveMacenski merged 2 commits intoros-navigation:masterfrom
Conversation
mini-1235
requested changes
Feb 12, 2026
Collaborator
mini-1235
left a comment
There was a problem hiding this comment.
Please also fix the precommit and sign with DCO here
Contributor
Author
Fixed linting issues and signed off all commits. Ready for review. |
Member
|
This includes some commits that already exist on main, please fix that so we can review and merge only your changes :-) |
Update collision monitor tutorial for holonomic robot Signed-off-by: Jaerak Son <sjr9017@naver.com>
Contributor
Author
|
@SteveMacenski |
|
|
||
| .. code-block:: yaml | ||
|
|
||
| collision_monitor: |
Member
There was a problem hiding this comment.
Where did this come from and does this match the image?
Contributor
Author
There was a problem hiding this comment.
I created this example following the pattern of the non-holonomic robot example above. regarding the parameters, the previous commit had some discrepancies with the image. I have now updated the angle ranges to match the image exactly.
…tation - Updated `direction_start_angle` and `direction_end_angle` parameters in YAML to match the reference diagram. - Refined `using_collision_monitor.rst` based on review feedback (removed redundant non-negative description). Signed-off-by: Jaerak Son <sjr9017@naver.com>
SteveMacenski
approved these changes
Feb 17, 2026
pepisg
pushed a commit
to pepisg/navigation.ros.org
that referenced
this pull request
Feb 20, 2026
…gation#871) * Update velocity polygon linear_min/max Description Update collision monitor tutorial for holonomic robot Signed-off-by: Jaerak Son <sjr9017@naver.com> * [collision_monitor] Update velocity polygon angles and refine documentation - Updated `direction_start_angle` and `direction_end_angle` parameters in YAML to match the reference diagram. - Refined `using_collision_monitor.rst` based on review feedback (removed redundant non-negative description). Signed-off-by: Jaerak Son <sjr9017@naver.com> --------- Signed-off-by: Jaerak Son <sjr9017@naver.com> Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co>
SteveMacenski
added a commit
that referenced
this pull request
Feb 21, 2026
* remove duplicated max_obstacle_height on voxel_layer in costmap2d config example (#874) Signed-off-by: EricoMeger <ericomeger9@gmail.com> Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> * bt_log_idle_transitions docs (#875) * Add docs Signed-off-by: Tony Najjar <tony.najjar@dexory.com> * revert Signed-off-by: Tony Najjar <tony.najjar@dexory.com> * . Signed-off-by: Tony Najjar <tony.najjar@dexory.com> * add console Signed-off-by: Tony Najjar <tony.najjar@dexory.com> --------- Signed-off-by: Tony Najjar <tony.najjar@dexory.com> Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> * docs: Update collision monitor tutorial for holonomic robot (#871) * Update velocity polygon linear_min/max Description Update collision monitor tutorial for holonomic robot Signed-off-by: Jaerak Son <sjr9017@naver.com> * [collision_monitor] Update velocity polygon angles and refine documentation - Updated `direction_start_angle` and `direction_end_angle` parameters in YAML to match the reference diagram. - Refined `using_collision_monitor.rst` based on review feedback (removed redundant non-negative description). Signed-off-by: Jaerak Son <sjr9017@naver.com> --------- Signed-off-by: Jaerak Son <sjr9017@naver.com> Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> * first draft semantic segmentation plugin Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> * readme fixes Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> * localization note Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> * fix codespell Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> * comments and clarifications Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> * Update tutorials/docs/navigation2_with_semantic_segmentation.rst Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Pedro Alejandro González <71234974+pepisg@users.noreply.github.com> Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> * Update tutorials/docs/navigation2_with_semantic_segmentation.rst Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Pedro Alejandro González <71234974+pepisg@users.noreply.github.com> Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> * Update tutorials/docs/navigation2_with_semantic_segmentation.rst Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Pedro Alejandro González <71234974+pepisg@users.noreply.github.com> Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> * Update tutorials/docs/navigation2_with_semantic_segmentation.rst Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Pedro Alejandro González <71234974+pepisg@users.noreply.github.com> * fix link Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> --------- Signed-off-by: EricoMeger <ericomeger9@gmail.com> Signed-off-by: pepisg <pedro.gonzalez@eia.edu.co> Signed-off-by: Tony Najjar <tony.najjar@dexory.com> Signed-off-by: Jaerak Son <sjr9017@naver.com> Signed-off-by: Pedro Alejandro González <71234974+pepisg@users.noreply.github.com> Co-authored-by: Érico Meger <86668447+EricoMeger@users.noreply.github.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: Jaerak Son <40343097+mach0312@users.noreply.github.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
VelocityPolygondocumentation to reflect the recent logic change for holonomic robots (#5740).holonomicis set to true,linear_minandlinear_maxchecks are applied to the resultant velocity magnitude (speed), not just the x-component.linear_minandlinear_maxmust be non-negative values.holonomic: false), the behavior remains unchanged, and signed values are still used for backward motion.