Skip to content

chore(rolldown_plugin_vite_asset_import_meta_url): remove unexposed native vite plugin#9896

Merged
graphite-app[bot] merged 1 commit into
mainfrom
06-20-chore_rolldown_plugin_vite_asset_import_meta_url_remove_unexposed_native_vite_plugin
Jun 22, 2026
Merged

chore(rolldown_plugin_vite_asset_import_meta_url): remove unexposed native vite plugin#9896
graphite-app[bot] merged 1 commit into
mainfrom
06-20-chore_rolldown_plugin_vite_asset_import_meta_url_remove_unexposed_native_vite_plugin

Conversation

@shulaoda

@shulaoda shulaoda commented Jun 19, 2026

Copy link
Copy Markdown
Member

Part of #9889. Stacked on #9895.

rolldown_plugin_vite_asset_import_meta_url is one of 6 rolldown_plugin_vite_* crates that are compiled only because of the crates/* workspace glob but are never wired into the napi binding (rolldown_binding) nor used anywhere — i.e. not exposed to JS/Vite.

This PR removes the rolldown_plugin_vite_asset_import_meta_url crate and regenerates Cargo.lock. cargo shear --fix --check-test-targets reports no orphaned workspace dependencies. No other crate depends on it. A snapshot of all 6 unexposed crates is preserved on the archive/native-vite-html-css-asset-plugins branch.

This is the last of the 6 unexposed crates tracked in #9889.

cargo check --workspace --all-features --all-targets --locked passes.

shulaoda commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq

codspeed-hq Bot commented Jun 22, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 7 untouched benchmarks
⏩ 10 skipped benchmarks1


Comparing 06-20-chore_rolldown_plugin_vite_asset_import_meta_url_remove_unexposed_native_vite_plugin (676e7c2) with main (d21eb93)2

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (676e7c2) during the generation of this report, so d21eb93 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

h-a-n-a commented Jun 22, 2026

Copy link
Copy Markdown
Member

Merge activity

  • Jun 22, 5:06 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 22, 5:06 AM UTC: h-a-n-a added this pull request to the Graphite merge queue.
  • Jun 22, 5:21 AM UTC: Merged by the Graphite merge queue.

…ative vite plugin (#9896)

Part of #9889. Stacked on #9895.

`rolldown_plugin_vite_asset_import_meta_url` is one of 6 `rolldown_plugin_vite_*` crates that are compiled only because of the `crates/*` workspace glob but are never wired into the napi binding (`rolldown_binding`) nor `use`d anywhere — i.e. not exposed to JS/Vite.

This PR removes the `rolldown_plugin_vite_asset_import_meta_url` crate and regenerates `Cargo.lock`. `cargo shear --fix --check-test-targets` reports no orphaned workspace dependencies. No other crate depends on it. A snapshot of all 6 unexposed crates is preserved on the `archive/native-vite-html-css-asset-plugins` branch.

This is the last of the 6 unexposed crates tracked in #9889.

`cargo check --workspace --all-features --all-targets --locked` passes.
@graphite-app graphite-app Bot force-pushed the 06-20-chore_rolldown_plugin_vite_asset_remove_unexposed_native_vite_plugin branch from 56b5fbb to 9c985c6 Compare June 22, 2026 05:13
@graphite-app graphite-app Bot force-pushed the 06-20-chore_rolldown_plugin_vite_asset_import_meta_url_remove_unexposed_native_vite_plugin branch from 63d5d5a to 676e7c2 Compare June 22, 2026 05:14
Base automatically changed from 06-20-chore_rolldown_plugin_vite_asset_remove_unexposed_native_vite_plugin to main June 22, 2026 05:20
@graphite-app graphite-app Bot merged commit 676e7c2 into main Jun 22, 2026
35 of 36 checks passed
@graphite-app graphite-app Bot deleted the 06-20-chore_rolldown_plugin_vite_asset_import_meta_url_remove_unexposed_native_vite_plugin branch June 22, 2026 05:21
@rolldown-guard rolldown-guard Bot mentioned this pull request Jun 24, 2026
shulaoda added a commit that referenced this pull request Jun 24, 2026
## [1.1.3] - 2026-06-24

### 🐛 Bug Fixes

- `defer_drop` crashes the browser main thread (#9942) by @shulaoda
- camel-case: correct camel case for nested values (#9933) by @kb019
- cli: display --help options in camelCase (#9941) by @IWANABETHATGUY
- preserve used re-exports under preserveModules (#9122) (#9934) by @IWANABETHATGUY
- watch: make close reentrant in event callbacks (#9904) by @hyf0
- git for windows treats symlink files as regular files (#9915) by @AliceLanniste
- dev: cancel pending full reload on build error (#9903) by @h-a-n-a
- chunking: pass plugin meta to codeSplitting groups name function (#9267) by @Kyujenius
- dev: serve assets emitted during HMR/lazy compile (vite#22596) (#9815) by @h-a-n-a
- release: dry-run step no longer publishes binding packages (#9866) by @Boshen

### 🚜 Refactor

- rolldown_common: model ModuleId as a classified Path/Virtual/Bare enum (#9927) by @Boshen
- remove unused LegacyModuleIdx (#9872) by @shulaoda
- remove unused StmtInfos::get_namespace_stmt_info (#9870) by @shulaoda
- remove unused Module::as_external_mut (#9871) by @shulaoda
- remove unused EcmaAst::is_body_empty (#9869) by @shulaoda
- drop dead is_css_module handling in resolve_dependencies (#9867) by @shulaoda
- drop redundant with_commonjs on cjs source type (#9868) by @shulaoda

### 📚 Documentation

- clarify on drafting PRs (#9952) by @h-a-n-a
- update contribution guidelines (#9944) by @fubhy
- note Rust crates don't follow semver in AGENTS.md (#9905) by @IWANABETHATGUY
- add feedback form (#9159) by @TheAlexLichter

### ⚡ Performance

- utils: avoid allocation in default_sanitize_file_name for clean names (#9928) by @Boshen
- binding: box once-per-build futures before spawn_future (#9864) by @Boshen
- utils: avoid wasted allocation in legitimize_identifier_name (#9926) by @Boshen
- rolldown: fuse the canonical-name dedup and insert in the renamer (#9900) by @Boshen
- rolldown: probe the name map once in ConflictResolver::resolve (#9899) by @Boshen
- cut two heap allocations from wrapped ESM init finalize (#9901) by @Boshen
- rolldown_plugin_vite_reporter: hoist invariant out_dir prefix out of reporter loop (#9873) by @shulaoda
- drop throwaway Vec in wrapped esm init stmt (#9878) by @shulaoda
- borrow owner_filename in build-import-analysis AddDeps (#9874) by @shulaoda

### 🧪 Testing

- cover preserveModules named export via namespace re-export (#6010) (#9937) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- deps: update napi to v3.9.4 (#9954) by @shulaoda
- reduce noise from CODEOWNERS for trival changes (#9953) by @h-a-n-a
- deps: update mimalloc-safe to 0.1.64 (#9950) by @shulaoda
- deps: update rollup submodule for tests to v4.62.2 (#9931) by @rolldown-guard[bot]
- deps: test mimalloc-safe upstream-mimalloc switch in CI (#9930) by @shulaoda
- rolldown_plugin_vite_build_import_analysis: remove unused v2 code path (#9917) by @shulaoda
- rolldown_plugin_vite_manifest: remove unused is_enable_v2 code path (#9916) by @shulaoda
- rolldown_plugin_vite_asset_import_meta_url: remove unexposed native vite plugin (#9896) by @shulaoda
- rolldown_plugin_vite_asset: remove unexposed native vite plugin (#9895) by @shulaoda
- rolldown_plugin_vite_css_post: remove unexposed native vite plugin (#9894) by @shulaoda
- rolldown_plugin_vite_css: remove unexposed native vite plugin (#9893) by @shulaoda
- rolldown_plugin_vite_html_inline_proxy: remove unexposed native vite plugin (#9892) by @shulaoda
- rolldown_plugin_vite_html: remove unexposed native vite plugin (#9891) by @shulaoda
- deps: update github actions (#9909) by @renovate[bot]
- deps: update rust crate oxc_sourcemap to v8.0.2 (#9910) by @renovate[bot]
- deps: update npm packages (#9912) by @renovate[bot]
- deps: update github actions to v7 (#9913) by @renovate[bot]
- deps: update rolldown-plugin-dts to ^0.26.0 (#9897) by @renovate[bot]
- remove rolldown_filter_analyzer crate (#9865) by @Boshen

### ❤️ New Contributors

* @fubhy made their first contribution in [#9944](#9944)

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants