chore(hmr): delete commented-out dead code left from old register-module codegen by hyf0 · Pull Request #9707 · rolldown/rolldown

hyf0 · 2026-06-10T07:01:09Z

Deletes commented-out dead code (not explanatory comments) left in the areas touched by the AstFactory migration stack. Every removed line is a comment or blank — zero behavior change.

`hmr_ast_finalizer.rs` — 55-line commented block in `generate_runtime_module_register_for_hmr`

The old hand-rolled __rolldown_runtime__.registerModule codegen.
feat(hmr): use trait HmrAstBuilder to unify ast construction #5310 replaced it with HmrAstBuilder::create_register_module_stmt() (the live call sits right above the block) and pasted the old body in as a comment.
Cannot be revived: it references the since-deleted snippet field and a never-imported PropertyKind.
Its two semantic deltas vs. the live path are intentional evolutions, documented in surviving code:
- stable-id string literal → __rolldown_module_id__ parameter (fix(dev/lazy): avoid module reinitialization in lazy compilation patches #9179)
- bare module → __rolldown_module__ (fix(hmr): register cjs module exports #4511)

`hmr_stage.rs` — 3 single lines

2× // unreachable!("HMR only supports normal module. ...") inside else { None } branches — the silent-skip semantics were decided long ago; the four live unreachable! calls elsewhere in the file are untouched.
1× // ret.is_self_accepting = true; // (hyf0) TODO: what's this for? — both the ret binding and the is_self_accepting field no longer exist anywhere in the workspace (pre-refactor(hmr): replace HmrOutput with HmrUpdate #5488 residue), so the question is unanswerable.

Deliberately kept

// full_reload_reason = Some("circular import invalidate") in hmr_stage.rs — marks real missing behavior, re-enabled separately in fix(hmr): report the full-reload reason for the invalidate-loop case #9708.

🤖 Generated with Claude Code

hyf0 · 2026-06-10T07:01:22Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR cleans up HMR-related Rust code by removing commented-out, superseded dead code in the HMR stage and AST finalizer, aligning the implementation with the current HmrAstBuilder::create_register_module_stmt path introduced in #3792.

Changes:

Removed an outdated TODO/commented assignment in compute_update_for_calling_invalidate.
Removed commented-out unreachable! residue in module filtering branches.
Deleted a large commented-out, obsolete registerModule generation block in generate_runtime_module_register_for_hmr.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/rolldown/src/hmr/hmr_stage.rs	Removes stale commented-out logic and unreachable-residue comments in HMR update computation paths.
crates/rolldown/src/hmr/hmr_ast_finalizer.rs	Removes a large commented-out legacy register-module codegen block now superseded by `create_register_module_stmt()`.

netlify · 2026-06-10T07:21:36Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`a1a3539`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6a290bb95a3cae00085ba93e

netlify · 2026-06-10T07:22:30Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`a10acb7`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6a291143d2fd5b0008e71894

codspeed-hq · 2026-06-10T07:23:27Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 10 skipped benchmarks¹

_{Comparing astfactory-remove-commented-code (40b0a7e) with main (fad6176)}

10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

hyf0 · 2026-06-10T07:24:05Z

Merge activity

Jun 10, 7:24 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 10, 7:24 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Jun 10, 7:30 AM UTC: Merged by the Graphite merge queue.

…ule codegen (#9707) The block in generate_runtime_module_register_for_hmr was superseded by HmrAstBuilder::create_register_module_stmt (called right above it) back in #3792 and even references the since-deleted snippet field; the two commented unreachable! lines were dead decision residue. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@hyf0

## [1.1.1] - 2026-06-11 ### 🚀 Features - ecmascript_utils: introduce AstFactory for AST construction (#9682) by @hyf0 - drop no-op init calls for empty wrapped-ESM modules (#9678) by @IWANABETHATGUY ### 🐛 Bug Fixes - resolver: honor package.json#type for .jsx/.tsx extensions (#9690) (#9699) by @IWANABETHATGUY - hmr: report the full-reload reason for the invalidate-loop case (#9708) by @hyf0 - explicit `moduleSideEffects` from a hook must take priority over the `package.json#sideEffects` (#9688) by @sapphi-red - keep the `rolldown-runtime` name for the standalone runtime chunk (#9685) by @shulaoda - lazy-barrel: request all exports for entry barrels on first encounter (#9672) by @shulaoda - finalizer: skip init_*() for tree-shaken wrapped ESM owners (#9669) by @IWANABETHATGUY - order `chunk.imports` by execution order (#9654) by @chuganzy - vite-resolve: preserve slash separators for Sass partial exports (#9546) by @cjc0013 - cross-chunk CJS wrapper shadowed by author-local binding (#9648) by @IWANABETHATGUY ### 🚜 Refactor - precompute wrapped-ESM init metadata in generate stage (#9712) by @IWANABETHATGUY - ecmascript_utils: fold construction ext traits onto AstFactory and delete AstSnippet (#9702) by @hyf0 - finalizer: finish ScopeHoistingFinalizer migration to AstFactory (#9701) by @hyf0 - finalizer: migrate module_finalizers/mod.rs to AstFactory (#9700) by @hyf0 - hmr: migrate hmr finalizer to AstFactory (#9695) by @hyf0 - plugin: migrate vite_build_import_analysis to AstFactory (#9693) by @hyf0 - scanner: migrate tweak_ast_for_scanning to AstFactory (#9683) by @hyf0 - always split runtime module first (#9419) by @IWANABETHATGUY ### 📚 Documentation - tsconfig: correct auto-discovery resolution to match TypeScript (#9714) by @shulaoda - design: plan to unify all internal AST construction (#9673) by @hyf0 - tsconfig: align reference resolution docs with TypeScript behavior (#9641) by @shulaoda ### ⚡ Performance - avoid per-module join Strings in scope-hoisting concatenation (#9645) by @Boshen - avoid intermediate Strings in the ESM export clause (#9644) by @Boshen - reuse a scratch buffer for facade namespace names in the scanner (#9642) by @Boshen - reuse the import-matching tracker stack across named imports (#9643) by @Boshen - avoid cloning the per-chunk export-items map in render_chunk_exports (#9639) by @Boshen - avoid CompactStr allocation in sorted-exports membership check (#9640) by @Boshen ### 🧪 Testing - add more `moduleSideEffects` precedence tests (#9689) by @sapphi-red - 9651: drop shimMissingExports from regression fixture (#9674) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - update react repo links (#9711) by @iiio2 - remove outdated pnpm configurations (#9666) by @btea - deps: update github actions to v2.81.5 (#9665) by @renovate[bot] - testing: migrate test harness off deprecated inlineDynamicImports (#9710) by @IWANABETHATGUY - hmr: delete commented-out dead code left from old register-module codegen (#9707) by @hyf0 - deps: update napi-rs toolchain (#9706) by @shulaoda - deps: update rollup submodule for tests to v4.61.1 (#9676) by @rolldown-guard[bot] - deps: update test262 submodule for tests (#9677) by @rolldown-guard[bot] - deps: update oxc to 0.135.0 (#9670) by @Boshen - pass ALGOLIA_APP_ID and ALGOLIA_API_KEY to void deploy (#9667) by @Boshen - deps: update github actions (#9662) by @renovate[bot] - deps: update rust crates (#9663) by @renovate[bot] - deps: update rolldown-plugin-dts to v0.25.2 (#9661) by @renovate[bot] - deps: update typos to v1.47.2 (#9660) by @renovate[bot] - deps: update docs dependencies (#9657) by @bddjr - deps: update typos to v1.47.1 (#9655) by @renovate[bot] - deploy website in its own workflow, only on docs output change (#9650) by @Boshen - publish to pkg.pr.new add pm and `commentWithDev` option (#9638) by @btea ### ❤️ New Contributors * @chuganzy made their first contribution in [#9654](#9654) * @cjc0013 made their first contribution in [#9546](#9546)

github-actions Bot assigned hyf0 Jun 10, 2026

hyf0 force-pushed the astfactory-remove-commented-code branch from a1a3539 to 40b0a7e Compare June 10, 2026 07:05

hyf0 marked this pull request as ready for review June 10, 2026 07:15

Copilot AI review requested due to automatic review settings June 10, 2026 07:15

Copilot started reviewing on behalf of hyf0 June 10, 2026 07:15 View session

Copilot AI reviewed Jun 10, 2026

View reviewed changes

h-a-n-a approved these changes Jun 10, 2026

View reviewed changes

hyf0 added the graphite: merge-when-ready label Jun 10, 2026

graphite-app Bot force-pushed the astfactory-remove-commented-code branch from 40b0a7e to a10acb7 Compare June 10, 2026 07:24

graphite-app Bot merged commit a10acb7 into main Jun 10, 2026
34 checks passed

graphite-app Bot removed the graphite: merge-when-ready label Jun 10, 2026

graphite-app Bot deleted the astfactory-remove-commented-code branch June 10, 2026 07:30

shulaoda mentioned this pull request Jun 11, 2026

release: v1.1.1 #9715

Closed

rolldown-guard Bot mentioned this pull request Jun 11, 2026

release: v1.1.1 #9718

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(hmr): delete commented-out dead code left from old register-module codegen#9707

chore(hmr): delete commented-out dead code left from old register-module codegen#9707
graphite-app[bot] merged 1 commit into
mainfrom
astfactory-remove-commented-code

hyf0 commented Jun 10, 2026 •

edited

Loading

Uh oh!

hyf0 commented Jun 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

netlify Bot commented Jun 10, 2026

Uh oh!

netlify Bot commented Jun 10, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jun 10, 2026

Uh oh!

hyf0 commented Jun 10, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hyf0 commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

hmr_ast_finalizer.rs — 55-line commented block in generate_runtime_module_register_for_hmr

hmr_stage.rs — 3 single lines

Deliberately kept

Uh oh!

hyf0 commented Jun 10, 2026

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

netlify Bot commented Jun 10, 2026

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

netlify Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

codspeed-hq Bot commented Jun 10, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

hyf0 commented Jun 10, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hyf0 commented Jun 10, 2026 •

edited

Loading

`hmr_ast_finalizer.rs` — 55-line commented block in `generate_runtime_module_register_for_hmr`

`hmr_stage.rs` — 3 single lines

netlify Bot commented Jun 10, 2026 •

edited

Loading

hyf0 commented Jun 10, 2026 •

edited by graphite-app Bot

Loading