Conversation
…cted by absolute base option
Member
Author
|
Do you think this change is reasonable? To some extent, it diverges from Vite rather than strictly aligning with it, and instead introduces a more generalized extension. @sapphi-red |
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
hyf0
approved these changes
Apr 22, 2026
Member
|
Is this a fix? or is this a refactor? |
Member
Author
Oh, sorry, this is more of a refactor aimed at making it extensible for third-party usage. |
sapphi-red
approved these changes
Apr 23, 2026
Member
sapphi-red
left a comment
There was a problem hiding this comment.
LGTM let's update the code in Vite as well.
This was referenced Apr 29, 2026
Closed
Merged
shulaoda
added a commit
that referenced
this pull request
Apr 29, 2026
## [1.0.0-rc.18] - 2026-04-29 ### 💥 BREAKING CHANGES - optimization: default unspecified inlineConst.mode to smart (#9248) by @IWANABETHATGUY ### 🐛 Bug Fixes - rolldown_plugin_vite_import_glob: return error instead of panicking when virtual module uses a relative glob (#9241) by @shulaoda - binding: treat empty inlineConst object as omitted (#9247) by @IWANABETHATGUY - rolldown: keep enum declaration for optional-chain access (#9229) by @Dunqing - link_stage: restore inline let-else in exports-kind filter (#9237) by @IWANABETHATGUY - dev/lazy: avoid module reinitialization in lazy compilation patches (#9179) by @h-a-n-a - dev: visit identifier references for runtime rewrites in HMR finalizer (#9191) by @h-a-n-a - chunk-optimizer: pick dominator for runtime placement to avoid cycles (#9164) by @IWANABETHATGUY - make `this.emitFile` chunk path synchronous to avoid deadlock (#9031) by @lazarv - use sentinel id for `browser: false` ignored modules (#9192) by @shulaoda - prevent chunk optimizer from creating import cycles (#9228) by @IWANABETHATGUY ### 🚜 Refactor - replace tokio::sync::Mutex with std::sync::Mutex for non-IO data (#9176) by @shulaoda - rolldown_plugin_vite_import_glob: do not rewrite import path for absolute base (#9195) by @shulaoda - runtime_helper: wrap DependedRuntimeHelperMap in a struct (#9215) by @IWANABETHATGUY - drop redundant clear() in determine_safely_merge_cjs_ns (#9206) by @IWANABETHATGUY - clean up generate_lazy_export (#9208) by @IWANABETHATGUY - bitset: return bool from set_bit to fuse guard-and-set (#9207) by @IWANABETHATGUY - link_stage: simplify exports-kind filter and clarify safety comments (#9205) by @IWANABETHATGUY ### 📚 Documentation - determine_module_exports_kind (#9252) by @IWANABETHATGUY - fix dead link to esbuild ESM/CJS interop tests (#9230) by @Copilot - remove CSS bundling references (#9234) by @shulaoda - correct IncrementalFullBuild row in BundleMode table (#9214) by @IWANABETHATGUY - design: add bundler data lifecycle design doc (#9212) by @hyf0 - remove minifier alpha status notices (#9202) by @sapphi-red ### ⚙️ Miscellaneous Tasks - upgrade oxc to 0.128.0 (#9260) by @shulaoda - deps: bump rolldown-ariadne to 0.6.0 (#9254) by @IWANABETHATGUY - deps: update github actions (#9259) by @renovate[bot] - deps: update github actions (#9258) by @renovate[bot] - remove renovate overrides (#9257) by @Boshen - use ubuntu-latest for security workflow (#9256) by @Boshen - notify Discord around release publish (#9251) by @Boshen - add release environment to npm publish workflow (#9250) by @Boshen - justfile: drop the `--` separator before forwarded args in `vp run` (#9246) by @shulaoda - deps: update test262 submodule for tests (#9243) by @sapphi-red - add more tracing instrumentations (#9220) by @sapphi-red - rolldown_plugin_vite_import_glob: remove outdated sourcemap doc comment (#9213) by @shulaoda - update security workflow (#9201) by @Boshen ### ❤️ New Contributors * @lazarv made their first contribution in [#9031](#9031) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #9145, #9145 (comment)
Summary
import_pathwhenoptions.basestarts with/. Previously the code re-computedimport_path = self.relative_path(file, None), which was intended to emulate Vite's/${relative(root, file)}shape but produced a broken result for files outsideroot(no leading/, e.g.../basic/dir/a.js).import_pathasself.relative_path(file, Some(dir))— a plain path relative to the importer's directory — regardless of whetherbaseis absolute. This yields stable, directly-resolvable relative imports that don't depend on any resolver-specific behavior.import-glob/parentfixture with two new cases coveringbase: '/', including one where the glob reaches a sibling directory (../basic/dir/*.js) outside the importer's folder.Why not align with Vite's
importPath = \/${relative(root, file)}``?Vite's
importMetaGlob.tsatL495-L497rewritesimportPathto an absolute-looking form (e.g./../external/a.js) and relies on its resolver to turn that back into a real file. Concretely,rolldown_plugin_vite_resolvesets:oxc-resolver's
rootsoption says: for requests starting with/, resolve them against each root (plus an absolute-path attempt on non-Windows). That is what lets Vite recover/../external/a.js— it falls through to${root}/../external/a.jsand normalizes.This only works while
asSrcistrue. ForoxcResolvePluginthat is effectively always the case, except insidecreateIdResolver, whereasSrcisfalseandrootsbecomes empty. In that path, a generated/../external/a.jswould fail to resolve.Using an importer-relative path (
../basic/dir/a.js) side-steps this entirely: it's a plain relative specifier that any resolver handles the same way, independent ofasSrc/roots. The trade-off is an intentional shape divergence from Vite — the keys in the returnedimport.meta.globobject differ whenbase: '/'is used with out-of-dir matches — but resolution becomes correct and resolver-agnostic.