Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
Co-authored-by: hyf0 <49502170+hyf0@users.noreply.github.com>
Co-authored-by: hyf0 <49502170+hyf0@users.noreply.github.com>
Copilot
AI
changed the title
ci: skip macOS CI on pull request
ci: skip macOS CI jobs on pull requests
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the main CI workflow to reduce PR CI load by running macOS (and other non-Ubuntu) jobs only on main, aligning with the existing pattern used to gate Windows jobs.
Changes:
- Collapse
cargo-testinto a single dynamic matrix that runs all OSes onmainbut onlyubuntu-lateston non-main. - Gate macOS Node test jobs to run only on
main. - Gate the macOS native build job to run only on
main.
This was referenced Mar 11, 2026
Closed
Merged
shulaoda
added a commit
that referenced
this pull request
Mar 11, 2026
## [1.0.0-rc.9] - 2026-03-11 ### 💥 BREAKING CHANGES - rename exported BindingMagicString to RolldownMagicString (#8626) by @IWANABETHATGUY ### 🚀 Features - rolldown: add isRolldownMagicString property for reliable native detection (#8614) by @IWANABETHATGUY - cli: align object type with rollup (#8598) by @h-a-n-a ### 🐛 Bug Fixes - rust: circular inter-chunk imports when external dynamic imports exist (#8596) by @Dunqing - update minify default docs from `false` to `'dce-only'` (#8620) by @shulaoda ### 💼 Other - fix early exit in script build-node (#8617) by @h-a-n-a ### 🚜 Refactor - binding: remove outdated TODO comment in MagicString to_string() (#8613) by @IWANABETHATGUY ### 📚 Documentation - add viteplus alpha announcement banner (#8615) by @mdong1909 - update VitePress theme to 4.8.2 for narrow-screen layout regression (#8612) by @Copilot ### ⚡ Performance - merge 4 integration test binaries into 1 (#8610) by @Boshen ### 🧪 Testing - replace heavy filename_with_hash test with targeted hash fixtures (#8597) by @Boshen ### ⚙️ Miscellaneous Tasks - ci: remove redundant `--no-run` build step from cargo-test (#8623) by @Boshen - rust: use `cargo-shear` to toggle Cargo.toml [lib] test = bool (#8622) by @Boshen - deps: update test262 submodule for tests (#8611) by @sapphi-red - skip macOS CI jobs on pull requests (#8608) by @Copilot - add rust cache to repo validation job (#8607) by @Boshen - skip running empty bin test targets (#8605) by @Boshen - skip building examples in cargo-test to reduce build time (#8603) by @Boshen - switch plain workflow checkouts to taiki-e action (#8601) by @Boshen - skip Windows CI jobs on PRs (#8600) by @Boshen - remove unused asset module (#8594) by @shulaoda ###◀️ Revert - "docs: add viteplus alpha announcement banner (#8615)" (#8616) by @shulaoda Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the CI policy from #8600 to macOS: PRs now run Ubuntu-only for the affected CI lanes, while macOS and Windows remain enabled on
main.Cargo test matrix
cargo-testplatform matrix explicit:main:ubuntu-latest,macos-latest,windows-latestmain:ubuntu-latestonlymacOS native build gating
build-rolldown-macosbehindgithub.ref_name == 'main'macOS Node job gating
node-test-macosbehindgithub.ref_name == 'main'node-dev-server-test-macosbehindgithub.ref_name == 'main'Workflow shape
mainbehavior instead of introducing a separate policy path✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.