feat(cli): align object type with rollup#8598
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
afaaa02 to
c14714a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates rolldown’s CLI “object-like” option parsing to accept Rollup-compatible key:value syntax, while keeping the legacy key=value form with a deprecation warning.
Changes:
- Switch object-option parsing to prefer
key:value(Rollup-style) and emit a warning whenkey=valueis used. - Update CLI e2e tests and snapshots to use
key:valueand verify the deprecation warning path. - Refresh help/descriptions and docs to describe
key:valuesyntax.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rolldown/src/cli/arguments/index.ts | Updates object-option parsing to support : with fallback to deprecated = plus warning. |
| packages/rolldown/src/utils/validator.ts | Updates option descriptions for globals and transform.define to document key:value syntax. |
| packages/rolldown/tests/cli/cli-e2e.test.ts | Updates CLI tests to use key:value and adds a deprecated key=value warning test. |
| packages/rolldown/tests/cli/snapshots/cli-e2e.test.ts.snap | Updates snapshots for help output and new warning test output. |
| meta/design/cli.md / docs/apis/cli.md | Updates documentation to reflect key:value object syntax. |
c14714a to
030ffbd
Compare
Member
Author
Merge activity
|
sapphi-red
approved these changes
Mar 9, 2026
This PR adds usage for `key:value` for object types to align with rollup's object-like type syntax. It also keeps `key=value` with a warning message for the backward compability. closes #8593
030ffbd to
6519694
Compare
This was referenced Mar 11, 2026
Closed
Merged
shulaoda
added a commit
that referenced
this pull request
Mar 11, 2026
## [1.0.0-rc.9] - 2026-03-11 ### 💥 BREAKING CHANGES - rename exported BindingMagicString to RolldownMagicString (#8626) by @IWANABETHATGUY ### 🚀 Features - rolldown: add isRolldownMagicString property for reliable native detection (#8614) by @IWANABETHATGUY - cli: align object type with rollup (#8598) by @h-a-n-a ### 🐛 Bug Fixes - rust: circular inter-chunk imports when external dynamic imports exist (#8596) by @Dunqing - update minify default docs from `false` to `'dce-only'` (#8620) by @shulaoda ### 💼 Other - fix early exit in script build-node (#8617) by @h-a-n-a ### 🚜 Refactor - binding: remove outdated TODO comment in MagicString to_string() (#8613) by @IWANABETHATGUY ### 📚 Documentation - add viteplus alpha announcement banner (#8615) by @mdong1909 - update VitePress theme to 4.8.2 for narrow-screen layout regression (#8612) by @Copilot ### ⚡ Performance - merge 4 integration test binaries into 1 (#8610) by @Boshen ### 🧪 Testing - replace heavy filename_with_hash test with targeted hash fixtures (#8597) by @Boshen ### ⚙️ Miscellaneous Tasks - ci: remove redundant `--no-run` build step from cargo-test (#8623) by @Boshen - rust: use `cargo-shear` to toggle Cargo.toml [lib] test = bool (#8622) by @Boshen - deps: update test262 submodule for tests (#8611) by @sapphi-red - skip macOS CI jobs on pull requests (#8608) by @Copilot - add rust cache to repo validation job (#8607) by @Boshen - skip running empty bin test targets (#8605) by @Boshen - skip building examples in cargo-test to reduce build time (#8603) by @Boshen - switch plain workflow checkouts to taiki-e action (#8601) by @Boshen - skip Windows CI jobs on PRs (#8600) by @Boshen - remove unused asset module (#8594) by @shulaoda ###◀️ Revert - "docs: add viteplus alpha announcement banner (#8615)" (#8616) by @shulaoda Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds usage for
key:valuefor object types to align with rollup's object-like type syntax.It also keeps
key=valuewith a warning message for the backward compability.closes #8593