Skip to content

ci: skip Windows CI jobs on PRs#8600

Merged
Boshen merged 1 commit intomainfrom
skip-windows-ci-on-prs
Mar 9, 2026
Merged

ci: skip Windows CI jobs on PRs#8600
Boshen merged 1 commit intomainfrom
skip-windows-ci-on-prs

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Mar 9, 2026

Summary

  • Skip all Windows CI jobs (cargo-test, build-rolldown-windows, node-test-windows, node-dev-server-test-windows) on PRs to speed up feedback (~2x slower than Ubuntu)
  • Windows jobs still run on main pushes to catch platform-specific issues

🤖 Generated with Claude Code

Windows CI jobs are ~2x slower than Ubuntu. Skip all Windows jobs
(cargo-test, build-rolldown, node-test, node-dev-server-test) on PRs
to speed up feedback. They still run on main pushes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 9, 2026 10:58
@netlify
Copy link

netlify bot commented Mar 9, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 3221205
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69aea7ca82ed1e0008e65b6d

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 32212058d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI workflow to reduce PR turnaround time by skipping Windows jobs except on main, keeping Windows coverage on post-merge runs.

Changes:

  • Limits cargo-test Windows runs to main by adjusting the OS matrix.
  • Adds if: github.ref_name == 'main' gating for Windows Node test jobs.
  • Adds if: github.ref_name == 'main' gating for the Windows native build job.

@Boshen Boshen mentioned this pull request Mar 9, 2026
@Boshen Boshen merged commit 857a523 into main Mar 9, 2026
59 of 60 checks passed
@Boshen Boshen deleted the skip-windows-ci-on-prs branch March 9, 2026 11:11
hyf0 added a commit that referenced this pull request Mar 9, 2026
This extends the CI policy from #8600 to macOS: PRs now run Ubuntu-only
for the affected CI lanes, while macOS and Windows remain enabled on
`main`.

- **Cargo test matrix**
  - Make the `cargo-test` platform matrix explicit:
    - `main`: `ubuntu-latest`, `macos-latest`, `windows-latest`
    - PRs / non-`main`: `ubuntu-latest` only

- **macOS native build gating**
  - Gate `build-rolldown-macos` behind `github.ref_name == 'main'`

- **macOS Node job gating**
  - Gate `node-test-macos` behind `github.ref_name == 'main'`
  - Gate `node-dev-server-test-macos` behind `github.ref_name == 'main'`

- **Workflow shape**
  - Keep Ubuntu PR coverage unchanged
- Mirror the existing Windows-on-`main` behavior instead of introducing
a separate policy path

```yml
strategy:
  matrix:
    target: ${{ github.ref_name == 'main'
      && fromJSON('["ubuntu-latest","macos-latest","windows-latest"]')
      || fromJSON('["ubuntu-latest"]') }}
```

<!-- START COPILOT CODING AGENT TIPS -->
---

✨ Let Copilot coding agent [set things up for
you](https://github.com/rolldown/rolldown/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot)
— coding agent works faster and does higher quality work when set up for
your repo.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: hyf0 <49502170+hyf0@users.noreply.github.com>
This was referenced Mar 11, 2026
shulaoda added a commit that referenced this pull request Mar 11, 2026
## [1.0.0-rc.9] - 2026-03-11

### 💥 BREAKING CHANGES

- rename exported BindingMagicString to RolldownMagicString (#8626) by @IWANABETHATGUY

### 🚀 Features

- rolldown: add isRolldownMagicString property for reliable native detection (#8614) by @IWANABETHATGUY
- cli: align object type with rollup (#8598) by @h-a-n-a

### 🐛 Bug Fixes

- rust: circular inter-chunk imports when external dynamic imports exist (#8596) by @Dunqing
- update minify default docs from `false` to `'dce-only'` (#8620) by @shulaoda

### 💼 Other

- fix early exit in script build-node (#8617) by @h-a-n-a

### 🚜 Refactor

- binding: remove outdated TODO comment in MagicString to_string() (#8613) by @IWANABETHATGUY

### 📚 Documentation

- add viteplus alpha announcement banner (#8615) by @mdong1909
- update VitePress theme to 4.8.2 for narrow-screen layout regression (#8612) by @Copilot

### ⚡ Performance

- merge 4 integration test binaries into 1 (#8610) by @Boshen

### 🧪 Testing

- replace heavy filename_with_hash test with targeted hash fixtures (#8597) by @Boshen

### ⚙️ Miscellaneous Tasks

- ci: remove redundant `--no-run` build step from cargo-test (#8623) by @Boshen
- rust: use `cargo-shear` to toggle Cargo.toml [lib] test = bool (#8622) by @Boshen
- deps: update test262 submodule for tests (#8611) by @sapphi-red
- skip macOS CI jobs on pull requests (#8608) by @Copilot
- add rust cache to repo validation job (#8607) by @Boshen
- skip running empty bin test targets (#8605) by @Boshen
- skip building examples in cargo-test to reduce build time (#8603) by @Boshen
- switch plain workflow checkouts to taiki-e action (#8601) by @Boshen
- skip Windows CI jobs on PRs (#8600) by @Boshen
- remove unused asset module (#8594) by @shulaoda

### ◀️ Revert

- "docs: add viteplus alpha announcement banner (#8615)" (#8616) by @shulaoda

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants