Skip to content

refactor(mcs): refactor apply_manual_code_splitting into ManualSplitter#8346

Merged
graphite-app[bot] merged 1 commit intomainfrom
refactor-manual-code-splitting
Feb 17, 2026
Merged

refactor(mcs): refactor apply_manual_code_splitting into ManualSplitter#8346
graphite-app[bot] merged 1 commit intomainfrom
refactor-manual-code-splitting

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Feb 16, 2026

Something wrong with the original PR when I tried to push commits into it. #8265. I had to re-create one. Thanks for the efforts of @ShroXd


Co-authored-by: Atriiy ShroXdF@gmail.com

Copilot AI review requested due to automatic review settings February 16, 2026 11:06
@hyf0 hyf0 changed the title refactor(mcs): refactor apply_manual_code_splitting into ManualSplitter refactor(mcs): refactor apply_manual_code_splitting into ManualSplitter Feb 16, 2026
@netlify
Copy link

netlify bot commented Feb 16, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 1fb3c79
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6993c033966f7800080e94a0

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the apply_manual_code_splitting method by extracting its logic into a dedicated ManualSplitter struct. This is a recreation of PR #8265 which had some issues.

Changes:

  • Introduced ManualSplitter struct to encapsulate manual code splitting state and logic
  • Refactored the monolithic apply_manual_code_splitting method into smaller, focused methods within ManualSplitter
  • Renamed is_unqualified helper function to is_below_merge_threshold for better clarity

Copy link
Member Author

hyf0 commented Feb 16, 2026

Merge activity

  • Feb 16, 11:12 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 17, 1:11 AM UTC: hyf0 added this pull request to the Graphite merge queue.
  • Feb 17, 1:22 AM UTC: Merged by the Graphite merge queue.

@github-actions
Copy link
Contributor

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     74.3±1.66ms        ? ?/sec    1.00     74.4±2.61ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     80.4±1.79ms        ? ?/sec    1.00     78.9±2.29ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    106.3±3.09ms        ? ?/sec    1.00    104.9±2.20ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    116.9±2.97ms        ? ?/sec    1.00    117.4±2.40ms        ? ?/sec
bundle/bundle@threejs                                        1.00     37.2±0.82ms        ? ?/sec    1.03     38.2±2.08ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     41.9±0.63ms        ? ?/sec    1.01     42.3±1.70ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    376.8±4.61ms        ? ?/sec    1.00    371.9±4.14ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    435.4±4.88ms        ? ?/sec    1.00    430.8±6.19ms        ? ?/sec
scan/scan@rome_ts                                            1.00     81.9±1.65ms        ? ?/sec    1.00     81.5±1.74ms        ? ?/sec
scan/scan@threejs                                            1.00     28.7±1.68ms        ? ?/sec    1.00     28.7±1.72ms        ? ?/sec
scan/scan@threejs10x                                         1.00    279.0±4.45ms        ? ?/sec    1.00    280.0±4.06ms        ? ?/sec

@hyf0 hyf0 requested review from sapphi-red February 16, 2026 15:43
…itter` (#8346)

Something wrong with the original PR when I tried to push commits into it. #8265. I had to re-create one. Thanks for the efforts of @ShroXd
@graphite-app graphite-app bot force-pushed the refactor-manual-code-splitting branch from 1262aca to 1fb3c79 Compare February 17, 2026 01:11
@graphite-app graphite-app bot merged commit 1fb3c79 into main Feb 17, 2026
35 checks passed
@graphite-app graphite-app bot deleted the refactor-manual-code-splitting branch February 17, 2026 01:22
shulaoda pushed a commit that referenced this pull request Feb 18, 2026
## [1.0.0-rc.5] - 2026-02-18

💡 Smarter `entriesAware` Manual Code Splitting                                                                 
                                             
New `entriesAware` and `entriesAwareMergeThreshold` options for `manualCodeSplitting.groups[]` enable              
entry-reachability-based chunk splitting with automatic small chunk merging.                                       
                                                                                                                   
- `entriesAware: true` splits matched modules by entry reachability — modules reached by the same set of entries are grouped together, providing the most precise loading behavior with less over-fetching
- Chunks now get more readable names reflecting their entry associations (e.g. `vendor-entry-a-entry-b.js`) instead of opaque hashes
- `entriesAwareMergeThreshold` sets a byte-size threshold to merge tiny subgroups into the closest sibling with the fewest extra entries, reducing micro-chunk fragmentation while preserving precision
- Recommended to use together with `maxSize`: merge tiny chunks first to reduce request overhead, then cap large chunks to control payload size

```js
manualCodeSplitting: {
  groups: [{
    name: 'vendor',
    test: /node_modules/,
    entriesAware: true,
    entriesAwareMergeThreshold: 28000, // bytes
  }]
}
```

### 🚀 Features

- add `Visitor` to `rolldown/utils` (#8373) by @sapphi-red
- module-info: add `inputFormat` property to `ModuleInfo` (#8329) by @shulaoda
- default `treeshake.invalid_import_side_effects` to `false` (#8357) by @sapphi-red
- rolldown_utils: add `IndexBitSet` (#8343) by @sapphi-red
- rolldown_utils: add more methods and trait impls to BitSet (#8342) by @sapphi-red
- rolldown_plugin_vite_build_import_analysis: add support for `await import().then((m) => m.prop)` (#8328) by @sapphi-red
- rolldown_plugin_vite_reporter: support custom logger for build infos (#7652) by @shulaoda
- rust/mcs: support `entriesAwareMergeThreshold` (#8312) by @hyf0
- mcs: `maxSize` will split the oversized chunk with taking file relevance into account (#8277) by @hyf0
- rolldown_plugin_vite_import_glob: support template literal in glob import patterns (#8298) by @shulaoda
- rolldown_plugin_chunk_import_map: output importmap without spaces (#8297) by @sapphi-red
- add INEFFECTIVE_DYNAMIC_IMPORT warning in core (#8284) by @shulaoda
- mcs: generate more readable name for `entriesAware` chunks (#8275) by @hyf0
- mcs: support `entriesAware` (#8274) by @hyf0

### 🐛 Bug Fixes

- improve circular dependency detection in chunk optimizer (#8371) by @IWANABETHATGUY
- align `minify.compress: true` and `minify.mangle: true` with `minify: true` (#8367) by @sapphi-red
- rolldown_plugin_esm_external_require: apply conversion to UMD and IIFE outputs (#8359) by @sapphi-red
- cjs: bailout treeshaking on cjs modules that have multiple re-exports (#8348) by @hyf0
- handle member expression and this expression in JSX element name rewriting (#8323) by @IWANABETHATGUY
- pad `encode_hash_with_base` output to fixed length to prevent slice panics (#8320) by @shulaoda
- `xxhash_with_base` skips hashing when input is exactly 16 bytes (#8319) by @shulaoda
- complete `ImportKind::try_from` with missing variants and correct `url-import` to `url-token` (#8310) by @shulaoda
- mark Node.js builtin modules as side-effect-free when resolved via `external` config (#8304) by @IWANABETHATGUY
- mcs: `maxSize` should split chunks correctly based on sizes (#8289) by @hyf0

### 🚜 Refactor

- introduce `RawMangleOptions` and `RawCompressOptions` (#8366) by @sapphi-red
- mcs: refactor `apply_manual_code_splitting` into `ManualSplitter` (#8346) by @hyf0
- rolldown_plugin_vite_reporter: simplify hook registration and remove redundant state (#8322) by @shulaoda
- use set to store user defined entry modules (#8315) by @IWANABETHATGUY
- rust/mcs: collect groups into map at first for having clean and performant operations (#8313) by @hyf0
- mcs: introduce newtype `ModuleGroupOrigin` and `ModuleGroupId` (#8311) by @hyf0
- remove unnecessary `FinalizerMutableState` struct (#8303) by @shulaoda
- move module finalization into `finalize_modules` (#8302) by @shulaoda
- extract `apply_transfer_parts_mutation` into its own module (#8301) by @shulaoda
- move ESM format check into `determine_export_mode` (#8294) by @shulaoda
- remove `warnings` field from `GenerateContext` (#8293) by @shulaoda
- extract util function remove clippy supression (#8290) by @IWANABETHATGUY
- move `is_in_node_modules` to `PathExt` trait in `rolldown_std_utils` (#8286) by @shulaoda
- rolldown_plugin_vite_reporter: remove unnecessary ineffective dynamic import detection logic (#8285) by @shulaoda
- dev: inject hmr runtime to `\0rolldown/runtime.js` (#8234) by @hyf0
- improve naming in chunk_optimizer (#8287) by @IWANABETHATGUY
- simplify PostChunkOptimizationOperation from bitflags to enum (#8283) by @IWANABETHATGUY
- optimize BitSet.index_of_one to return iterator instead of Vec (#8282) by @IWANABETHATGUY

### 📚 Documentation

- change default value in `format` JSDoc from `'esm'` to `'es'` (#8372) by @shulaoda
- in-depth: remove `invalidImportSideEffects` option mention from lazy barrel optimization doc (#8355) by @sapphi-red
- mcs: clarify `minSize` constraints (#8279) by @ShroXd

### ⚡ Performance

- use IndexVec for chunk TLA detection (#8341) by @sapphi-red
- only invoke single resolve call for the same specifier and import kind (#8332) by @sapphi-red
- rolldown_plugin_vite_reporter: skip gzip computation when `report_compressed_size` is disabled (#8321) by @shulaoda

### 🧪 Testing

- use `vi.waitFor` and `expect.poll` instead of custom `waitUtil` function (#8369) by @sapphi-red
- rolldown_plugin_esm_external_require_plugin: add tests (#8358) by @sapphi-red
- add watch file tests (#8330) by @sapphi-red
- rolldown_plugin_vite_build_import_analysis: add test for dynamic import treeshaking (#8327) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- prepare-release: skip workflow on forked repositories (#8368) by @shulaoda
- format more files (#8360) by @sapphi-red
- deps: update oxc to v0.114.0 (#8347) by @camc314
- deps: update test262 submodule for tests (#8354) by @sapphi-red
- deps: update crate-ci/typos action to v1.43.5 (#8350) by @renovate[bot]
- deps: update oxc apps (#8351) by @renovate[bot]
- rolldown_plugin_vite_reporter: remove unnecessary README.md (#8334) by @shulaoda
- deps: update npm packages (#8338) by @renovate[bot]
- deps: update rust crates (#8339) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.13.0 (#8337) by @renovate[bot]
- deps: update github-actions (#8336) by @renovate[bot]
- deps: update napi to v3.8.3 (#8331) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.2 (#8325) by @renovate[bot]
- remove unnecessary transform.decorator (#8314) by @IWANABETHATGUY
- deps: update dependency rust to v1.93.1 (#8305) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.1 (#8300) by @renovate[bot]
- deps: update oxc apps (#8296) by @renovate[bot]
- docs: don't skip for build runs without cache (#8281) by @sapphi-red
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants