Skip to content

refactor(manual_code_splitting): refactor apply_manual_code_splitting into ManualSplitter#8265

Closed
ShroXd wants to merge 0 commit intorolldown:mainfrom
ShroXd:refactor-manual-code-splitting
Closed

refactor(manual_code_splitting): refactor apply_manual_code_splitting into ManualSplitter#8265
ShroXd wants to merge 0 commit intorolldown:mainfrom
ShroXd:refactor-manual-code-splitting

Conversation

@ShroXd
Copy link
Contributor

@ShroXd ShroXd commented Feb 10, 2026

  1. Introduce a ManualSplitter struct to encapsulate code-splitting metadata and logic.
  2. Refactor the original apply_manual_code_splitting logic into ManualSplitter methods.
  3. Implement a run method in ManualSplitter to orchestrate the entire code-splitting workflow.

@ShroXd ShroXd changed the title Refactor apply_manual_code_splitting into ManualSplitter refactor(manual_code_splitting): refactor apply_manual_code_splitting into ManualSplitter Feb 10, 2026
@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 February 11, 2026 04:29
@hyf0 hyf0 self-assigned this Feb 11, 2026
@hyf0
Copy link
Member

hyf0 commented Feb 11, 2026

Thanks for your work! I happened to need to solve some issues related to manual code splitting. I'll take it from here and evaluate this PR.

@hyf0 hyf0 closed this Feb 16, 2026
@hyf0 hyf0 force-pushed the refactor-manual-code-splitting branch from fa1bbea to 17d14a0 Compare February 16, 2026 10:45
@netlify
Copy link

netlify bot commented Feb 16, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 17d14a0
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6992f56379c3ca0008869df0

@hyf0
Copy link
Member

hyf0 commented Feb 16, 2026

Something wrong. Let me investigate a little bit.

graphite-app bot pushed a commit that referenced this pull request Feb 17, 2026
…itter` (#8346)

Something wrong with the original PR when I tried to push commits into it. #8265. I had to re-create one. Thanks for the efforts of @ShroXd
@ShroXd ShroXd deleted the refactor-manual-code-splitting branch February 18, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants