Skip to content

refactor: extract util function remove clippy supression#8290

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-12-refactor_extract_util_function_remove_clippy_supression
Feb 12, 2026
Merged

refactor: extract util function remove clippy supression#8290
graphite-app[bot] merged 1 commit intomainfrom
02-12-refactor_extract_util_function_remove_clippy_supression

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Feb 12, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 5e502b1
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/698dacb630a2f2000856c7b0

@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-12-refactor_extract_util_function_remove_clippy_supression branch from fbcc115 to 2a88ed7 Compare February 12, 2026 09:18
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review February 12, 2026 09:51
Copilot AI review requested due to automatic review settings February 12, 2026 09:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the chunk optimization code by extracting a helper function and renaming the main function to better reflect its broader purpose. The refactoring successfully reduces code complexity and removes a clippy suppression for excessive function length.

Changes:

  • Renamed optimize_facade_dynamic_entry_chunks to optimize_facade_entry_chunks to better reflect that it handles multiple types of facade chunks (dynamic entries and emitted chunks)
  • Extracted apply_common_chunk_merges helper function to reduce the main function's length and improve code organization
  • Removed #[expect(clippy::too_many_lines)] suppression, as the refactoring brought the function below the line limit

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
crates/rolldown/src/stages/generate_stage/code_splitting.rs Updated function call to use the new name optimize_facade_entry_chunks
crates/rolldown/src/stages/generate_stage/chunk_optimizer.rs Renamed function, extracted apply_common_chunk_merges helper, and removed clippy suppression

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

Benchmarks Rust

  • target: main(80fa52b)
  • pr: 02-12-refactor_extract_util_function_remove_clippy_supression(ed66bbf)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     71.7±2.49ms        ? ?/sec    1.00     71.0±2.65ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     76.2±1.60ms        ? ?/sec    1.00     76.2±2.06ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    100.0±1.84ms        ? ?/sec    1.00     99.8±1.98ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    111.0±2.52ms        ? ?/sec    1.02    113.3±2.62ms        ? ?/sec
bundle/bundle@threejs                                        1.02     36.3±3.08ms        ? ?/sec    1.00     35.7±0.75ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     40.4±0.65ms        ? ?/sec    1.01     41.0±0.93ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    360.4±4.39ms        ? ?/sec    1.03    370.0±9.54ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    418.9±4.14ms        ? ?/sec    1.01    422.5±7.29ms        ? ?/sec
scan/scan@rome_ts                                            1.00     78.9±1.76ms        ? ?/sec    1.02     80.1±1.80ms        ? ?/sec
scan/scan@threejs                                            1.00     27.4±0.48ms        ? ?/sec    1.03     28.2±1.81ms        ? ?/sec
scan/scan@threejs10x                                         1.00    281.5±4.20ms        ? ?/sec    1.01    285.4±4.29ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 12, 2026

Merge activity

Copilot AI review requested due to automatic review settings February 12, 2026 10:28
@graphite-app graphite-app bot force-pushed the 02-12-refactor_extract_util_function_remove_clippy_supression branch from ed66bbf to a691a07 Compare February 12, 2026 10:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot force-pushed the 02-12-refactor_extract_util_function_remove_clippy_supression branch from a691a07 to 5e502b1 Compare February 12, 2026 10:34
@graphite-app graphite-app bot merged commit 5e502b1 into main Feb 12, 2026
41 checks passed
@graphite-app graphite-app bot deleted the 02-12-refactor_extract_util_function_remove_clippy_supression branch February 12, 2026 11:29
@github-actions github-actions bot mentioned this pull request Feb 18, 2026
This was referenced Feb 18, 2026
shulaoda pushed a commit that referenced this pull request Feb 18, 2026
## [1.0.0-rc.5] - 2026-02-18

💡 Smarter `entriesAware` Manual Code Splitting                                                                 
                                             
New `entriesAware` and `entriesAwareMergeThreshold` options for `manualCodeSplitting.groups[]` enable              
entry-reachability-based chunk splitting with automatic small chunk merging.                                       
                                                                                                                   
- `entriesAware: true` splits matched modules by entry reachability — modules reached by the same set of entries are grouped together, providing the most precise loading behavior with less over-fetching
- Chunks now get more readable names reflecting their entry associations (e.g. `vendor-entry-a-entry-b.js`) instead of opaque hashes
- `entriesAwareMergeThreshold` sets a byte-size threshold to merge tiny subgroups into the closest sibling with the fewest extra entries, reducing micro-chunk fragmentation while preserving precision
- Recommended to use together with `maxSize`: merge tiny chunks first to reduce request overhead, then cap large chunks to control payload size

```js
manualCodeSplitting: {
  groups: [{
    name: 'vendor',
    test: /node_modules/,
    entriesAware: true,
    entriesAwareMergeThreshold: 28000, // bytes
  }]
}
```

### 🚀 Features

- add `Visitor` to `rolldown/utils` (#8373) by @sapphi-red
- module-info: add `inputFormat` property to `ModuleInfo` (#8329) by @shulaoda
- default `treeshake.invalid_import_side_effects` to `false` (#8357) by @sapphi-red
- rolldown_utils: add `IndexBitSet` (#8343) by @sapphi-red
- rolldown_utils: add more methods and trait impls to BitSet (#8342) by @sapphi-red
- rolldown_plugin_vite_build_import_analysis: add support for `await import().then((m) => m.prop)` (#8328) by @sapphi-red
- rolldown_plugin_vite_reporter: support custom logger for build infos (#7652) by @shulaoda
- rust/mcs: support `entriesAwareMergeThreshold` (#8312) by @hyf0
- mcs: `maxSize` will split the oversized chunk with taking file relevance into account (#8277) by @hyf0
- rolldown_plugin_vite_import_glob: support template literal in glob import patterns (#8298) by @shulaoda
- rolldown_plugin_chunk_import_map: output importmap without spaces (#8297) by @sapphi-red
- add INEFFECTIVE_DYNAMIC_IMPORT warning in core (#8284) by @shulaoda
- mcs: generate more readable name for `entriesAware` chunks (#8275) by @hyf0
- mcs: support `entriesAware` (#8274) by @hyf0

### 🐛 Bug Fixes

- improve circular dependency detection in chunk optimizer (#8371) by @IWANABETHATGUY
- align `minify.compress: true` and `minify.mangle: true` with `minify: true` (#8367) by @sapphi-red
- rolldown_plugin_esm_external_require: apply conversion to UMD and IIFE outputs (#8359) by @sapphi-red
- cjs: bailout treeshaking on cjs modules that have multiple re-exports (#8348) by @hyf0
- handle member expression and this expression in JSX element name rewriting (#8323) by @IWANABETHATGUY
- pad `encode_hash_with_base` output to fixed length to prevent slice panics (#8320) by @shulaoda
- `xxhash_with_base` skips hashing when input is exactly 16 bytes (#8319) by @shulaoda
- complete `ImportKind::try_from` with missing variants and correct `url-import` to `url-token` (#8310) by @shulaoda
- mark Node.js builtin modules as side-effect-free when resolved via `external` config (#8304) by @IWANABETHATGUY
- mcs: `maxSize` should split chunks correctly based on sizes (#8289) by @hyf0

### 🚜 Refactor

- introduce `RawMangleOptions` and `RawCompressOptions` (#8366) by @sapphi-red
- mcs: refactor `apply_manual_code_splitting` into `ManualSplitter` (#8346) by @hyf0
- rolldown_plugin_vite_reporter: simplify hook registration and remove redundant state (#8322) by @shulaoda
- use set to store user defined entry modules (#8315) by @IWANABETHATGUY
- rust/mcs: collect groups into map at first for having clean and performant operations (#8313) by @hyf0
- mcs: introduce newtype `ModuleGroupOrigin` and `ModuleGroupId` (#8311) by @hyf0
- remove unnecessary `FinalizerMutableState` struct (#8303) by @shulaoda
- move module finalization into `finalize_modules` (#8302) by @shulaoda
- extract `apply_transfer_parts_mutation` into its own module (#8301) by @shulaoda
- move ESM format check into `determine_export_mode` (#8294) by @shulaoda
- remove `warnings` field from `GenerateContext` (#8293) by @shulaoda
- extract util function remove clippy supression (#8290) by @IWANABETHATGUY
- move `is_in_node_modules` to `PathExt` trait in `rolldown_std_utils` (#8286) by @shulaoda
- rolldown_plugin_vite_reporter: remove unnecessary ineffective dynamic import detection logic (#8285) by @shulaoda
- dev: inject hmr runtime to `\0rolldown/runtime.js` (#8234) by @hyf0
- improve naming in chunk_optimizer (#8287) by @IWANABETHATGUY
- simplify PostChunkOptimizationOperation from bitflags to enum (#8283) by @IWANABETHATGUY
- optimize BitSet.index_of_one to return iterator instead of Vec (#8282) by @IWANABETHATGUY

### 📚 Documentation

- change default value in `format` JSDoc from `'esm'` to `'es'` (#8372) by @shulaoda
- in-depth: remove `invalidImportSideEffects` option mention from lazy barrel optimization doc (#8355) by @sapphi-red
- mcs: clarify `minSize` constraints (#8279) by @ShroXd

### ⚡ Performance

- use IndexVec for chunk TLA detection (#8341) by @sapphi-red
- only invoke single resolve call for the same specifier and import kind (#8332) by @sapphi-red
- rolldown_plugin_vite_reporter: skip gzip computation when `report_compressed_size` is disabled (#8321) by @shulaoda

### 🧪 Testing

- use `vi.waitFor` and `expect.poll` instead of custom `waitUtil` function (#8369) by @sapphi-red
- rolldown_plugin_esm_external_require_plugin: add tests (#8358) by @sapphi-red
- add watch file tests (#8330) by @sapphi-red
- rolldown_plugin_vite_build_import_analysis: add test for dynamic import treeshaking (#8327) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- prepare-release: skip workflow on forked repositories (#8368) by @shulaoda
- format more files (#8360) by @sapphi-red
- deps: update oxc to v0.114.0 (#8347) by @camc314
- deps: update test262 submodule for tests (#8354) by @sapphi-red
- deps: update crate-ci/typos action to v1.43.5 (#8350) by @renovate[bot]
- deps: update oxc apps (#8351) by @renovate[bot]
- rolldown_plugin_vite_reporter: remove unnecessary README.md (#8334) by @shulaoda
- deps: update npm packages (#8338) by @renovate[bot]
- deps: update rust crates (#8339) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.13.0 (#8337) by @renovate[bot]
- deps: update github-actions (#8336) by @renovate[bot]
- deps: update napi to v3.8.3 (#8331) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.2 (#8325) by @renovate[bot]
- remove unnecessary transform.decorator (#8314) by @IWANABETHATGUY
- deps: update dependency rust to v1.93.1 (#8305) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.12.1 (#8300) by @renovate[bot]
- deps: update oxc apps (#8296) by @renovate[bot]
- docs: don't skip for build runs without cache (#8281) by @sapphi-red
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants