Skip to content

refactor: give variable a more suitable name#3375

Merged
IWANABETHATGUY merged 1 commit intomainfrom
01-17-chore_give_variable_more_suitable_name
Jan 17, 2025
Merged

refactor: give variable a more suitable name#3375
IWANABETHATGUY merged 1 commit intomainfrom
01-17-chore_give_variable_more_suitable_name

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Jan 17, 2025

Description

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review January 17, 2025 09:30
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Jan 17, 2025
Merged
@IWANABETHATGUY Graphite App
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Jan 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY changed the title chore: give variable more suitable name chore: give variable a more suitable name Jan 17, 2025
@IWANABETHATGUY IWANABETHATGUY changed the title chore: give variable a more suitable name refactor: give variable a more suitable name Jan 17, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 17, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(a65dcfe)
  • pr: 01-17-chore_give_variable_more_suitable_name(1c64290)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     72.4±0.90ms        ? ?/sec    1.04     74.9±1.96ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.02     96.7±2.78ms        ? ?/sec    1.00     95.1±1.98ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    107.8±1.79ms        ? ?/sec    1.00    107.5±1.25ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     82.7±1.21ms        ? ?/sec    1.01     83.2±2.24ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    121.4±0.81ms        ? ?/sec    1.02    123.5±1.59ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    207.6±6.12ms        ? ?/sec    1.04    215.4±4.51ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    243.5±5.39ms        ? ?/sec    1.05    255.3±9.24ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    134.5±1.82ms        ? ?/sec    1.01    136.1±1.67ms        ? ?/sec
bundle/bundle@threejs                                               1.01     41.6±2.42ms        ? ?/sec    1.00     41.3±0.76ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     95.2±0.69ms        ? ?/sec    1.03     97.8±3.58ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    110.8±1.36ms        ? ?/sec    1.00    111.3±2.20ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     51.0±0.58ms        ? ?/sec    1.02     52.1±1.02ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    433.6±6.49ms        ? ?/sec    1.01    439.2±4.36ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1094.2±11.27ms        ? ?/sec    1.01   1099.8±6.99ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1266.8±8.27ms        ? ?/sec    1.01  1279.2±10.72ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    503.1±6.46ms        ? ?/sec    1.02    514.0±8.49ms        ? ?/sec
remapping/remapping                                                 1.00     26.1±0.14ms        ? ?/sec    1.04     27.2±0.95ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     65.7±0.62ms        ? ?/sec    1.11     72.8±5.87ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     95.9±2.30ms        ? ?/sec    1.01     96.9±1.59ms        ? ?/sec
scan/scan@threejs                                                   1.01     31.3±0.28ms        ? ?/sec    1.00     30.9±0.30ms        ? ?/sec
scan/scan@threejs10x                                                1.01    318.2±3.55ms        ? ?/sec    1.00    316.5±4.02ms        ? ?/sec

Base automatically changed from 01-17-fix_extract_rest_binding_pattern to main January 17, 2025 09:44
@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-17-chore_give_variable_more_suitable_name branch from f059ddc to 1c64290 Compare January 17, 2025 09:44
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Jan 17, 2025

Merge activity

  • Jan 17, 4:45 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit aabe0be Jan 17, 2025
@IWANABETHATGUY IWANABETHATGUY deleted the 01-17-chore_give_variable_more_suitable_name branch January 17, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0