Skip to content

fix: extract RestElement in ObjectPattern #3374

Merged
IWANABETHATGUY merged 1 commit intomainfrom
01-17-fix_extract_rest_binding_pattern
Jan 17, 2025
Merged

fix: extract RestElement in ObjectPattern #3374
IWANABETHATGUY merged 1 commit intomainfrom
01-17-fix_extract_rest_binding_pattern

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Jan 17, 2025 •
edited
Loading

@IWANABETHATGUY Graphite App
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Jan 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 17, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(5e82a40)
  • pr: 01-17-fix_extract_rest_binding_pattern(2258e5e)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     75.0±2.00ms        ? ?/sec    1.00     74.8±1.97ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     96.3±2.48ms        ? ?/sec    1.02     97.8±2.47ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.01    108.8±2.12ms        ? ?/sec    1.00    107.7±1.68ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.02     84.6±1.96ms        ? ?/sec    1.00     83.3±1.97ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    121.5±1.55ms        ? ?/sec    1.02    123.6±3.39ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    217.2±7.00ms        ? ?/sec    1.02    221.7±8.77ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    256.9±6.68ms        ? ?/sec    1.01    260.3±8.85ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    134.4±2.05ms        ? ?/sec    1.02    137.1±4.49ms        ? ?/sec
bundle/bundle@threejs                                               1.00     41.5±0.78ms        ? ?/sec    1.03     42.8±2.79ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     95.4±1.05ms        ? ?/sec    1.00     95.2±2.18ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.03    115.1±2.16ms        ? ?/sec    1.00    112.2±1.45ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     52.8±1.44ms        ? ?/sec    1.00     52.1±1.95ms        ? ?/sec
bundle/bundle@threejs10x                                            1.02    439.8±5.00ms        ? ?/sec    1.00    432.4±6.00ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1086.7±9.04ms        ? ?/sec    1.00   1086.0±7.05ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1254.6±7.21ms        ? ?/sec    1.01   1267.9±7.52ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    508.6±5.02ms        ? ?/sec    1.00   507.3±10.42ms        ? ?/sec
remapping/remapping                                                 1.02     27.6±0.38ms        ? ?/sec    1.00     27.0±0.25ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     71.3±4.83ms        ? ?/sec    1.00     71.6±5.81ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     95.5±1.62ms        ? ?/sec    1.05     99.8±1.75ms        ? ?/sec
scan/scan@threejs                                                   1.00     31.9±1.46ms        ? ?/sec    1.01     32.2±0.88ms        ? ?/sec
scan/scan@threejs10x                                                1.00    318.6±5.96ms        ? ?/sec    1.01    320.2±8.51ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-17-fix_extract_rest_binding_pattern branch 2 times, most recently from 4feeb9f to e7956b6 Compare January 17, 2025 09:20
@IWANABETHATGUY IWANABETHATGUY changed the title fix: extract rest binding pattern fix: extract RestElement in Object binding pattern Jan 17, 2025
@IWANABETHATGUY IWANABETHATGUY changed the title fix: extract RestElement in Object binding pattern fix: extract RestElement in ObjectPattern Jan 17, 2025
@IWANABETHATGUY IWANABETHATGUY changed the title fix: extract RestElement in ObjectPattern fix: extract RestElement in ObjectPattern Jan 17, 2025
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review January 17, 2025 09:22
@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-17-fix_extract_rest_binding_pattern branch from e7956b6 to 2258e5e Compare January 17, 2025 09:22
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Jan 17, 2025
Merged
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit a65dcfe Jan 17, 2025
@IWANABETHATGUY IWANABETHATGUY deleted the 01-17-fix_extract_rest_binding_pattern branch January 17, 2025 09:44
@dbartholomae dbartholomae mentioned this pull request Apr 14, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Destructuring rest pattern generates undefined __rest variable

2 participants

@IWANABETHATGUY @hyf0