chore: give variable more suitable name

IWANABETHATGUY · IWANABETHATGUY · commit 1c6429018cb6 · 2025-01-17T09:44:57.000Z
diff --git a/crates/rolldown_ecmascript_utils/src/extensions/ast_ext/binding_pattern_ext.rs b/crates/rolldown_ecmascript_utils/src/extensions/ast_ext/binding_pattern_ext.rs
@@ -15,25 +15,25 @@ pub trait BindingPatternExt<'ast> {
 
 impl<'ast> BindingPatternExt<'ast> for ast::BindingPattern<'ast> {
   fn binding_identifiers(&self) -> smallvec::SmallVec<[&Box<ast::BindingIdentifier<'ast>>; 1]> {
-    let mut queue = vec![&self.kind];
+    let mut stack = vec![&self.kind];
     let mut ret = SmallVec::default();
-    while let Some(binding_kind) = queue.pop() {
+    while let Some(binding_kind) = stack.pop() {
       match binding_kind {
         ast::BindingPatternKind::BindingIdentifier(id) => {
           ret.push(id);
         }
         ast::BindingPatternKind::ArrayPattern(arr_pat) => {
-          queue.extend(arr_pat.elements.iter().flatten().map(|pat| &pat.kind).rev());
+          stack.extend(arr_pat.elements.iter().flatten().map(|pat| &pat.kind).rev());
         }
         ast::BindingPatternKind::ObjectPattern(obj_pat) => {
           if let Some(obj_pat) = &obj_pat.rest {
-            queue.push(&obj_pat.argument.kind);
+            stack.push(&obj_pat.argument.kind);
           }
-          queue.extend(obj_pat.properties.iter().map(|prop| &prop.value.kind).rev());
+          stack.extend(obj_pat.properties.iter().map(|prop| &prop.value.kind).rev());
         }
         //
         ast::BindingPatternKind::AssignmentPattern(assign_pat) => {
-          queue.push(&assign_pat.left.kind);
+          stack.push(&assign_pat.left.kind);
         }
       };
     }

Original file line number	Diff line number	Diff line change
`@@ -15,25 +15,25 @@ pub trait BindingPatternExt<'ast> {`
`15`	`15`
`16`	`16`	`impl<'ast> BindingPatternExt<'ast> for ast::BindingPattern<'ast> {`
`17`	`17`	`fn binding_identifiers(&self) -> smallvec::SmallVec<[&Box<ast::BindingIdentifier<'ast>>; 1]> {`
`18`		`- let mut queue = vec![&self.kind];`
	`18`	`+ let mut stack = vec![&self.kind];`
`19`	`19`	`let mut ret = SmallVec::default();`
`20`		`- while let Some(binding_kind) = queue.pop() {`
	`20`	`+ while let Some(binding_kind) = stack.pop() {`
`21`	`21`	`match binding_kind {`
`22`	`22`	`ast::BindingPatternKind::BindingIdentifier(id) => {`
`23`	`23`	`ret.push(id);`
`24`	`24`	`}`
`25`	`25`	`ast::BindingPatternKind::ArrayPattern(arr_pat) => {`
`26`		`- queue.extend(arr_pat.elements.iter().flatten().map(\|pat\| &pat.kind).rev());`
	`26`	`+ stack.extend(arr_pat.elements.iter().flatten().map(\|pat\| &pat.kind).rev());`
`27`	`27`	`}`
`28`	`28`	`ast::BindingPatternKind::ObjectPattern(obj_pat) => {`
`29`	`29`	`if let Some(obj_pat) = &obj_pat.rest {`
`30`		`- queue.push(&obj_pat.argument.kind);`
	`30`	`+ stack.push(&obj_pat.argument.kind);`
`31`	`31`	`}`
`32`		`- queue.extend(obj_pat.properties.iter().map(\|prop\| &prop.value.kind).rev());`
	`32`	`+ stack.extend(obj_pat.properties.iter().map(\|prop\| &prop.value.kind).rev());`
`33`	`33`	`}`
`34`	`34`	`//`
`35`	`35`	`ast::BindingPatternKind::AssignmentPattern(assign_pat) => {`
`36`		`- queue.push(&assign_pat.left.kind);`
	`36`	`+ stack.push(&assign_pat.left.kind);`
`37`	`37`	`}`
`38`	`38`	`};`
`39`	`39`	`}`