chore(deps): upgrade oxc to 0.138.0 and migrate to per-type AST construction#10018
Merged
Conversation
…ruction oxc 0.138 (oxc#23043) replaced the AstBuilder construction methods with per-type constructors. This bumps oxc and migrates all AST construction to the new API so the deprecated builder methods are no longer used. - Bump oxc crates 0.137.0 -> 0.138.0 (cargo + npm); phf 0.13 -> 0.14 (macros feature) - Fix 0.138 breaking changes: arena methods (take_in/new_in/...) now take `&impl GetAllocator`; `ConstantEvaluationCtx` gains `GetAstBuilder` + `GetAllocator` supertraits in place of its `ast()` method - Migrate ~613 construction sites to per-type constructors (`Foo::new`/`Foo::boxed`, `oxc::allocator::Vec::*_in`, `Str::from_str_in`) - `AstFactory` now implements `GetAstBuilder` + `GetAllocator` and drops its `Deref` to `AstBuilder`; `make_*` method bodies pass `self` - Regenerate embedded runtime helpers; update internal-docs/ast-construction
✅ Deploy Preview for rolldown-rs canceled.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
sapphi-red
approved these changes
Jun 30, 2026
sapphi-red
left a comment
Member
There was a problem hiding this comment.
(I only checked the files that is marked as the code owner)
h-a-n-a
approved these changes
Jun 30, 2026
IWANABETHATGUY
approved these changes
Jun 30, 2026
Collaborator
|
Out of interest, did you use the codemod? Or by hand (or LLM's hand)? |
Member
Author
I used claude code. Using the skill upgrade-oxc first and then I told cc to migrate the new AST construction. |
Merged
shulaoda
added a commit
that referenced
this pull request
Jul 1, 2026
## [1.1.4] - 2026-07-01 ### 🚀 Features - disable `experimental.lazyBarrel` by default (#10071) by @shulaoda ### 🐛 Bug Fixes - dev: disable lazy barrel in dev mode (#10060) by @shulaoda - generate: keep full JSON interface under preserveModules namespa… (#10056) by @IWANABETHATGUY - check finalize_other_specifiers in its own Debug attribute (#10032) by @shulaoda - serialize the KeepAssign unused minify option as "keep_assign" (#10031) by @shulaoda - keep fragments after the newline fragment in MagicString::last_line (#10023) by @shulaoda - generate: undeclared JSON named exports under preserveModules (#10020) (#10027) by @IWANABETHATGUY - deconflict: rename CJS-wrapped locals that shadow chunk-root bindings (#9921) by @IWANABETHATGUY - rolldown: keep entry facade when a shared chunk holds another entry's module (#9997) by @hyf0 - treeshake: also bail JSON default split when the object escapes (#9996) by @IWANABETHATGUY - don't classify await in a strict-mode function as top-level await (#9987) by @shulaoda - avoid spurious leading newline in addon hooks (banner/footer/intro/outro) (#9989) by @shulaoda - handle JSON default mutation bailouts (#9972) by @TheAlexLichter - plugin: make lazy hook metadata enumerable (#9991) by @TheAlexLichter - dev: make init errors in lazy-compiled modules catchable (#9981) by @h-a-n-a - treeshake: keep computed-key side effects on namespace member access (#9986) by @shulaoda - binding: validate replace plugin delimiters length instead of panicking (#9984) by @shulaoda - reconstruct nested rest patterns in into_expression (#9980) by @IWANABETHATGUY - reconstruct rest patterns as spread in into_expression (#9976) by @shulaoda - preserve export keyword on multi-declarator exports under keepNames (#9974) by @shulaoda - deterministically keep the shortest name for deduplicated assets (#9948) by @x1024 - treeshake: apply @__NO_SIDE_EFFECTS__ to cross-chunk namespace calls (#9960) by @IWANABETHATGUY ### 🚜 Refactor - drop redundant program scope enter/leave in finalizer (#10049) by @shulaoda - deconflict: extract collect_chunk_scope_captured_names (#10006) by @IWANABETHATGUY - unify pre-scan multi-declarator split into one decision site (#9982) by @IWANABETHATGUY - common: return bool from SymbolRef::is_not_reassigned (#9962) by @IWANABETHATGUY ### 📚 Documentation - rolldown: remove outdated comment for removing parenthesized expression (#10062) by @Dunqing - use GitHub-flavored alert for Etiquette note in contribution guide (#10012) by @IWANABETHATGUY - replace: explain the delimiters left and right boundaries (#9985) by @shulaoda - ast-mutation: remove stale Address Use section after pre-scan refactor (#9983) by @IWANABETHATGUY - remove fathom (#9968) by @mdong1909 - contribution-guide: code-format main branch references (#9966) by @IWANABETHATGUY - contribution-guide: fix stale REPL note and tidy wording (#9957) by @hyf0 - contribution-guide: clarify when to discuss before opening a PR (#9955) by @hyf0 ### ⚡ Performance - disable preserve_parens across all parse paths (#10057) by @Dunqing - common: inline declared_symbols with SmallVec (#9920) by @IWANABETHATGUY - common: pack TaggedSymbolRef into 8 bytes (#9919) by @IWANABETHATGUY - sourcemap: skip newline scan on the no-sourcemap join fast path (#9936) by @Boshen ### 🧪 Testing - dev: error in lazy module should be catchable (#9975) by @sapphi-red - dev: reject unknown lazy compile modules (#9969) by @sapphi-red ### ⚙️ Miscellaneous Tasks - deps: update actions/cache action to v6 (#10001) by @renovate[bot] - trigger vite ecosystem-ci from PR comments (#10058) by @shulaoda - deps: update napi to v3.10.0 (#10063) by @renovate[bot] - remove unused From impl for RolldownLabelSpan (#10055) by @shulaoda - remove dead Diagnostic::with_kind method (#10054) by @shulaoda - remove unused StatementExt methods (#10053) by @shulaoda - remove unused ExpressionExt methods (#10052) by @shulaoda - remove commented-out re_export_all_names field (#10051) by @shulaoda - deps: update pnpm to v11.9.0 (#10047) by @renovate[bot] - remove the unused BindingGenerateHmrPatchReturn napi type (#10034) by @shulaoda - remove the dead inline_entry_chunk_wrapping scaffolding (#10037) by @shulaoda - deps: bump oxc_resolver to 11.22.0 (#10045) by @Boshen - remove never-constructed MatchImportKind::_Ignore variant (#10041) by @shulaoda - remove the unused ScheduledBuild napi struct (#10033) by @shulaoda - remove dead compute_hmr_update_single method (#10040) by @shulaoda - drop the redundant visited.insert in manual code splitting (#10038) by @shulaoda - remove the dead output_assets vector in render_chunk_to_assets (#10036) by @shulaoda - remove the unused From<String>/Display impls for BindingLogLevel (#10035) by @shulaoda - deps: upgrade oxc to 0.138.0 and migrate to per-type AST construction (#10018) by @shulaoda - deps: update rust crates (#9911) by @renovate[bot] - deps: update test262 submodule for tests (#10016) by @rolldown-guard[bot] - deps: update github actions (#9999) by @renovate[bot] - deps: update npm packages (#10000) by @renovate[bot] ###◀️ Revert - "fix(plugin): make lazy hook metadata enumerable (#9991)" (#10005) by @shulaoda ### ❤️ New Contributors * @x1024 made their first contribution in [#9948](#9948) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Upgrades oxc
0.137.0→0.138.0and migrates all AST construction to oxc's new per-type constructor API.oxc 0.138 (oxc#23043) replaced the
AstBuilderconstruction methods (builder.alloc_foo(..),builder.expression_call(..),builder.vec(), ...) with per-type constructors that take the builder/allocator as the last argument. This PR bumps oxc and moves rolldown off the deprecated API so it no longer emits deprecation warnings.Changes
0.137.0→0.138.0(cargo + npm catalog);phf0.13→0.14with themacrosfeature (the previous build only gotphf_map!via feature unification through oxc's own phf 0.13, which is gone).take_in,take_in_box,ArenaVec::new_in,ArenaBox::new_in) now take&impl GetAllocator— call sites pass&handle.ConstantEvaluationCtxdropped itsast()method in favor ofGetAstBuilder+GetAllocatorsupertraits (ast_scanner/const_eval.rs).Foo::new(.., &ast_factory)/Foo::boxed(..),oxc::allocator::Vec::*_in,Str::from_str_in.AstFactorynow implementsGetAstBuilder+GetAllocatorand drops itsDereftoAstBuilder;make_*method bodies passself. This keeps construction funnelled through the singleAstFactorychokepoint, as described ininternal-docs/ast-construction.@oxc-project/runtimehelpers (version string only).internal-docs/ast-construction/implementation.mdto describe the new per-type API and the droppedDeref.For reviewers
builder.method(..)→Type::new_*(.., &handle)rewrite. The interesting part iscrates/rolldown_ecmascript_utils/src/ast_factory.rs(trait impls,Derefremoval,make_*bodies).Testing
just rollwas green (clippy--deny warnings+ full Rust/Node test suites, snapshots unchanged) before rebasing onto latestmain.main,cargo check --workspaceis clean (0 errors, 0 deprecation warnings).