backend/local: Ignore ENOTTY for fsync on Mac#4021
Merged
MichaelEischer merged 1 commit intorestic:masterfrom Nov 11, 2022
Merged
backend/local: Ignore ENOTTY for fsync on Mac#4021MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer merged 1 commit intorestic:masterfrom
Conversation
|
this PR works on my machine(s) with OSX Ventura and fixes the addressed problem. |
MichaelEischer
approved these changes
Nov 11, 2022
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM, except for the missing changelog entry. I'll port the change to the rest-server (see restic/rest-server#199 )
MichaelEischer
added a commit
to MichaelEischer/rest-server
that referenced
this pull request
Nov 11, 2022
This ignores several different combinations of errnos which are returned if the storage destination is not able to fsync correctly. See also restic/restic#4021
7 tasks
Contributor
Author
|
Added the changelog entry. |
55dd422 to
348e966
Compare
Member
|
I've slightly tweaked the wording in the changelog. This errno seems to only be returned by macOS Ventura, see e.g. restic/rest-server#198 . |
Contributor
Author
|
Good. Wasn't my best writing ever. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Catches ENOTTY as an error from fsync to ignore, on the Mac.
Was the change previously discussed in an issue or on the forum?
Fixes #4016, I hope. Will add a changelog entry if it does.
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.