Merged
Conversation
wojas
reviewed
Nov 3, 2022
This ignores several different combinations of errnos which are returned if the storage destination is not able to fsync correctly. See also restic/restic#4021
ed3edf0 to
408dcab
Compare
Member
Author
|
I've replaced the implementation in the PR with the changes made for restic in restic/restic#4021 . The fsync handling is now largely copy & paste from restic, which should make it easier to maintain this error handling mess. |
wojas
approved these changes
Nov 14, 2022
Contributor
wojas
left a comment
There was a problem hiding this comment.
Keeping it the same as in restic sounds like a good idea.
|
For what it's worth, it works for me as I was having the errors. |
MichaelEischer
commented
Dec 16, 2022
Member
Author
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM. As nobody has complained about the warning message, I'll leave it as it is at the moment.
This was referenced May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
Storing a repository on a filesystem that does not support fsync is currently not possible. This PR syncs the ignored fsync errors from the restic backend to also allow storing a repository on these filesystems. However, this is not recommended as without fsync it is not possible to guarantee the integrity of uploaded data.
In addition, macOS Ventura seems to have introduced an additional error code, see #198.
Was the change discussed in an issue or in the forum before?
Fixes #198.
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits