Less automatic `build.rs` shenanigans by emilk · Pull Request #3814 · rerun-io/rerun

emilk · 2023-10-11T15:24:58Z

Part of Fix unnecessary rebuilds by updating to maturin 1.3.1 #3266

What

`rust-analyzer` will no longer run codegen

…if you configure rust-analyzer to use --all-features, which you should, and which we do in .vscode/settings.json

Same is true for stuff like bacon too.

No build-time and git branch/commit for local developers

I've removed the build-time and git branch/commit from:

rerun --version
Viewer Rerun Menu -> About
analytics

for local developers (that means you), who has cloned our repository.

This is to save us from annoying re-builds using complex detection code.

No build-time and git branch/commit for crate users

Users of our crates (i.e. users who put rerun in their Cargo.toml or build rerun using cargo install rerun) will also no longer see the build-time and git branch/commit in these places. Previously we would try to get the git branch/commit hash for whatever folder they happened to be in (😬 ), which was not a great idea. So that's a bug fix.

The build time is a bit sadder to let go, but it was always unreliable: if you ran cargo update for instance, the build time would not update even if the rerun crate was being rebuilt. So instead of showing an unreliable built-time, I think it is better to just remove it.

Checklist

I have read and agree to Contributor Guide and the Code of Conduct
I've included a screenshot or gif (if applicable)
I have tested demo.rerun.io (if applicable)
The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

emilk · 2023-10-11T15:25:23Z

crates/re_build_tools/src/git.rs

@@ -0,0 +1,65 @@
+//! # Situations to consider regarding git


This is old code that has moved to its own file

emilk · 2023-10-11T15:26:04Z

crates/re_build_tools/src/lib.rs

+const EXPORT_BUILD_TIME_FOR_DEVELOPERS: bool = false;
+
+/// Should we export the current git hash/branch for developers in the workspace?
+///
+/// It will be visible in analytics, in the viewer's about-menu, and with `rerun --version`.
+///
+/// To do so accurately may incur unnecessary recompiles, so only turn this on if you really need it.
+const EXPORT_GIT_FOR_DEVELOPERS: bool = false;


I decided not to make these into environment variables right now. We can very easily do so now if we change our minds.

Wumpf

tradeoffs make sense to me. Good step forward to saner builds! Haven't tried it locally yet. Will stay in the lookout for spurious rebuilds etc.!

Wumpf · 2023-10-11T16:10:09Z

crates/re_build_info/src/build_info.rs

+        if !datetime.is_empty() {
+            write!(f, ", built {datetime}")?;
+        }


wouldn't it be more helpful to write something like built <unknown>?

Would it? Maybe "built at an unknown time", but then we could also add "and at an unknown place"

This is the output you get from rerun --version btw

crates/re_types/Cargo.toml

crates/re_types/build.rs

@rustbasic

### What This is so we can test things out before the next release, and also get in some new egui features for the plot aggregator and drag-and-drop. * Closes #4716 * Closes #4794 ### TODO * [x] Fix hovering ListItems in blueprint panel ### wgpu changelog https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md#v0190-2024-01-17 ### relevant egui changelog (so far) #### eframe * Keep `ViewportInfo::maximized` and `minimized` up-to-date on Windows [#3831](emilk/egui#3831) (thanks [@rustbasic](https://github.com/rustbasic)!) * Update wgpu to 0.19 [#3824](emilk/egui#3824) * Fix: handle `IconData::default()` without crashing [#3842](emilk/egui#3842) #### egui_extras * Fix unwraps in SVG scaling [#3826](emilk/egui#3826) (thanks [@amPerl](https://github.com/amPerl)!) * Update to ehttp 0.4 [#3834](emilk/egui#3834) #### egui_plot * Make `egui_plot::PlotMemory` public [#3871](emilk/egui#3871) #### egui * Selectable text in Labels [#3814](emilk/egui#3814) * `ComboBox`: add builder method for height [#3001](emilk/egui#3001) (thanks [@hinto-janai](https://github.com/hinto-janai)!) * Add keys `?`, `/`, `|` [#3820](emilk/egui#3820) * Fix clickable widgets blocking scrolling on touch screens [#3815](emilk/egui#3815) (thanks [@lucasmerlin](https://github.com/lucasmerlin)!) * Fix `stable_dt` [#3832](emilk/egui#3832) * Bug Fix : `Response::is_pointer_button_down_on` is now false the frame the button is released [#3833](emilk/egui#3833) (thanks [@rustbasic](https://github.com/rustbasic)!) * Use runtime knowledge of OS for OS-specific text editing [#3840](emilk/egui#3840) * Refactor: move text selection logic to own module [#3843](emilk/egui#3843) * Fix: dragging to above/below a `TextEdit` or `Label` will select text to begin/end [#3858](emilk/egui#3858) * Add `Response::contains_pointer` [#3859](emilk/egui#3859) * Always set `response.hovered` to false when dragging another widget [#3860](emilk/egui#3860) * Add `Align2::anchor_size` [#3863](emilk/egui#3863) * Add `Context::debug_text` [#3864](emilk/egui#3864) #### epaint * Add `Align2::anchor_size` [#3863](emilk/egui#3863) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4885/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4885/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4885/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4885) - [Docs preview](https://rerun.io/preview/eb1bce846c3adb29b99d04018b002475994ad213/docs)  - [Examples preview](https://rerun.io/preview/eb1bce846c3adb29b99d04018b002475994ad213/examples)  - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Andreas Reich <r_andreas2@web.de>

emilk added 9 commits October 11, 2023 15:50

Refactor re_build_info

049825b

Improve about-menu UI slightly

32f364a

Don't export build-time and git branch for developers and users

f7bd0d3

Better naming

3f100fe

Explain the logic of checking for source_hash.txt

c0de8d3

Clarify the run-critertia of re_types/build.rs

0a4726d

Add caveat to the rebuild_if_crate_changed function

6d43c13

Better docs

cf12509

Make sure rust-analyzer doesn't run re_types/build.rs

589dd5b

emilk added 🧑‍💻 dev experience developer experience (excluding CI) include in changelog labels Oct 11, 2023

emilk commented Oct 11, 2023

View reviewed changes

fix typo

7af15a5

emilk marked this pull request as ready for review October 11, 2023 15:28

Wumpf self-requested a review October 11, 2023 16:08

fix doc-test

046cf76

Wumpf approved these changes Oct 11, 2023

View reviewed changes

Move the feature-based early-outing to should_run()

b6822d2

emilk merged commit f6cdc38 into main Oct 11, 2023

emilk deleted the emilk/build-rs-changes branch October 11, 2023 17:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Less automatic `build.rs` shenanigans#3814

Less automatic `build.rs` shenanigans#3814
emilk merged 12 commits intomainfrom
emilk/build-rs-changes

emilk commented Oct 11, 2023 •

edited by github-actions bot

Loading

Uh oh!

emilk Oct 11, 2023

Uh oh!

emilk Oct 11, 2023

Uh oh!

Wumpf left a comment

Uh oh!

Wumpf Oct 11, 2023

Uh oh!

emilk Oct 11, 2023 •

edited

Loading

Uh oh!

emilk Oct 11, 2023

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

emilk commented Oct 11, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

rust-analyzer will no longer run codegen

No build-time and git branch/commit for local developers

No build-time and git branch/commit for crate users

Checklist

Uh oh!

emilk Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

emilk Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

Wumpf left a comment

Choose a reason for hiding this comment

Uh oh!

Wumpf Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

emilk Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emilk Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

emilk commented Oct 11, 2023 •

edited by github-actions bot

Loading

`rust-analyzer` will no longer run codegen

emilk Oct 11, 2023 •

edited

Loading