Update to wgpu 0.19 and latest egui trunk#4885
Merged
Conversation
Contributor
Size changes
|
abey79
approved these changes
Jan 23, 2024
Member
abey79
left a comment
There was a problem hiding this comment.
UI part looks good to me 👍🏻 (I haven't checked the renderer part.)
emilk
commented
Jan 23, 2024
| "--target-dir", | ||
| target_wasm_dir.as_str(), | ||
| "--no-default-features", | ||
| "--features=analytics", |
Member
There was a problem hiding this comment.
no, if you look closely this moved in from the if/else further down - both branches enabled the analytics feature
emilk
commented
Jan 23, 2024
emilk
commented
Jan 23, 2024
Wumpf
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This is so we can test things out before the next release, and also get in some new egui features for the plot aggregator and drag-and-drop.
TODO
wgpu changelog
https://github.com/gfx-rs/wgpu/blob/trunk/CHANGELOG.md#v0190-2024-01-17
relevant egui changelog (so far)
eframe
ViewportInfo::maximizedandminimizedup-to-date on Windows #3831 (thanks @rustbasic!)IconData::default()without crashing #3842egui_extras
egui_plot
egui_plot::PlotMemorypublic #3871egui
ComboBox: add builder method for height #3001 (thanks @hinto-janai!)?,/,|#3820stable_dt#3832Response::is_pointer_button_down_onis now false the frame the button is released #3833 (thanks @rustbasic!)TextEditorLabelwill select text to begin/end #3858Response::contains_pointer#3859response.hoveredto false when dragging another widget #3860Align2::anchor_size#3863Context::debug_text#3864epaint
Align2::anchor_size#3863Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io