gut(ui): strip residual skills stubs from shared UI files#2245
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 10, 2026
Merged
gut(ui): strip residual skills stubs from shared UI files#2245alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
Remove dead skills-related code left after PR #2240 gutted the skills UI subsystem: 6 orphaned skill handler method types from AppViewState, and the never-populated debugModels state field + its "Models" card in the debug view. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 24, 2026
alexey-pelykh
added a commit
that referenced
this pull request
Apr 24, 2026
…ead control after #2240/#2245 (#2520) The Tools tab in the Agents view rendered in the tab bar but its panel body was empty (placeholder `${nothing /* tools panel removed */}`). Clicking Tools showed a highlighted tab with no content — only user-visible dead control remaining from the post-#2336 audit sweep. Changes: - ui/src/ui/views/agents.ts: drop "tools" from `AgentsPanel` type union; delete `{ id: "tools", label: "Tools" }` tab entry; delete empty placeholder. - ui/src/ui/app.ts, app-settings.ts, app-view-state.ts: narrow each `agentsPanel` literal union to drop "tools" (the only consumer was the deleted tab). - ui/src/ui/app-render.ts: delete two now-impossible `panel === "tools"` blocks that lazy-loaded the tools catalog on tab activation. Eager `loadToolsCatalog` callers (gateway connect, settings apply, refresh handler) preserved — `toolsCatalog*` state is still live and asserted by the smoke suite. Out-of-scope (deferred): orphan `onToolsProfileChange` / `onToolsOverridesChange` props/handlers in `views/agents.ts` and `app-render.ts` — distinct dead-code pattern from the visible tab, warrants its own gut wave. `"skills"` literal in the type union also preserved (no consumer, but AC silent). AC verification: - `grep -rn '"tools"' ui/src/ui/views/agents.ts` → no matches - `grep -rn 'id: "tools"' ui/src/` → no matches - `pnpm check` green (oxfmt, tsgo, oxlint, fork-integrity gates) - `pnpm test` green (7014 + 288 tests) - `pnpm test:ui:smoke` green (12 tests, browser-mode Chromium) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks
alexey-pelykh
added a commit
that referenced
this pull request
Apr 24, 2026
…ead control after #2240/#2245 (#2520) (#2533) The Tools tab in the Agents view rendered in the tab bar but its panel body was empty (placeholder `${nothing /* tools panel removed */}`). Clicking Tools showed a highlighted tab with no content — only user-visible dead control remaining from the post-#2336 audit sweep. Changes: - ui/src/ui/views/agents.ts: drop "tools" from `AgentsPanel` type union; delete `{ id: "tools", label: "Tools" }` tab entry; delete empty placeholder. - ui/src/ui/app.ts, app-settings.ts, app-view-state.ts: narrow each `agentsPanel` literal union to drop "tools" (the only consumer was the deleted tab). - ui/src/ui/app-render.ts: delete two now-impossible `panel === "tools"` blocks that lazy-loaded the tools catalog on tab activation. Eager `loadToolsCatalog` callers (gateway connect, settings apply, refresh handler) preserved — `toolsCatalog*` state is still live and asserted by the smoke suite. Out-of-scope (deferred): orphan `onToolsProfileChange` / `onToolsOverridesChange` props/handlers in `views/agents.ts` and `app-render.ts` — distinct dead-code pattern from the visible tab, warrants its own gut wave. `"skills"` literal in the type union also preserved (no consumer, but AC silent). AC verification: - `grep -rn '"tools"' ui/src/ui/views/agents.ts` → no matches - `grep -rn 'id: "tools"' ui/src/` → no matches - `pnpm check` green (oxfmt, tsgo, oxlint, fork-integrity gates) - `pnpm test` green (7014 + 288 tests) - `pnpm test:ui:smoke` green (12 tests, browser-mode Chromium) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
alexey-pelykh
added a commit
that referenced
this pull request
Apr 24, 2026
sweep Shadow fields outlived the skills UI code tree after #2240/#2245 gutted it — no readers remain for any of: - `AgentsPanel` / `agentsPanel` union `"skills"` member - `agentSkills{Loading,Error,Report,AgentId}` view-state fields - `skillsReport` in the host-interface intersection - `SkillStatusReport` type + its import - `tabs.skills` + `subtitles.skills` i18n entries across all 6 locales Type-narrowing deletions only. Smoke suite's host-interface-field assertions auto-update when `AppViewState` is narrowed — validates the contract stays coherent post-deletion. (#2521)
4 tasks
alexey-pelykh
added a commit
that referenced
this pull request
Apr 24, 2026
sweep (#2536) Shadow fields outlived the skills UI code tree after #2240/#2245 gutted it — no readers remain for any of: - `AgentsPanel` / `agentsPanel` union `"skills"` member - `agentSkills{Loading,Error,Report,AgentId}` view-state fields - `skillsReport` in the host-interface intersection - `SkillStatusReport` type + its import - `tabs.skills` + `subtitles.skills` i18n entries across all 6 locales Type-narrowing deletions only. Smoke suite's host-interface-field assertions auto-update when `AppViewState` is narrowed — validates the contract stays coherent post-deletion. (#2521)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2193.
AppViewState(handleInstallSkill,handleUpdateSkill,handleToggleSkillEnabled,handleUpdateSkillEdit,handleSaveSkillApiKey,handleLoadSkills) — dead since the skills controllers were deleted in gut(ui): remove dead skills UI code tree #2240debugModelsstate field fromAppViewState,RemoteClawApp, and the render prop pass-through, plus the permanently-empty "Models" card from the debug viewTest plan
pnpm tsgo— no new type errors in modified filespnpm lint— 0 warnings, 0 errorspnpm format— all files formattedpnpm test— 694 test files pass (5949 tests), 0 failures🤖 Generated with Claude Code