Problem
The skills UI subsystem was gutted — 5 controller/view files deleted — but 4 shared UI files still contain skills-related state fields, types, and rendering code that reference the deleted controllers. This is inert dead code (no runtime effect since the controllers are gone), but it adds maintenance burden and confusion.
Files
| File |
Skills refs |
What remains |
ui/src/ui/app-view-state.ts |
9 |
skillsLoading, skillsReport, skillsError, skillsFilter, skillEdits, skillMessages, skillsBusyKey state fields + SkillMessage stub type |
ui/src/ui/app-render.ts |
27 |
Skills-related rendering code, imports, props passing |
ui/src/ui/app.ts |
9 |
Skills @state() fields, debugModels |
ui/src/ui/types.ts |
2 |
Skills-related type exports |
Why not fixed in PR #2191
These files were introduced by B3 sync (not B4). Restoring them from pre-B3 causes 42+ cascading type errors because surrounding code (cron, chat, app-gateway) was updated in B3/B4 to use APIs that the pre-B3 versions don't have. Fixing those cascading errors requires adapting the pre-B3 files to current APIs while simultaneously stripping skills code — a surgical pass beyond the scope of the regression remediation.
Approach
For each file: start from current HEAD, remove only skills-related code (fields, imports, types, rendering blocks). Fix cascading type errors in consumers.
Priority
Low — dead code, no runtime impact. But should be done before the next feature development cycle touches these files.
Problem
The skills UI subsystem was gutted — 5 controller/view files deleted — but 4 shared UI files still contain skills-related state fields, types, and rendering code that reference the deleted controllers. This is inert dead code (no runtime effect since the controllers are gone), but it adds maintenance burden and confusion.
Files
ui/src/ui/app-view-state.tsskillsLoading,skillsReport,skillsError,skillsFilter,skillEdits,skillMessages,skillsBusyKeystate fields +SkillMessagestub typeui/src/ui/app-render.tsui/src/ui/app.ts@state()fields,debugModelsui/src/ui/types.tsWhy not fixed in PR #2191
These files were introduced by B3 sync (not B4). Restoring them from pre-B3 causes 42+ cascading type errors because surrounding code (cron, chat, app-gateway) was updated in B3/B4 to use APIs that the pre-B3 versions don't have. Fixing those cascading errors requires adapting the pre-B3 files to current APIs while simultaneously stripping skills code — a surgical pass beyond the scope of the regression remediation.
Approach
For each file: start from current HEAD, remove only skills-related code (fields, imports, types, rendering blocks). Fix cascading type errors in consumers.
Priority
Low — dead code, no runtime impact. But should be done before the next feature development cycle touches these files.