gut(ui): remove dead Tools tab from Agents view (#2520)#2533
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 24, 2026
Merged
gut(ui): remove dead Tools tab from Agents view (#2520)#2533alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
…ead control after #2240/#2245 (#2520) The Tools tab in the Agents view rendered in the tab bar but its panel body was empty (placeholder `${nothing /* tools panel removed */}`). Clicking Tools showed a highlighted tab with no content — only user-visible dead control remaining from the post-#2336 audit sweep. Changes: - ui/src/ui/views/agents.ts: drop "tools" from `AgentsPanel` type union; delete `{ id: "tools", label: "Tools" }` tab entry; delete empty placeholder. - ui/src/ui/app.ts, app-settings.ts, app-view-state.ts: narrow each `agentsPanel` literal union to drop "tools" (the only consumer was the deleted tab). - ui/src/ui/app-render.ts: delete two now-impossible `panel === "tools"` blocks that lazy-loaded the tools catalog on tab activation. Eager `loadToolsCatalog` callers (gateway connect, settings apply, refresh handler) preserved — `toolsCatalog*` state is still live and asserted by the smoke suite. Out-of-scope (deferred): orphan `onToolsProfileChange` / `onToolsOverridesChange` props/handlers in `views/agents.ts` and `app-render.ts` — distinct dead-code pattern from the visible tab, warrants its own gut wave. `"skills"` literal in the type union also preserved (no consumer, but AC silent). AC verification: - `grep -rn '"tools"' ui/src/ui/views/agents.ts` → no matches - `grep -rn 'id: "tools"' ui/src/` → no matches - `pnpm check` green (oxfmt, tsgo, oxlint, fork-integrity gates) - `pnpm test` green (7014 + 288 tests) - `pnpm test:ui:smoke` green (12 tests, browser-mode Chromium) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Tools tab from the Agents view — the only user-visible dead control remaining from the post-#2336 audit. The panel body was already gutted by #2240 / #2245; only the tab button itself stayed behind, rendering empty when clicked.
Closes #2520.
Changes (5 files, +4/-12)
ui/src/ui/views/agents.ts: drop"tools"fromAgentsPaneltype union, delete{ id: "tools", label: "Tools" }tab entry, delete the${nothing /* tools panel removed */}placeholder.ui/src/ui/app.ts,app-settings.ts,app-view-state.ts: narrow eachagentsPanelliteral union to drop"tools".ui/src/ui/app-render.ts: delete two now-impossiblepanel === "tools"blocks that lazy-loaded the tools catalog on tab activation.Out of scope (deferred)
onToolsProfileChange/onToolsOverridesChangeprops/handlers inviews/agents.tsandapp-render.ts— distinct dead-code pattern from the visible tab; warrants its own gut wave."skills"literal inAgentsPaneltype union — no consumer, but AC silent.Why this is safe
loadToolsCatalogandtoolsCatalog*host state remain live via the gateway connect path (app-gateway.ts:216), settings apply path (app-settings.ts:213), and the refresh handler (app-render.ts:572).app.smoke.test.ts:64-66asserts thetoolsCatalog*host fields exist — those fields are NOT removed.Test plan
grep -rn '"tools"' ui/src/ui/views/agents.tsreturns no matchesgrep -rn 'id: "tools"' ui/src/returns no matchespnpm checkgreen (oxfmt, tsgo, oxlint, no-random-messaging, no-remoteclaw-ai, css-class-drift)pnpm testgreen (7,302 tests)pnpm test:ui:smokegreen (12 tests, browser-mode Chromium)agents.ts:267-272= Overview / Files / Channels / Cron Jobs🤖 Generated with Claude Code