[DeadCode] Remove property comment same line on RemoveUnusedPrivatePropertyRector#3547
[DeadCode] Remove property comment same line on RemoveUnusedPrivatePropertyRector#3547TomasVotruba merged 4 commits intomainfrom
Conversation
|
@staabm this is a quick solution, the general solution probably on the |
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
@staabm another general solution is probably create a dedicated rector rule to verify the Stmt just removed with next is Nop in the same line, eg: that will work on usage on other rule as well :) |
|
Thanks for working on it. I can't tell which works best for rector. I have no experience with Nop AST nodes either. |
|
I will create alternative PR for it 👍 |
|
Checking stmt just removed in loop of StmtsAwareInterface probably make memory hog as it will compare object in array, so probably not best solution. |
…opertyRector (#3547) Co-authored-by: Markus Staab <markus.staab@redaxo.de> Co-authored-by: GitHub Action <actions@github.com>
Closes #3539