[DeadCode] Alternative: add NopVisitor for removing Nop same line previous stmt just removed#3548
Closed
samsonasik wants to merge 7 commits intomainfrom
Closed
[DeadCode] Alternative: add NopVisitor for removing Nop same line previous stmt just removed#3548samsonasik wants to merge 7 commits intomainfrom
samsonasik wants to merge 7 commits intomainfrom
Conversation
Member
|
Go for merge when ready 👍 |
Member
Author
|
@TomasVotruba I am thinking that it may be slow down the process refactor as it require another loop after node refactored for usage of new visitor to loop node stmts just to clearance the It also rely on
I think we can have this case by case for it, so closing it for now. |
Member
|
I see, makes sense 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative of PR:
Closes #3547
Closes #3539