Added failling RemoveUnusedPrivatePropertyRector test-case#3539
Closed
staabm wants to merge 1 commit intorectorphp:mainfrom
Closed
Added failling RemoveUnusedPrivatePropertyRector test-case#3539staabm wants to merge 1 commit intorectorphp:mainfrom
staabm wants to merge 1 commit intorectorphp:mainfrom
Conversation
samsonasik
reviewed
Mar 30, 2023
Member
samsonasik
left a comment
There was a problem hiding this comment.
comment is belong to next stmt, so the change is expected, if it need to be resolved, it may need to be resolved in php-parser itself.
Member
|
It possibly can be tweaked by check there is a |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rector moved a comment related to a propery beeing removed to a different property.
I think the comment should also be removed when on the same line as the property beeing removed
from https://getrector.com/demo/0772a67b-072b-47c0-b268-db16502bca38