fix(mdxish): add missing toMarkdown extension for MDX expressions in stripComments#1347
Merged
maximilianfalco merged 5 commits intonextfrom Feb 18, 2026
Merged
fix(mdxish): add missing toMarkdown extension for MDX expressions in stripComments#1347maximilianfalco merged 5 commits intonextfrom
maximilianfalco merged 5 commits intonextfrom
Conversation
Contributor
|
Code change looks good, slightly more tests would be good 🙏 |
- opted to use it.each here to reduce diff size
eaglethrost
reviewed
Feb 18, 2026
eaglethrost
reviewed
Feb 18, 2026
maximilianfalco
commented
Feb 18, 2026
| left.position && | ||
| right.position && | ||
| right.position.start.line - left.position.end.line === 1; // Are the blocks on adjacent lines? | ||
| left.position && right.position && right.position.start.line - left.position.end.line === 1; // Are the blocks on adjacent lines? |
Contributor
Author
There was a problem hiding this comment.
forgot to mention, this got changed due to lint
rafegoldberg
pushed a commit
that referenced
this pull request
Feb 18, 2026
## Version 13.2.0 ### ✨ New & Improved * **demo:** add a markdown view in demo app when stripComments is on ([#1348](#1348)) ([a7a8726](a7a8726)) * extend regex to cover more cases ([#1338](#1338)) ([3e8efc8](3e8efc8)) ### 🛠 Fixes & Updates * **mdxish:** add missing toMarkdown extension for MDX expressions in stripComments ([#1347](#1347)) ([02ddfce](02ddfce)) * properly escape escaped chars when expression parsing fails ([#1325](#1325)) ([136f7af](136f7af)) * **mdxish:** tone down empty line addition preprocessing after html blocks ([#1344](#1344)) ([e4e7362](e4e7362)), closes [#1336](#1336) <!--SKIP CI-->
Contributor
|
This PR was released!🚀 Changes included in v13.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Note
This fixes CX2940
The
stripCommentsfunction in mdxish mode was registeringfromMarkdownExtensionsfor MDX expressions but nottoMarkdownExtensions. This meant expressions like{user.email}were parsed correctly but lost during serialization back to markdown.This adds
mdxExpressionToMarkdown()to thetoMarkdownExtensionsdata so non-comment MDX expressions are preserved through the round-trip.📷 Demo
Screen.Recording.2026-02-18.at.15.45.33.mov
🧬 QA & Testing