Skip to content

fix: properly escape escaped chars when expression parsing fails#1325

Merged
kevinports merged 3 commits intonextfrom
falco/fix-escape-backslash-when-expression-parsing-fail
Feb 18, 2026
Merged

fix: properly escape escaped chars when expression parsing fails#1325
kevinports merged 3 commits intonextfrom
falco/fix-escape-backslash-when-expression-parsing-fail

Conversation

@maximilianfalco
Copy link
Copy Markdown
Contributor

PR App Fix RM-XYZ

🧰 Changes

Fixes CX-2874

We saw an issue where if a regular text was wrapped in { ... } and it wasnt a valid expression (ie JSON) the MDX espression parser consumes the content as code instead of text which skips inline parsing. So stuff like \< isnt properly escaped to <.

The fix was to simply

🧬 QA & Testing

Try typing in something like:

{\<foo>}

with this fix, you now should not see the backslash any more since it is already treated as properly escaped.

Copy link
Copy Markdown
Contributor

@kevinports kevinports left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kevinports kevinports merged commit 136f7af into next Feb 18, 2026
11 checks passed
@kevinports kevinports deleted the falco/fix-escape-backslash-when-expression-parsing-fail branch February 18, 2026 19:48
rafegoldberg pushed a commit that referenced this pull request Feb 18, 2026
## Version 13.2.0
### ✨ New & Improved

* **demo:** add a markdown view in demo app when stripComments is on ([#1348](#1348)) ([a7a8726](a7a8726))
* extend regex to cover more cases ([#1338](#1338)) ([3e8efc8](3e8efc8))

### 🛠 Fixes & Updates

* **mdxish:** add missing toMarkdown extension for MDX expressions in stripComments ([#1347](#1347)) ([02ddfce](02ddfce))
* properly escape escaped chars when expression parsing fails ([#1325](#1325)) ([136f7af](136f7af))
* **mdxish:** tone down empty line addition preprocessing after html blocks ([#1344](#1344)) ([e4e7362](e4e7362)), closes [#1336](#1336)

<!--SKIP CI-->
@rafegoldberg
Copy link
Copy Markdown
Contributor

This PR was released!

🚀 Changes included in v13.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants