feat: extend regex to cover more cases#1338
Merged
maximilianfalco merged 1 commit intonextfrom Feb 18, 2026
Merged
Conversation
Contributor
|
Code change makes sense! Confirming, I noticed in the example you gave Screen.Recording.2026-02-16.at.8.14.29.pm.mov |
kevinports
approved these changes
Feb 17, 2026
Contributor
Author
@eaglethrost yea mentioned this in the PR desc, this should be an improvement compared to the legacy one |
rafegoldberg
pushed a commit
that referenced
this pull request
Feb 18, 2026
## Version 13.2.0 ### ✨ New & Improved * **demo:** add a markdown view in demo app when stripComments is on ([#1348](#1348)) ([a7a8726](a7a8726)) * extend regex to cover more cases ([#1338](#1338)) ([3e8efc8](3e8efc8)) ### 🛠 Fixes & Updates * **mdxish:** add missing toMarkdown extension for MDX expressions in stripComments ([#1347](#1347)) ([02ddfce](02ddfce)) * properly escape escaped chars when expression parsing fails ([#1325](#1325)) ([136f7af](136f7af)) * **mdxish:** tone down empty line addition preprocessing after html blocks ([#1344](#1344)) ([e4e7362](e4e7362)), closes [#1336](#1336) <!--SKIP CI-->
Contributor
|
This PR was released!🚀 Changes included in v13.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This fixes CX2834 (mentioned here to not trigger Linear bot).
Essentially our regex to normalize malformed emphasis syntaxes were not equipped well enough to handle having the
_and__WITHIN the text element itself. ie things like this were failing since it though the middle_was the endNote
this actually improves on the original legacy capabilities by allowing us to parse the
__bold syntax as wellImportant
we do not extend to also be the same for the
*syntax simply because the legacy engine didnt support that as well. goal of these malformed transformations was for parity with legacy🧬 QA & Testing
Stuff like
or even
should be considered one node and not split into two