Merged
Conversation
Contributor
Author
bdice
commented
Apr 3, 2024
| from multiprocessing import Process | ||
|
|
||
|
|
||
| def run_test_in_subprocess(func): |
Contributor
Author
There was a problem hiding this comment.
This file contains the relevant changes. See commit 60b8d7a.
rjzamora
approved these changes
Apr 4, 2024
Member
rjzamora
left a comment
There was a problem hiding this comment.
Thanks @bdice - Works for me locally when I remove the expected patch:
tests/test_patch.py::test_dask Process Process-1:
Traceback (most recent call last):
File "/datasets/rzamora/miniconda3/envs/cudf_2406/lib/python3.11/multiprocessing/process.py", line 314, in _bootstrap
self.run()
File "/datasets/rzamora/miniconda3/envs/cudf_2406/lib/python3.11/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/home/nfs/rzamora/workspace/cudf-24.06/rapids-dask-dependency/tests/test_patch.py", line 13, in redirect_stdout_stderr
func(*args, **kwargs)
File "/home/nfs/rzamora/workspace/cudf-24.06/rapids-dask-dependency/tests/test_patch.py", line 44, in test_dask
assert hasattr(dask, "_rapids_patched")
AssertionError: assert False
+ where False = hasattr(<module 'dask' (/datasets/rzamora/miniconda3/envs/cudf_2406/lib/python3.11/site-packages/dask/__init__.py)>, '_rapids_patched')
FAILED
Contributor
Author
vyasr
approved these changes
Apr 4, 2024
Contributor
|
Thanks Bradley! |
vyasr
pushed a commit
to vyasr/rapids-dask-dependency
that referenced
this pull request
Apr 4, 2024
Currently, the tests added in rapidsai#27 (backported to 24.04 in rapidsai#36) do not check the exit codes of their subprocesses. This means that failing tests are not caught. This PR fixes the test utilities to check the exit codes and print any stdout/stderr outputs.
raydouglass
pushed a commit
that referenced
this pull request
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the tests added in #27 (backported to 24.04 in #36) do not check the exit codes of their subprocesses. This means that failing tests are not caught. This PR fixes the test utilities to check the exit codes and print any stdout/stderr outputs.