Generalize patching to support vendoring#38
Merged
rjzamora merged 16 commits intorapidsai:branch-24.06from Apr 4, 2024
Merged
Conversation
…ors to work on empty directories.
rjzamora
reviewed
Apr 4, 2024
Member
rjzamora
left a comment
There was a problem hiding this comment.
Wow - This is impressive. I'm a bit scared of the complexity here, but I doubt there is a much simpler way to achieve what we need.
Member
|
I wonder if the following sequence of events make sense?
|
wence-
requested changes
Apr 4, 2024
wence-
left a comment
There was a problem hiding this comment.
I like this and have only one minor suggestion to restrict the scope of patching the vendored file.
Merged
bdice
reviewed
Apr 4, 2024
bdice
approved these changes
Apr 4, 2024
Contributor
bdice
left a comment
There was a problem hiding this comment.
The changes look good to me, now that the patch is applied only to the affected Python/Dask versions. (I have not verified that this passes locally.)
wence-
approved these changes
Apr 4, 2024
rjzamora
reviewed
Apr 4, 2024
rapids_dask_dependency/patches/dask/dataframe/__rdd_patch_accessor.py
Outdated
Show resolved
Hide resolved
…ssor.py Co-authored-by: Richard (Rick) Zamora <rzamora217@gmail.com>
Member
|
\merge |
Contributor
|
This PR was reverted via force push so that it can be merged via the bot instead (in #39). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a number of significant changes to the patching infrastructure:
patchesdirectory corresponding to a particular dask or distributed module.sys.moduleswith the real modules and therefore the loader will never be used for loading a patched version of the submodule.dask.dataframeimport error for Python 3.11.9 dask/dask#11035.