Backport patching (#27) to branch-24.04.#36
Closed
bdice wants to merge 1 commit intorapidsai:branch-24.04from
Closed
Backport patching (#27) to branch-24.04.#36bdice wants to merge 1 commit intorapidsai:branch-24.04from
bdice wants to merge 1 commit intorapidsai:branch-24.04from
Conversation
This PR adds the ability to monkey-patch imports of dask and distributed whenever those imports occur by simply installing rapids-dask-dependency. There's a tiny bit of scope creep here because this PR added real Python code to the repo for the first time, so I also added pre-commit hooks that in turn modified some unrelated files (only minimally, though). TODO: - [x] Update conda CI and packaging - [ ] Stress test extensively --------- Signed-off-by: Vyas Ramasubramani <vyasr@nvidia.com> Co-authored-by: Richard (Rick) Zamora <rzamora217@gmail.com>
Merged
vyasr
pushed a commit
that referenced
this pull request
Apr 4, 2024
vyasr
pushed a commit
to vyasr/rapids-dask-dependency
that referenced
this pull request
Apr 4, 2024
Currently, the tests added in rapidsai#27 (backported to 24.04 in rapidsai#36) do not check the exit codes of their subprocesses. This means that failing tests are not caught. This PR fixes the test utilities to check the exit codes and print any stdout/stderr outputs.
Contributor
Author
|
Closing in favor of #41. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #27 to branch-24.04.
This PR adds the ability to monkey-patch imports of dask and distributed
whenever those imports occur by simply installing
rapids-dask-dependency.
See #27 for more information.