benchmarks: avoid use of deprecated pandas API#290
Closed
grlee77 wants to merge 1 commit intorapidsai:branch-22.06from
Closed
benchmarks: avoid use of deprecated pandas API#290grlee77 wants to merge 1 commit intorapidsai:branch-22.06from
grlee77 wants to merge 1 commit intorapidsai:branch-22.06from
Conversation
The append method of DataFrame is deprecated since pandas 1.4.0 The recommendation is to use pandas.concat instead: https://pandas.pydata.org/docs/whatsnew/v1.4.0.html#whatsnew-140-deprecations-frame-series-append
jakirkham
approved these changes
Jun 4, 2022
Member
|
Is it alright if we move this to 22.08? |
Contributor
Author
|
Yes |
Contributor
Author
|
replaced by #339 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
This is an update of the previously-approved #290 from branch-22.06 to branch-22.08 Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - https://github.com/gbae - Gigon Bae (https://github.com/gigony) - https://github.com/jakirkham URL: #339
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
This PR expands the approach of #322 to the remaining `cucim.skimage` benchmarks as well This PR is built on top of a few other open benchmarking PRs, so please review and merge those first: (#322, #323, #290) Authors: - Gregory Lee (https://github.com/grlee77) - https://github.com/aasthajh Approvers: - https://github.com/jakirkham URL: #324
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
appendmethod ofDataFramewas deprecated in pandas 1.4.0.Here, we update to use
pandas.concatinstead (as recommended)