Skip to content

benchmarks: avoid use of deprecated pandas API#339

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.08from
grlee77:benchmarks-pandas-api-fix
Jul 26, 2022
Merged

benchmarks: avoid use of deprecated pandas API#339
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.08from
grlee77:benchmarks-pandas-api-fix

Conversation

@grlee77
Copy link
Copy Markdown
Contributor

@grlee77 grlee77 commented Jul 26, 2022

This is an update of the previously-approved #290 from branch-22.06 to branch-22.08

The append method of DataFrame is deprecated since pandas 1.4.0
The recommendation is to use pandas.concat instead:
https://pandas.pydata.org/docs/whatsnew/v1.4.0.html#whatsnew-140-deprecations-frame-series-append
@grlee77 grlee77 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 26, 2022
@grlee77 grlee77 added this to the v22.08.00 milestone Jul 26, 2022
@grlee77
Copy link
Copy Markdown
Contributor Author

grlee77 commented Jul 26, 2022

@gbae, you previously approved this in #290. Can you do that again here so we can merge this for 22.08?

Copy link
Copy Markdown
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. re-approving :)

@jakirkham
Copy link
Copy Markdown
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e5006ff into rapidsai:branch-22.08 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants