complete parametrization of cucim.skimage benchmarks#324
Merged
rapids-bot[bot] merged 25 commits intorapidsai:branch-22.08from Jul 28, 2022
Merged
complete parametrization of cucim.skimage benchmarks#324rapids-bot[bot] merged 25 commits intorapidsai:branch-22.08from
rapids-bot[bot] merged 25 commits intorapidsai:branch-22.08from
Conversation
The append method of DataFrame is deprecated since pandas 1.4.0 The recommendation is to use pandas.concat instead: https://pandas.pydata.org/docs/whatsnew/v1.4.0.html#whatsnew-140-deprecations-frame-series-append
Parametrizing filters benchmarks
Disabling CPU runs
avoid use of deprecated multichannel argument avoid use of deprecated selem argument
follows same approach taken previously for filters and features benchmarks
add benchmarking for normalized_mutual_information
Member
|
Looks like there are some conflicts here. Could you please resolve these @grlee77? 🙂 |
…refactor-2 [gpuci skip]
Contributor
Author
|
Fixed conflicts, added a |
Contributor
Author
Member
|
Would it make sense to close that PR then? |
Contributor
Author
|
Yeah, it is fine to close that one. |
Contributor
Author
|
Just fixed a few new conflicts here. Should be good to go now |
jakirkham
approved these changes
Jul 28, 2022
Member
|
@gpucibot merge |
Member
|
Thanks Greg! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the approach of #322 to the remaining
cucim.skimagebenchmarks as wellThis PR is built on top of a few other open benchmarking PRs, so please review and merge those first: (#322, #323, #290)