[phrase matching] Text index fixes#6730
Merged
generall merged 4 commits intoadd-phrase-match-variantfrom Jun 23, 2025
Merged
Conversation
coszio
commented
Jun 19, 2025
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
Contributor
Author
There was a problem hiding this comment.
This (with a few other diffs) sneaked back in after being moved in #6638, it is now in test_congruence.rs file
Comment on lines
-366
to
+373
| IndexSelector::RocksDb(IndexSelectorRocksDb { | ||
| db, | ||
| is_appendable: _, | ||
| }) => FieldIndexBuilder::FullTextIndex(FullTextIndex::builder_rocksdb( | ||
| Arc::clone(db), | ||
| config, | ||
| &field.to_string(), | ||
| )), | ||
| IndexSelector::RocksDb(IndexSelectorRocksDb { db, is_appendable }) => { | ||
| FieldIndexBuilder::FullTextIndex(FullTextIndex::builder_rocksdb( | ||
| Arc::clone(db), | ||
| config, | ||
| &field.to_string(), | ||
| *is_appendable, | ||
| )) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is where it was selecting an immutable index, but silently creating a mutable one
| token_to_posting: impl Fn(&TokenId) -> Option<PostingListView<'a, Positions>>, | ||
| ) -> bool { | ||
| let Some(mut posting_iterators): Option<Vec<_>> = phrase | ||
| .to_token_set() |
Contributor
Author
There was a problem hiding this comment.
Not deduplicating here was the main bug
timvisee
approved these changes
Jun 23, 2025
coszio
added a commit
that referenced
this pull request
Jun 24, 2025
* allow rocksdb-based immutable text index * fix repeated-token phrases * fmt * Update OpenAPI spec --------- Co-authored-by: timvisee <tim@visee.me>
coszio
added a commit
that referenced
this pull request
Jun 24, 2025
* add `"match": { "phrase": ... }` condition
* gen grpc and openapi
* [phrase matching] expose `phrase_matching` flag in rest and grpc (#6620)
* expose setting in rest and grpc
* phrase matching openapi test
* regen openapi
* [phrase matching] Text index fixes (#6730)
* allow rocksdb-based immutable text index
* fix repeated-token phrases
* fmt
* Update OpenAPI spec
---------
Co-authored-by: timvisee <tim@visee.me>
* add repeated word case in openapi test
* [phrase match | strict mode] Allow phrase condition when enabled in index (#6749)
* allow phrase filter when index is present
* prettier error message
* clippppppy
---------
Co-authored-by: timvisee <tim@visee.me>
generall
pushed a commit
that referenced
this pull request
Jul 17, 2025
* add `"match": { "phrase": ... }` condition
* gen grpc and openapi
* [phrase matching] expose `phrase_matching` flag in rest and grpc (#6620)
* expose setting in rest and grpc
* phrase matching openapi test
* regen openapi
* [phrase matching] Text index fixes (#6730)
* allow rocksdb-based immutable text index
* fix repeated-token phrases
* fmt
* Update OpenAPI spec
---------
Co-authored-by: timvisee <tim@visee.me>
* add repeated word case in openapi test
* [phrase match | strict mode] Allow phrase condition when enabled in index (#6749)
* allow phrase filter when index is present
* prettier error message
* clippppppy
---------
Co-authored-by: timvisee <tim@visee.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #6670.
Two fixes for text index: