[phrase match] Restructure full_text_index::inverted_index module#6638
Merged
[phrase match] Restructure full_text_index::inverted_index module#6638
full_text_index::inverted_index module#6638Conversation
7a1af3b to
2b9d2b4
Compare
42201d2 to
21303a2
Compare
2b9d2b4 to
ae56018
Compare
21303a2 to
b49774c
Compare
e7bfb15 to
8d7fcfb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Also, remove `old_mmap_postings` and `compressed_postings`
8d7fcfb to
e3fd633
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
approved these changes
Jun 12, 2025
Member
timvisee
left a comment
There was a problem hiding this comment.
Thanks!
Am I correct that there is no logic change in here. At least I didn't see any.
If not, let's merge! If there is, please let me know and I'll revisit that part again.
Contributor
Author
|
There's no logic changes here, correct |
generall
pushed a commit
that referenced
this pull request
Jul 17, 2025
…6638) * move all inverted indexes to one module Also, remove `old_mmap_postings` and `compressed_postings` * move congruence test into its own file * remove old de/serialize_tokenset functions
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #6493
Since more files and logic is being added to full-text-index, navigability was getting more complex. This PR aims to simplify it by:
old_mmap_postingsandcompressed_postingsmodules