[phrase match | strict mode] Allow phrase condition when enabled in index#6749
Merged
coszio merged 2 commits intoadd-phrase-match-variantfrom Jun 24, 2025
Merged
[phrase match | strict mode] Allow phrase condition when enabled in index#6749coszio merged 2 commits intoadd-phrase-match-variantfrom
coszio merged 2 commits intoadd-phrase-match-variantfrom
Conversation
coszio
commented
Jun 23, 2025
| pprof = { workspace = true } | ||
|
|
||
| [dependencies] | ||
| bitpacking = "0.9.2" |
Contributor
Author
There was a problem hiding this comment.
Additionally, removes bitpacking dep here
generall
reviewed
Jun 24, 2025
Member
generall
left a comment
There was a problem hiding this comment.
Would it be possible to change error text, so it would indicate that user needs to create text index with phrase flag in order to search with phrases?
Right now it only asks to create text index, while text index is already created
timvisee
approved these changes
Jun 24, 2025
134325b to
71e78a5
Compare
5366848 to
8e43065
Compare
Contributor
Author
|
@generall in 71e78a5 I have modified the Display impl to account for phrase matching, and parametrized integer index. Although the integer index is still recommended unparametrized This is the new error: {
"error": "Bad request: Index required but not found for \"t\" of one of the following types: [text (with phrase_matching: true)]. Help: Create an index for this key or use a different filter."
} |
generall
approved these changes
Jun 24, 2025
coszio
added a commit
that referenced
this pull request
Jun 24, 2025
* add `"match": { "phrase": ... }` condition
* gen grpc and openapi
* [phrase matching] expose `phrase_matching` flag in rest and grpc (#6620)
* expose setting in rest and grpc
* phrase matching openapi test
* regen openapi
* [phrase matching] Text index fixes (#6730)
* allow rocksdb-based immutable text index
* fix repeated-token phrases
* fmt
* Update OpenAPI spec
---------
Co-authored-by: timvisee <tim@visee.me>
* add repeated word case in openapi test
* [phrase match | strict mode] Allow phrase condition when enabled in index (#6749)
* allow phrase filter when index is present
* prettier error message
* clippppppy
---------
Co-authored-by: timvisee <tim@visee.me>
generall
pushed a commit
that referenced
this pull request
Jul 17, 2025
* add `"match": { "phrase": ... }` condition
* gen grpc and openapi
* [phrase matching] expose `phrase_matching` flag in rest and grpc (#6620)
* expose setting in rest and grpc
* phrase matching openapi test
* regen openapi
* [phrase matching] Text index fixes (#6730)
* allow rocksdb-based immutable text index
* fix repeated-token phrases
* fmt
* Update OpenAPI spec
---------
Co-authored-by: timvisee <tim@visee.me>
* add repeated word case in openapi test
* [phrase match | strict mode] Allow phrase condition when enabled in index (#6749)
* allow phrase filter when index is present
* prettier error message
* clippppppy
---------
Co-authored-by: timvisee <tim@visee.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #6670
Fixes the check for phrase index, so that strict mode allows phrase conditions when the text index has
phrase_matchingenabled