Skip to content

🌐 Internationalization and localization of document.#878

Merged
akaszynski merged 6 commits intopyvista:masterfrom
tkoyama010:patch-6
Sep 2, 2020
Merged

🌐 Internationalization and localization of document.#878
akaszynski merged 6 commits intopyvista:masterfrom
tkoyama010:patch-6

Conversation

@tkoyama010
Copy link
Copy Markdown
Member

@tkoyama010 tkoyama010 commented Sep 1, 2020

Hi all. I translate the pyvista document to my native language Japanese and release it in read the docs. Easiest way to translate sphinx document is to make CI repository and translate document in Transifex. sphinx project translate their document in this way by this CI and I follow this way.

I know that there is no resource to translate all language. But I want to give a framework to translate document to other translator.

Overview

🌐 Internationalization and localization of document.

I did the same thing in mayavi project.
enthought/mayavi#841

Details

Here is the contributing to sphinx document translation section of sphinx.

I use Read the Docs because they have a function to project with multiple translations function.

Feel free to discuss 👍

@tkoyama010 tkoyama010 marked this pull request as ready for review September 1, 2020 09:55
@tkoyama010 tkoyama010 marked this pull request as draft September 2, 2020 00:11
@tkoyama010 tkoyama010 marked this pull request as ready for review September 2, 2020 00:11
@tkoyama010 tkoyama010 marked this pull request as draft September 2, 2020 00:24
@akaszynski
Copy link
Copy Markdown
Member

This is really cool!

tkoyama010 added a commit to pyvista/pyvista-doc-translations that referenced this pull request Sep 2, 2020
tkoyama010 added a commit to pyvista/pyvista-doc-translations that referenced this pull request Sep 2, 2020
* typo fix (#864)

* ✏️ fix format of python code (#866)

* fix format of python code

We need 1 blank line before python code.

* fix format of python code

* fix format of python code

* fix format of python code

* fix format of python code

* Control points merging in the glyph filter (#870)

* Add clean paramter to the glyph filter

* Use tolerance parameter

* Set default tolerance=None

* Add RubberBand2D interactor style (#872)

* Add RubberBand2D interactor style

* Update testing

* Use format instead of fstring

* Enable smooth shading for textures (#865)

* ✏️ Fix typos. (#875)

* ✏️ Fix typos. (#876)

* ✏️ Fix typos.

* ✏️ Fix typos.

* 🌐 Internationalization and localization.

* 🏷️ add tag to translate title

Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com>
Co-authored-by: Bane Sullivan <banesullivan@gmail.com>
@tkoyama010
Copy link
Copy Markdown
Member Author

It is ready for reivew.

@tkoyama010 tkoyama010 marked this pull request as ready for review September 2, 2020 01:35
Copy link
Copy Markdown
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with suggestions. Thanks for your work. I visited your translated page and while I can't read Japanese, it's clear that you put in a lot of work into the translation. Thanks!

@akaszynski akaszynski merged commit e9e661f into pyvista:master Sep 2, 2020
@tkoyama010 tkoyama010 deleted the patch-6 branch September 2, 2020 12:13
akaszynski pushed a commit that referenced this pull request Sep 2, 2020
@akaszynski akaszynski mentioned this pull request Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants