Skip to content

✏️ Fix typos.#876

Merged
akaszynski merged 2 commits intopyvista:masterfrom
tkoyama010:patch-5
Aug 31, 2020
Merged

✏️ Fix typos.#876
akaszynski merged 2 commits intopyvista:masterfrom
tkoyama010:patch-5

Conversation

@tkoyama010
Copy link
Copy Markdown
Member

Overview

✏️ Fix typos.

Details

  • None

@larsoner
Copy link
Copy Markdown
Contributor

A complementary PR to https://github.com/codespell-project/codespell would be great

@tkoyama010 tkoyama010 marked this pull request as ready for review August 31, 2020 17:37
@akaszynski akaszynski merged commit f1fb4b8 into pyvista:master Aug 31, 2020
akaszynski added a commit that referenced this pull request Sep 2, 2020
* 🌐 Internationalization and localization.

* 🏷️ add tag to translate title

* Patch 6 (#3)

* typo fix (#864)

* ✏️ fix format of python code (#866)

* fix format of python code

We need 1 blank line before python code.

* fix format of python code

* fix format of python code

* fix format of python code

* fix format of python code

* Control points merging in the glyph filter (#870)

* Add clean paramter to the glyph filter

* Use tolerance parameter

* Set default tolerance=None

* Add RubberBand2D interactor style (#872)

* Add RubberBand2D interactor style

* Update testing

* Use format instead of fstring

* Enable smooth shading for textures (#865)

* ✏️ Fix typos. (#875)

* ✏️ Fix typos. (#876)

* ✏️ Fix typos.

* ✏️ Fix typos.

* 🌐 Internationalization and localization.

* 🏷️ add tag to translate title

Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com>
Co-authored-by: Bane Sullivan <banesullivan@gmail.com>

* Update docs/index.rst

Co-authored-by: Alex Kaszynski <akascap@gmail.com>

* small fix by review

Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com>
Co-authored-by: Bane Sullivan <banesullivan@gmail.com>
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
akaszynski added a commit that referenced this pull request Jan 22, 2021
* Patch 6 (#3)

* typo fix (#864)

* ✏️ fix format of python code (#866)

* fix format of python code

We need 1 blank line before python code.

* fix format of python code

* fix format of python code

* fix format of python code

* fix format of python code

* Control points merging in the glyph filter (#870)

* Add clean paramter to the glyph filter

* Use tolerance parameter

* Set default tolerance=None

* Add RubberBand2D interactor style (#872)

* Add RubberBand2D interactor style

* Update testing

* Use format instead of fstring

* Enable smooth shading for textures (#865)

* ✏️ Fix typos. (#875)

* ✏️ Fix typos. (#876)

* ✏️ Fix typos.

* ✏️ Fix typos.

* 🌐 Internationalization and localization.

* 🏷️ add tag to translate title

Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com>
Co-authored-by: Bane Sullivan <banesullivan@gmail.com>

* Patch 6 (#4)

* typo fix (#864)

* ✏️ fix format of python code (#866)

* fix format of python code

We need 1 blank line before python code.

* fix format of python code

* fix format of python code

* fix format of python code

* fix format of python code

* Control points merging in the glyph filter (#870)

* Add clean paramter to the glyph filter

* Use tolerance parameter

* Set default tolerance=None

* Add RubberBand2D interactor style (#872)

* Add RubberBand2D interactor style

* Update testing

* Use format instead of fstring

* Enable smooth shading for textures (#865)

* ✏️ Fix typos. (#875)

* ✏️ Fix typos. (#876)

* ✏️ Fix typos.

* ✏️ Fix typos.

* 🌐 Internationalization and localization.

* 🏷️ add tag to translate title

* Update docs/index.rst

Co-authored-by: Alex Kaszynski <akascap@gmail.com>

* small fix by review

Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com>
Co-authored-by: Bane Sullivan <banesullivan@gmail.com>
Co-authored-by: Alex Kaszynski <akascap@gmail.com>

* 📷 Add test camera zoom and up

* 📷 Add camera zoom and up

* ♻️ Add Camera class

* ♻️ Add docstring

* ♻️ Add Camera class

* ♻️ Add Camera class

* ♻️ Fix arg name

* ♻️ Update Pythonic

* Fix error

* Fix error

* Fix error

* Change Camera class

inherit from vtkCamera

* Clean import

* Move the Camera class to its own file.

* Improve coverage with unit testing specific to the camera class

Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com>
Co-authored-by: Bane Sullivan <banesullivan@gmail.com>
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants