Enable smooth shading for textures#865
Merged
banesullivan merged 1 commit intomasterfrom Aug 20, 2020
Merged
Conversation
larsoner
approved these changes
Aug 20, 2020
akaszynski
added a commit
that referenced
this pull request
Sep 2, 2020
* 🌐 Internationalization and localization. * 🏷️ add tag to translate title * Patch 6 (#3) * typo fix (#864) * ✏️ fix format of python code (#866) * fix format of python code We need 1 blank line before python code. * fix format of python code * fix format of python code * fix format of python code * fix format of python code * Control points merging in the glyph filter (#870) * Add clean paramter to the glyph filter * Use tolerance parameter * Set default tolerance=None * Add RubberBand2D interactor style (#872) * Add RubberBand2D interactor style * Update testing * Use format instead of fstring * Enable smooth shading for textures (#865) * ✏️ Fix typos. (#875) * ✏️ Fix typos. (#876) * ✏️ Fix typos. * ✏️ Fix typos. * 🌐 Internationalization and localization. * 🏷️ add tag to translate title Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com> Co-authored-by: Bane Sullivan <banesullivan@gmail.com> * Update docs/index.rst Co-authored-by: Alex Kaszynski <akascap@gmail.com> * small fix by review Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com> Co-authored-by: Bane Sullivan <banesullivan@gmail.com> Co-authored-by: Alex Kaszynski <akascap@gmail.com>
Merged
akaszynski
added a commit
that referenced
this pull request
Jan 22, 2021
* Patch 6 (#3) * typo fix (#864) * ✏️ fix format of python code (#866) * fix format of python code We need 1 blank line before python code. * fix format of python code * fix format of python code * fix format of python code * fix format of python code * Control points merging in the glyph filter (#870) * Add clean paramter to the glyph filter * Use tolerance parameter * Set default tolerance=None * Add RubberBand2D interactor style (#872) * Add RubberBand2D interactor style * Update testing * Use format instead of fstring * Enable smooth shading for textures (#865) * ✏️ Fix typos. (#875) * ✏️ Fix typos. (#876) * ✏️ Fix typos. * ✏️ Fix typos. * 🌐 Internationalization and localization. * 🏷️ add tag to translate title Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com> Co-authored-by: Bane Sullivan <banesullivan@gmail.com> * Patch 6 (#4) * typo fix (#864) * ✏️ fix format of python code (#866) * fix format of python code We need 1 blank line before python code. * fix format of python code * fix format of python code * fix format of python code * fix format of python code * Control points merging in the glyph filter (#870) * Add clean paramter to the glyph filter * Use tolerance parameter * Set default tolerance=None * Add RubberBand2D interactor style (#872) * Add RubberBand2D interactor style * Update testing * Use format instead of fstring * Enable smooth shading for textures (#865) * ✏️ Fix typos. (#875) * ✏️ Fix typos. (#876) * ✏️ Fix typos. * ✏️ Fix typos. * 🌐 Internationalization and localization. * 🏷️ add tag to translate title * Update docs/index.rst Co-authored-by: Alex Kaszynski <akascap@gmail.com> * small fix by review Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com> Co-authored-by: Bane Sullivan <banesullivan@gmail.com> Co-authored-by: Alex Kaszynski <akascap@gmail.com> * 📷 Add test camera zoom and up * 📷 Add camera zoom and up * ♻️ Add Camera class * ♻️ Add docstring * ♻️ Add Camera class * ♻️ Add Camera class * ♻️ Fix arg name * ♻️ Update Pythonic * Fix error * Fix error * Fix error * Change Camera class inherit from vtkCamera * Clean import * Move the Camera class to its own file. * Improve coverage with unit testing specific to the camera class Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com> Co-authored-by: Bane Sullivan <banesullivan@gmail.com> Co-authored-by: Alex Kaszynski <akascap@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on pyvista/pyvista-support#230, I noticed that the active
t_coordswould get wiped when doing thesmooth_shadingoption. This fixes that