new triton main pin by ngimel · Pull Request #95896 · pytorch/pytorch

ngimel · 2023-03-02T19:01:26Z

Fixes #ISSUE_NUMBER

pytorch-bot · 2023-03-02T19:01:30Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95896

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 Failures

As of commit e341481:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ngimel · 2023-03-02T23:32:49Z

@pytorchbot rebase

ngimel · 2023-03-06T18:31:53Z

@pytorchbot rebase

pytorchmergebot · 2023-03-06T18:33:52Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2023-03-06T18:33:58Z

Successfully rebased ngimel/triton_main_0301 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout ngimel/triton_main_0301 && git pull --rebase)

huydhn · 2023-03-06T19:30:38Z

@pytorchbot rebase -b master

pytorchmergebot · 2023-03-06T19:32:43Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2023-03-06T19:32:49Z

Successfully rebased ngimel/triton_main_0301 onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout ngimel/triton_main_0301 && git pull --rebase)

…into triton_main

ngimel · 2023-03-10T03:38:26Z

@pytorchbot merge -f "test failure unrelated"

pytorchmergebot · 2023-03-10T03:40:31Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

malfet · 2023-03-10T06:28:47Z

@pytorchbot merge -f "Now all version references has been properly updated"

malfet · 2023-03-10T06:29:44Z

Not exactly sure if this PR is contributing to failing the performance smoke test.

The newer the trition the lower the perf :) Will just tweak tolerances lower

pytorchmergebot · 2023-03-10T06:30:35Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

ngimel · 2023-03-10T07:10:24Z

@weiwangmeta Why isn't perf smoke test run on PR CI?
Edit: I see, it's just flaky

weiwangmeta · 2023-03-10T07:44:36Z

@weiwangmeta Why isn't perf smoke test run on PR CI? Edit: I see, it's just flaky

Yes it was run. My "theory" was the commit may just lowered certain percentage. The "flaky" (or runner run to run variation and/or runner to runner variation) became the "last straw on camel's back"... :)

malfet · 2023-03-10T15:35:00Z

Please do not revert due to the binary builds updates, this was dependent on change on builder side that I forgot to push yesterday, i.e. this one: pytorch/builder@8bcc106

ZainRizvi · 2023-03-10T16:44:40Z

@malfet to prevent this from happening again, what do you think about adding an auto-labeler rule to add ciflow/binaries_wheel when the .ci/docker/ci_commit_pins folder is modified?

ZainRizvi · 2023-03-10T16:51:11Z

Something like this: #96526

malfet · 2023-03-10T16:51:30Z

@ZainRizvi trunk workflow should have detected that. But I'll submit the change that reduces number of repetitions in the code

Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95896 Approved by: https://github.com/jansel

This reverts commit 6e0359d. Reverted pytorch/pytorch#95896 on behalf of https://github.com/huydhn due to I am not quite sure what this is about yet, but testing 3.8 wheel starts to fail https://hud.pytorch.org/pytorch/pytorch/commit/6e0359dd4233b0cec51521bec8869f0a46ebd98b

Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95896 Approved by: https://github.com/jansel, https://github.com/malfet

Define it once in `.ci/docker/trition_version.txt` and use everywhere. Also, patch version defined in `triton/__init__.py` as currently it always returns `2.0.0` even if package name is `2.1.0` Followup after #95896 where version needed to be updated in 4+ places Pull Request resolved: #96580 Approved by: https://github.com/huydhn

Automatically trigger binary builds when a commit pin is updated to ensure the new versions actually get tested. This is to prevent a recurrence of the build breaks introduced by #95896 (comment) Pull Request resolved: #96526 Approved by: https://github.com/huydhn, https://github.com/seemethere

This reverts commit 6e0359d. Reverted pytorch/pytorch#95896 on behalf of https://github.com/huydhn due to I am not quite sure what this is about yet, but testing 3.8 wheel starts to fail https://hud.pytorch.org/pytorch/pytorch/commit/6e0359dd4233b0cec51521bec8869f0a46ebd98b

Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95896 Approved by: https://github.com/jansel, https://github.com/malfet

Define it once in `.ci/docker/trition_version.txt` and use everywhere. Also, patch version defined in `triton/__init__.py` as currently it always returns `2.0.0` even if package name is `2.1.0` Followup after pytorch/pytorch#95896 where version needed to be updated in 4+ places Pull Request resolved: pytorch/pytorch#96580 Approved by: https://github.com/huydhn

Automatically trigger binary builds when a commit pin is updated to ensure the new versions actually get tested. This is to prevent a recurrence of the build breaks introduced by pytorch/pytorch#95896 (comment) Pull Request resolved: pytorch/pytorch#96526 Approved by: https://github.com/huydhn, https://github.com/seemethere

Define it once in `.ci/docker/trition_version.txt` and use everywhere. Also, patch version defined in `triton/__init__.py` as currently it always returns `2.0.0` even if package name is `2.1.0` Followup after pytorch/pytorch#95896 where version needed to be updated in 4+ places Pull Request resolved: pytorch/pytorch#96580 Approved by: https://github.com/huydhn

Automatically trigger binary builds when a commit pin is updated to ensure the new versions actually get tested. This is to prevent a recurrence of the build breaks introduced by pytorch/pytorch#95896 (comment) Pull Request resolved: pytorch/pytorch#96526 Approved by: https://github.com/huydhn, https://github.com/seemethere

new triton main pin

4a73cde

ngimel requested a review from jeffdaily as a code owner March 2, 2023 19:01

pytorch-bot bot added the topic: not user facing topic category label Mar 2, 2023

ngimel added the ciflow/inductor label Mar 2, 2023

Natalia Gimelshein added 2 commits March 4, 2023 20:23

update pin

225427e

update triton version in build_triton_wheel

03b64f0

ngimel requested a review from a team as a code owner March 4, 2023 20:38

huydhn mentioned this pull request Mar 4, 2023

Use working pre-built sccache binary #95997

Closed

pytorchmergebot force-pushed the ngimel/triton_main_0301 branch from 03b64f0 to 6f61924 Compare March 6, 2023 18:34

Natalia Gimelshein added 3 commits March 6, 2023 19:32

new triton main pin

cc60a33

update pin

48a085c

update triton version in build_triton_wheel

952c8f1

pytorchmergebot force-pushed the ngimel/triton_main_0301 branch from 6f61924 to 952c8f1 Compare March 6, 2023 19:32

Natalia Gimelshein added 3 commits March 6, 2023 23:43

Merge branch 'ngimel/triton_main_0301' of github.com:pytorch/pytorch …

1e9938d

…into triton_main

new pin

c46144c

1 stage for bsr triton kernels

13d3e2a

jansel approved these changes Mar 7, 2023

View reviewed changes

new pin

7dc9f6d

ngimel mentioned this pull request Mar 9, 2023

Inductor indexing kernels don't check for valid indices #93538

Closed

pin on torch-inductor-stable

5459f1f

pytorchmergebot closed this in 76cac70 Mar 10, 2023

ZainRizvi mentioned this pull request Mar 10, 2023

Autorun binary builds when a commit pin is updated #96526

Closed

weiwangmeta mentioned this pull request Mar 10, 2023

Performance drop slightly for inductor smoke test #96530

Closed

malfet mentioned this pull request Mar 11, 2023

[BE] Dedup hardcoded triton versions #96580

Closed

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023

new triton main pin (#95896)

72d0b80

Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95896 Approved by: https://github.com/jansel

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023

new triton main pin (#95896)

afaa18a

Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95896 Approved by: https://github.com/jansel, https://github.com/malfet

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 14, 2023

new triton main pin (#95896)

5d6d198

Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95896 Approved by: https://github.com/jansel, https://github.com/malfet

ngimel deleted the ngimel/triton_main_0301 branch March 14, 2023 06:09

betaboon mentioned this pull request Oct 13, 2023

Cyclic dependency created between torch 2.0 and triton #99622

Closed

Conversation

ngimel commented Mar 2, 2023

Uh oh!

pytorch-bot bot commented Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95896

❌ 9 Failures

Uh oh!

ngimel commented Mar 2, 2023

Uh oh!

ngimel commented Mar 6, 2023

Uh oh!

pytorchmergebot commented Mar 6, 2023

Uh oh!

pytorchmergebot commented Mar 6, 2023

Uh oh!

huydhn commented Mar 6, 2023

Uh oh!

pytorchmergebot commented Mar 6, 2023

Uh oh!

pytorchmergebot commented Mar 6, 2023

Uh oh!

ngimel commented Mar 10, 2023

Uh oh!

pytorchmergebot commented Mar 10, 2023

Merge started

Uh oh!

malfet commented Mar 10, 2023

Uh oh!

malfet commented Mar 10, 2023

Uh oh!

pytorchmergebot commented Mar 10, 2023

Merge started

Uh oh!

ngimel commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weiwangmeta commented Mar 10, 2023

Uh oh!

malfet commented Mar 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZainRizvi commented Mar 10, 2023

Uh oh!

ZainRizvi commented Mar 10, 2023

Uh oh!

malfet commented Mar 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pytorch-bot bot commented Mar 2, 2023 •

edited

Loading

ngimel commented Mar 10, 2023 •

edited

Loading

malfet commented Mar 10, 2023 •

edited

Loading