Autorun binary builds when a commit pin is updated#96526
Autorun binary builds when a commit pin is updated#96526
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96526
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 31ea3e1: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
malfet
left a comment
There was a problem hiding this comment.
Not really needed, single manywheel binary job that exists on trunk should be sufficient
Oh, I get it now. the PR didn't even have Having a rule to add |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
.github/labeler.yml
Outdated
| "ciflow/binaries_wheel": | ||
| - .ci/docker/ci_commit_pins/triton.txt | ||
|
|
||
| "ciflow/binary_conda": |
There was a problem hiding this comment.
Also can remove the latter here
There was a problem hiding this comment.
Not really needed, single manywheel binary job that exists on trunk should be sufficient
Not really needed, single manywheel binary job that exists on trunk should be sufficient
Oh, I get it now. the PR didn't even have
ciflow/trunkat first. Thus, no signal.Having a rule to add
ciflow/trunkwill help though in case the change was forced merge right off the bat.
Hmmm...I'm starting to really feel like we need to tweak mergebot somehow to make sure users realize when they're skipping trunk tests, to make sure it's a deliberate choice
There was a problem hiding this comment.
Yeah, this has been seen many times recently. I kind of miss the previous behavior of adding trunk right away after approval. Let's chat more on this with the team on how we can avoid this.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda11_7-test / test Details for Dev Infra teamRaised by workflow job |
|
@pytorchmergebot merge -f "Failure is unrelated" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Automatically trigger binary builds when a commit pin is updated to ensure the new versions actually get tested. This is to prevent a recurrence of the build breaks introduced by pytorch/pytorch#95896 (comment) Pull Request resolved: pytorch/pytorch#96526 Approved by: https://github.com/huydhn, https://github.com/seemethere
Automatically trigger binary builds when a commit pin is updated to ensure the new versions actually get tested. This is to prevent a recurrence of the build breaks introduced by pytorch/pytorch#95896 (comment) Pull Request resolved: pytorch/pytorch#96526 Approved by: https://github.com/huydhn, https://github.com/seemethere
|
Unintended side-effect of the change, is that it added Is there a way to exclude auto-labelling if PR title contains do-not-merge or its status is draft? |
Automatically trigger binary builds when a commit pin is updated to ensure the new versions actually get tested.
This is to prevent a recurrence of the build breaks introduced by #95896 (comment)