Skip to content

[BE] Dedup hardcoded triton versions#96580

Closed
malfet wants to merge 8 commits intomasterfrom
malfet/dedup-trition-versions
Closed

[BE] Dedup hardcoded triton versions#96580
malfet wants to merge 8 commits intomasterfrom
malfet/dedup-trition-versions

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented Mar 11, 2023

Define it once in .ci/docker/trition_version.txt and use everywhere.

Also, patch version defined in triton/__init__.py as currently it always returns 2.0.0 even if package name is 2.1.0

Followup after #95896 where version needed to be updated in 4+ places

Define it once in `.ci/docker/trition_version.txt` and use everywhere
@malfet malfet requested review from a team and jeffdaily as code owners March 11, 2023 00:58
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 11, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96580

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ee66eeb:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 11, 2023
Copy link
Copy Markdown
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! This is much nicer indeed, although there is still one on builder IIRC from your PR yesterday

@malfet malfet force-pushed the malfet/dedup-trition-versions branch from 6ba96c3 to b330ab1 Compare March 12, 2023 15:04
@malfet
Copy link
Copy Markdown
Contributor Author

malfet commented Mar 12, 2023

@pytorchbot merge -f "Build Trition + docker builds are green"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Copy Markdown
Contributor Author

malfet commented Mar 12, 2023

@pytorchbot revert -m "Forgot to fix lint" -c ignoredsignal

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@malfet your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Mar 12, 2023
This reverts commit c131e51.

Reverted #96580 on behalf of https://github.com/malfet due to Forgot to fix lint
@malfet malfet reopened this Mar 12, 2023
@malfet
Copy link
Copy Markdown
Contributor Author

malfet commented Mar 12, 2023

@pytorchbot merge -f "Lint + Triton + Docker builds are green"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023
Define it once in `.ci/docker/trition_version.txt` and use everywhere.

Also, patch version defined in `triton/__init__.py` as currently it always returns `2.0.0` even if package name is `2.1.0`

Followup after pytorch/pytorch#95896 where version needed to be updated in 4+ places
Pull Request resolved: pytorch/pytorch#96580
Approved by: https://github.com/huydhn
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023
Define it once in `.ci/docker/trition_version.txt` and use everywhere.

Also, patch version defined in `triton/__init__.py` as currently it always returns `2.0.0` even if package name is `2.1.0`

Followup after pytorch/pytorch#95896 where version needed to be updated in 4+ places
Pull Request resolved: pytorch/pytorch#96580
Approved by: https://github.com/huydhn
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
Define it once in `.ci/docker/trition_version.txt` and use everywhere.

Also, patch version defined in `triton/__init__.py` as currently it always returns `2.0.0` even if package name is `2.1.0`

Followup after pytorch/pytorch#95896 where version needed to be updated in 4+ places
Pull Request resolved: pytorch/pytorch#96580
Approved by: https://github.com/huydhn
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
Define it once in `.ci/docker/trition_version.txt` and use everywhere.

Also, patch version defined in `triton/__init__.py` as currently it always returns `2.0.0` even if package name is `2.1.0`

Followup after pytorch/pytorch#95896 where version needed to be updated in 4+ places
Pull Request resolved: pytorch/pytorch#96580
Approved by: https://github.com/huydhn
@github-actions github-actions bot deleted the malfet/dedup-trition-versions branch September 12, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants